Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Sep 2022 14:22:51 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Sumit Gupta <sumitg@nvidia.com>
Cc:     viresh.kumar@linaro.org, rafael@kernel.org, treding@nvidia.com,
        jonathanh@nvidia.com, linux-pm@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        bbasu@nvidia.com, sanjayc@nvidia.com, ksitaraman@nvidia.com
Subject: Re: [Patch] cpufreq: tegra239: Add support for T239
Message-ID: <YyMZG9ydqFYTWf0a@orome>
References: <20220905155759.17743-1-sumitg@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="VSgregLn1wDWg58s"
Content-Disposition: inline
In-Reply-To: <20220905155759.17743-1-sumitg@nvidia.com>
User-Agent: Mutt/2.2.7 (2022-08-07)
Precedence: bulk


--VSgregLn1wDWg58s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 05, 2022 at 09:27:59PM +0530, Sumit Gupta wrote:
> Adding support for Tegra239 SoC which has eight cores in
> a single cluster. Also, moving num_clusters to soc data

Found two more minor things: s/soc/SoC/ for consistent spelling.

> to avoid over allocating memory for four clusters always.
>=20
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> ---
>  drivers/cpufreq/tegra194-cpufreq.c | 29 +++++++++++++++--------------
>  1 file changed, 15 insertions(+), 14 deletions(-)
>=20
> diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra19=
4-cpufreq.c
> index 1216046cf4c2..f38a760da61b 100644
> --- a/drivers/cpufreq/tegra194-cpufreq.c
> +++ b/drivers/cpufreq/tegra194-cpufreq.c
> @@ -38,14 +38,6 @@
>  /* cpufreq transisition latency */
>  #define TEGRA_CPUFREQ_TRANSITION_LATENCY (300 * 1000) /* unit in nanosec=
onds */
> =20
> -enum cluster {
> -	CLUSTER0,
> -	CLUSTER1,
> -	CLUSTER2,
> -	CLUSTER3,
> -	MAX_CLUSTERS,
> -};
> -
>  struct tegra_cpu_ctr {
>  	u32 cpu;
>  	u32 coreclk_cnt, last_coreclk_cnt;
> @@ -67,12 +59,12 @@ struct tegra_cpufreq_ops {
>  struct tegra_cpufreq_soc {
>  	struct tegra_cpufreq_ops *ops;
>  	int maxcpus_per_cluster;
> +	size_t num_clusters;

Might want to make this unsigned int while at it. size_t is preferred
for things that actually refer to the size of something, while this is a
count, so unsigned int fits slightly better. It's admittedly a bit
pedantic...

Thierry

--VSgregLn1wDWg58s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmMjGRsACgkQ3SOs138+
s6Gx3A/+PaXRkEuVONdV64pgBJOx2j5tUm0Dfkscj3amnxKz3YN47Tx+PK2NtOn8
hILMZoXSyjHxthf3P8nbUlo/nPHR4ePvkBSyi0b/EFC9+0uiiSV1YFTV1I9EcVgX
OF6W/5S2HIPEDEo4KbAUXakJ824LBUdJhj61UPwnJHWEvF36kbgFzFufNiZiszoB
9mpw21qnU+GzleSvY6t4H18TpdU79m1q9YqAMgMCygWKVO0z4wFnU5HhSTAv43di
aEB695hAlsYai8sPJCe8aNnge+byMBdRg46Ex4AeW1j7jee9CbSaXfnSQBb7NrUC
dZzDmXocP+lvdQw6wWUE/47mlRpOUbz29ua9yibP1c7m0YqmkloBPZ270uqw2ZRz
SjXrxI49YARWAbfeUogcLzaZkhBZlW6XKMVDrhoGaxqFB7wVi88+zd8xx7QG+L3v
5JKDnWXAVWIQTd1u1SCpizAxfDEoit938q/Fu25LzfVw3x6+RYGNmVy/t3JRnHDi
t8xRC8dPUDu9F/Y7bduO0JCR/K9b5EhiIAtQHfTCzm8lvwQOcrM0vpRanTLcRmAy
QanNJbHdtTmwTKlhIo4VC5DTkaqnIs7DCG8sWb3WoBkE//jWOIJIqOzdGrSCrYKM
AedvQw3JND4aI1vsV4RryNqx46iHJHT5Gg531EoGgEb65xGw/u4=
=Zqyw
-----END PGP SIGNATURE-----

--VSgregLn1wDWg58s--