Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <33a16b15-3d3c-7485-d021-ee2a727e5391@amd.com>
Date:   Thu, 15 Sep 2022 18:32:16 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH v4 0/6] dma-buf: Check status of enable-signaling bit on
 debug
Content-Language: en-US
To:     =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220914164321.2156-1-Arvind.Yadav@amd.com>
 <d2d81ffd-2269-bdc6-0daa-8f3a99306e46@amd.com>
From:   "Yadav, Arvind" <arvyadav@amd.com>
In-Reply-To: <d2d81ffd-2269-bdc6-0daa-8f3a99306e46@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wlg4dXA3dmwwL3pJWGtzYmpWT2NXRVd6U0Z5aVdhTjM3NW5wM3lDL29JUlR3?=
 =?utf-8?B?Y2NKN0NLSURIeTBWWVd1TERJTVFBeWtLcW93Y0NSUERzNmgvVjE3NXZSbk9l?=
 =?utf-8?B?bWo3aDhoUzFnMTQ3bUxFamRBV2JUVXlrWlBSUVJRMngyVDFOZHJEL2pyM3lB?=
 =?utf-8?B?dExoMzNBVHFaVVJLaHcxdjlhQ3BPRms3UWpHRDFQWEo3bFhDYy8rUG01bG55?=
 =?utf-8?B?WVFUM1hkcytjSDZoM3YzUE1kdCtBTjhDMVFHa2lsUmpBN3NaOUpjNnE5VVkx?=
 =?utf-8?B?SWh1dERJZlF3QlV2Yk5GU1B0cnNCTm5TVThob2k0cU1QUWhsTnhPNGUrR0ZZ?=
 =?utf-8?B?VW5DL3JkQXhIWStWTWdLRXVoQmIySnhOazQ2Rm9qVnZqVjY0NTRnd0dIdkly?=
 =?utf-8?B?bFNJS0VSeFBTVHg2M3p3am5Od0VpbTdXT2E4cFBQcHlIcWFreXNpUVBaYkM0?=
 =?utf-8?B?UTFxUlJuWG95Z3RESHBQdFk3ck5HZTJta3krUlFiWkRCMXA0d0xPVDhLVDM2?=
 =?utf-8?B?VVgzbzJxM0VITStNNEs4VGtnTzlMUHVXZUd6aEl5MFZSYlR4TEQyblFHNEZS?=
 =?utf-8?B?aFRRZ1dTZGJ5UzU3OVg5WW1xZm12aGxHVEVnLzBESzZuVDNKWlhtTnVnUzQw?=
 =?utf-8?B?Y0Y0b1BHbmhnNUFubEJheDhKWUhjcnhpNXk4UzEzdytTSXE4NFRTQWtEd015?=
 =?utf-8?B?SXpia0V1bHpCQm5FcFVBaVBja1hISzBpRm1ZUmpVV09VNXYvbFZ5L0N2RzJY?=
 =?utf-8?B?bjJ2enkyYndvVEc5RXhtZlJhL2dsNzl3WllYZHp1aEt1TEgxVk1CT0RzRFM0?=
 =?utf-8?B?dlVVeVNzWHBMRlZuMy9tajVWWHRRMkd2bzFMek52Vks0NjRIYkpzaEt3Z1Q3?=
 =?utf-8?B?TTlLRTljSEVWYXlQaWIrUU9pa1JYRVdsVEpZQnJUYW10VmwxZmlGZzJKZm5v?=
 =?utf-8?B?VzcyUWVGSVhtajNSY1Z6KzlxSW1RNVkwUGZiZDdhNWVrWUd6WkpoOVpMRnUv?=
 =?utf-8?B?VU95UmU1WGpGS2taNDA0dGhQd0JtV2laT1UxMTZXenBmR2tBbFEvUnFmY3pi?=
 =?utf-8?B?WHRYZDd4c1B1cFlKVWxqRmNYRkZ0MHRqT0tHNEk3NlhPN3FYVzFyQW5LVjFL?=
 =?utf-8?B?S0RaaEF0eWhEZUh5SWZLVzFhSmNseW5BNWJoUWJsYTNoSkpEWlcxWDFCZ2l4?=
 =?utf-8?B?ZFhjKzFSOWhpNCsydzlsVFhGR0NpRlR2a3Z1ZmdIMnAvanRDT1l2MUxockdx?=
 =?utf-8?B?UmJ1T2JuK1BFNmRzNms1eVA3aGVVVWhUUkpFOGFFcWF0ZVY5eFhJSFo5Nm8v?=
 =?utf-8?B?Q1ZnWHRjN3NWNzhPTjBaNG5BUGRuYTFXVDduWi9Cc0xWWm1mZlNmSGFlNEdG?=
 =?utf-8?B?clJtcHp1OUo2cEY2clZXRjZYTEx6YmtqaXhHOFFRNFJycFhIS1VzalFqcCtS?=
 =?utf-8?B?NjF4SkpPM2l2eEdBQXZsM2RGWnF0UGhCdmMxdkVwWFl1V3NFdjZwNFFMMFVY?=
 =?utf-8?B?TTBrbFUxVUhOSzNCL3dvRkJ4U1AzREJ6L0dhekhHbGR0UlRndlkyY0JHdGdv?=
 =?utf-8?B?b2pxQ3F5KzQ0bGZXY0tVSnc0Rm9ZMENjamJFZC9kM0dJQndNN3FZTUlVUk0v?=
 =?utf-8?B?aE1KazhXNk1Sc2dFQjhwbjlsUytySGpsUklsUGVaVkZmZmQ0SThBVE9YS0Zj?=
 =?utf-8?B?UC9MaTB6SG9RSVdRaHd0MklZcVFXSlpyZEVGaXZzT3l1MEhZTnIyTFRhNmFj?=
 =?utf-8?B?MmFpanZnbzdaVEswVVVNWjZ0ODltaGFpMXMzY1FnMHJBNXkydHh2QnJYZkhC?=
 =?utf-8?B?TGtCOHg2Q1E0OWx5WkRmU0hNc1h6am9hbk5YZTVOWU1lUHdsQ2ZTZkxjQkdz?=
 =?utf-8?B?Z1QxcDU2NXBHM0k5RFdla2Fla2NUTjJIQ2dxK08rNlYyTjZzbmVVMHRkQzMv?=
 =?utf-8?B?SC9iSEJ2elJKcDVGK3doMXBWem9KQ1MwSHp3anViTkhKMWQ4TXU3elJyTklC?=
 =?utf-8?B?UWdMZ0ZUZzJFVnhsaFdQTUpPZU9OYnJlcllSVWlBNUgrUUNQQk9tZEd3ckMw?=
 =?utf-8?B?Z3NkekFxc05DaE5BbFZPVU9oeFBVMW1iMkVId0puRzUwbUdFNHhzQ1g4NlFD?=
 =?utf-8?Q?TUG6ypCsG18ACupC72kloYhqd?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b747d3e1-6ef1-4ec0-20b3-08da971a8b8d
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6000.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 13:02:29.6321
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ubKWzkS7GyYyBqe0Xt0AJ7g5x/EXbsALZCQzHs42AvHEmn+nD0uswTkjBinZTYkfRpZ6blAjIDBAbaNts0Cw2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7594
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/15/2022 5:37 PM, Christian König wrote:
> Is that sufficient to allow running a desktop on amdgpu with the extra 
> check enabled? If yes that would be quite a milestone.
>
Yes, It is running on amdgpu with extra config enabled.
> What's left is checking the userspace IGT tests. Especially the 
> sync_file and drm_syncobj tests I would expect to have problems with 
> this extra check.
>
Yes, IGT test cases are failing .

~Arvind

> Thanks,
> Christian.
>
> Am 14.09.22 um 18:43 schrieb Arvind Yadav:
>> Fence signaling must be enabled to make sure that
>> the dma_fence_is_signaled() function ever returns true.
>> Since drivers and implementations sometimes mess this up,
>> this ensures correct behaviour when DEBUG_WW_MUTEX_SLOWPATH
>> is used during debugging.
>> This should make any implementation bugs resulting in not
>> signaled fences much more obvious.
>>
>> Arvind Yadav (6):
>>    [PATCH v4 1/6] dma-buf: Remove the signaled bit status check
>>    [PATCH v4 2/6] dma-buf: set signaling bit for the stub fence
>>    [PATCH v4 3/6] dma-buf: Enable signaling on fence for selftests
>>    [PATCH v4 4/6] dma-buf: dma_fence_wait must enable signaling
>>    [PATCH v4 5/6] drm/sched: Use parent fence instead of finished
>>    [PATCH v4 6/6] dma-buf: Check status of enable-signaling bit on debug
>>
>>   drivers/dma-buf/Kconfig                |  7 +++++++
>>   drivers/dma-buf/dma-fence.c            | 16 ++++++++++------
>>   drivers/dma-buf/st-dma-fence-chain.c   |  4 ++++
>>   drivers/dma-buf/st-dma-fence-unwrap.c  | 22 ++++++++++++++++++++++
>>   drivers/dma-buf/st-dma-fence.c         | 16 ++++++++++++++++
>>   drivers/dma-buf/st-dma-resv.c          | 10 ++++++++++
>>   drivers/gpu/drm/scheduler/sched_main.c |  4 ++--
>>   include/linux/dma-fence.h              |  5 +++++
>>   8 files changed, 76 insertions(+), 8 deletions(-)
>>
>