Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Han Xu <han.xu@nxp.com>
To:     Abel Vesa <abelvesa@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-clk@vger.kernel.org (open list:NXP i.MX CLOCK DRIVERS),
        linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE IMX
        / MXC ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list)
Cc:     miquel.raynal@bootlin.com, linux-mtd@lists.infradead.org,
        han.xu@nxp.com
Subject: [PATCH v2] clk: imx: imx6sx: remove the SET_RATE_PARENT flag for QSPI clocks
Date:   Thu, 15 Sep 2022 10:09:59 -0500
Message-Id: <20220915150959.3646702-1-han.xu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FY3pt8wUOto06xR43+ET8xvGLdRwlqU3sb6q5xQHANF/tePVK8JkATJlg4r/?=
 =?us-ascii?Q?AjOJX6vpk77y3GqRT/3e3rTubuQzAXQrxKvUJVTpTwO37vpQkrMIS7U8pnMC?=
 =?us-ascii?Q?Ac/WQLniQfIvWRPMFcLLMrEvzsKsDJyvrfSvJ5OVa0fIX8WyJL1EJQPaBY9B?=
 =?us-ascii?Q?Z00U+5OAuhYmGlwWRJpKw6BqLRn9/V9hXEIqp8eHHPz6cazZLc0xDNc5X0/U?=
 =?us-ascii?Q?acd3tXP+R2b5BO86tXfQBKhed6gTiXmkAnZHA0tK7cZzHwFoVL71EwPYuDU0?=
 =?us-ascii?Q?jDM3WrIpyhe+0sK8+lSN3CcsjhdEMZiyBi78EARdiz08BIU1AwmA+JkJEHkn?=
 =?us-ascii?Q?SxV874vdeGhEcT034PrTYVJ++WPujueA0dIucnZLFwy5chKfE4Ufxh4yN69/?=
 =?us-ascii?Q?xr3jGVMzgznbTH/FkyQMC4LNKqCRWhhvo7oTSr9JRPigsvfyC8XgIVEoJPOb?=
 =?us-ascii?Q?ZYk+5bu/4biAK1vnwqEafT73MVXRa2iNmmPO3b0RtW3T4vfjxlbDxkLu38h8?=
 =?us-ascii?Q?XjjRxW9c4k/M3XTZgpPTBRhS0Q7Vi/JvaeGp3mSDG4ZdAjnP8hA0bVsCEVfP?=
 =?us-ascii?Q?Mr5Mxjjui+tacHFxJERb0t1VQlbf8js7LIgWE/Qp4hPS/akU7pPmVGwLUeWP?=
 =?us-ascii?Q?FSvobR6RrARqPosebiKHhJZTEOUldqL4E3J1PEzrn4pit8tIRo0zb3EEzzWF?=
 =?us-ascii?Q?U/L3R+JptsjoVxf7GMJ5EOx5kitmsSY/ntgAwbAmRMY9NLFp4/kadRhVOQhv?=
 =?us-ascii?Q?bOgTP6yuWqqn/Nqns1BPBmFEzJ2OMGKgzCl4X/CxYG77NbMYp4uhWcw9OdxK?=
 =?us-ascii?Q?J4K79BCVV+2LMTAqJQlfiFxRlWx8AyzCNR0ucuJkvdahb3v2EhunsXS1jI8d?=
 =?us-ascii?Q?eiUirWBxyNk6wmkrOmRAzdn5nKUX353P+DRB5qinkwFfjz4zCEgkqX78P9kf?=
 =?us-ascii?Q?0+CBHBFxsc+G9i50Cwl65GbyfCmpI4BTUx5CsL3a6GFyGbwhNmOhRfLsS+X6?=
 =?us-ascii?Q?PyteAQAp8WEgsYF47EzYvajeMXO2/ATAOuUWbwlvjUesN5Mm2/jTuk9Srkjc?=
 =?us-ascii?Q?ZJkA7ENPRMUaEeRauWMFcXGD9R8aSRzl0MZxV1B2KznEw3JOlRKIUaFnpUQg?=
 =?us-ascii?Q?KlND+4COcLNO1ivG1KHkcpMIX1oYYwok+GMFYA5p/WSNpRxB8nl7yJyHnkYt?=
 =?us-ascii?Q?k0jW6PUp/5akuRi5Th+NWKJkb8xNfJE/ya396ykAPBqzS6tyDGGbMfUWQ1Fo?=
 =?us-ascii?Q?woxswbUXwJSRnL76slYwqLt4pnu/cNpbQhPG4Z+I56SbmkIqX6Qk0tE4mall?=
 =?us-ascii?Q?gKorJwXwnMcXAHxBI8QgkTdCjB1lDoPYKqMnMhFZjlCcsEh7jlwtV+/aWpIu?=
 =?us-ascii?Q?DOeuxJIj87+cPNLbhULTUMrFjpgt+QDUBW+Noa9M6bHV0xFHIHODLIXNULZl?=
 =?us-ascii?Q?RjOr3mahIWYAKvZ9WNXB2I7gMRlwEY73uA3uHNCdo+qhf4inGc6vIHHfT825?=
 =?us-ascii?Q?Dsjo6dTgvAbsdjrnoWWV2DJx5OrKbb0I+h9xzBCu0bCPVLBfOcl9AAJ/j8Xw?=
 =?us-ascii?Q?asqVPwveS7zktivauLY=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3650d05b-b5a8-471b-fedc-08da972c65cd
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8774.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 15:10:17.3074
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zBF0aDzZF68jO/GDVTC/BPIgBM8ayC5Jeg7tfsgCWkl8In00iReUEtq83SlSPpuw
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7814
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

There is no dedicate parent clock for QSPI so SET_RATE_PARENT flag
should not be used. For instance, the default parent clock for QSPI is
pll2_bus, which is also the parent clock for quite a few modules, such
as MMDC, once GPMI NAND set clock rate for EDO5 mode can cause system
hang due to pll2_bus rate changed.

Fixes: f1541e15e38e ("clk: imx6sx: Switch to clk_hw based API")
Signed-off-by: Han Xu <han.xu@nxp.com>

---
changes in v2
- fix the build break due to missing close parenthesis
---
 drivers/clk/imx/clk-imx6sx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/imx/clk-imx6sx.c b/drivers/clk/imx/clk-imx6sx.c
index 2301d8fb8c76..d9ff831bdf47 100644
--- a/drivers/clk/imx/clk-imx6sx.c
+++ b/drivers/clk/imx/clk-imx6sx.c
@@ -324,13 +324,13 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node)
 	hws[IMX6SX_CLK_SSI3_SEL]           = imx_clk_hw_mux("ssi3_sel",         base + 0x1c,  14,     2,      ssi_sels,          ARRAY_SIZE(ssi_sels));
 	hws[IMX6SX_CLK_SSI2_SEL]           = imx_clk_hw_mux("ssi2_sel",         base + 0x1c,  12,     2,      ssi_sels,          ARRAY_SIZE(ssi_sels));
 	hws[IMX6SX_CLK_SSI1_SEL]           = imx_clk_hw_mux("ssi1_sel",         base + 0x1c,  10,     2,      ssi_sels,          ARRAY_SIZE(ssi_sels));
-	hws[IMX6SX_CLK_QSPI1_SEL]          = imx_clk_hw_mux_flags("qspi1_sel", base + 0x1c,  7, 3, qspi1_sels, ARRAY_SIZE(qspi1_sels), CLK_SET_RATE_PARENT);
+	hws[IMX6SX_CLK_QSPI1_SEL]          = imx_clk_hw_mux("qspi1_sel",        base + 0x1c,  7,      3,      qspi1_sels,        ARRAY_SIZE(qspi1_sels));
 	hws[IMX6SX_CLK_PERCLK_SEL]         = imx_clk_hw_mux("perclk_sel",       base + 0x1c,  6,      1,      perclk_sels,       ARRAY_SIZE(perclk_sels));
 	hws[IMX6SX_CLK_VID_SEL]            = imx_clk_hw_mux("vid_sel",          base + 0x20,  21,     3,      vid_sels,          ARRAY_SIZE(vid_sels));
 	hws[IMX6SX_CLK_ESAI_SEL]           = imx_clk_hw_mux("esai_sel",         base + 0x20,  19,     2,      audio_sels,        ARRAY_SIZE(audio_sels));
 	hws[IMX6SX_CLK_CAN_SEL]            = imx_clk_hw_mux("can_sel",          base + 0x20,  8,      2,      can_sels,          ARRAY_SIZE(can_sels));
 	hws[IMX6SX_CLK_UART_SEL]           = imx_clk_hw_mux("uart_sel",         base + 0x24,  6,      1,      uart_sels,         ARRAY_SIZE(uart_sels));
-	hws[IMX6SX_CLK_QSPI2_SEL]          = imx_clk_hw_mux_flags("qspi2_sel", base + 0x2c, 15, 3, qspi2_sels, ARRAY_SIZE(qspi2_sels), CLK_SET_RATE_PARENT);
+	hws[IMX6SX_CLK_QSPI2_SEL]          = imx_clk_hw_mux("qspi2_sel",        base + 0x2c,  15,     3,      qspi2_sels,        ARRAY_SIZE(qspi2_sels));
 	hws[IMX6SX_CLK_SPDIF_SEL]          = imx_clk_hw_mux("spdif_sel",        base + 0x30,  20,     2,      audio_sels,        ARRAY_SIZE(audio_sels));
 	hws[IMX6SX_CLK_AUDIO_SEL]          = imx_clk_hw_mux("audio_sel",        base + 0x30,  7,      2,      audio_sels,        ARRAY_SIZE(audio_sels));
 	hws[IMX6SX_CLK_ENET_PRE_SEL]       = imx_clk_hw_mux("enet_pre_sel",     base + 0x34,  15,     3,      enet_pre_sels,     ARRAY_SIZE(enet_pre_sels));
-- 
2.25.1