Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9b8736f0cc3c68bbec52aab503aeaec74e60ae87.camel@gmail.com>
Subject: Re: [PATCH v2] iio: pressure: bmp280: fix datasheet links
From:   Angel Iglesias <ang.iglesiasg@gmail.com>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     linux-iio <linux-iio@vger.kernel.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Paul Cercueil <paul@crapouillou.net>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        linux-kernel@vger.kernel.org
Date:   Thu, 15 Sep 2022 16:59:54 +0200
In-Reply-To: <20220915143944.79348ecb@jic23-huawei>
References: <CAHp75VeSsVD8rMz-Cj6kFovqdQQPjbH7rUXWS6paRtsBaB-Kww@mail.gmail.com>
         <20220912222645.377874-1-ang.iglesiasg@gmail.com>
         <20220915143944.79348ecb@jic23-huawei>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.module_f36+15386+a24ad1a3) 
MIME-Version: 1.0
Precedence: bulk

On jue, 2022-09-15 at 14:39 +0100, Jonathan Cameron wrote:
> On Tue, 13 Sep 2022 00:26:44 +0200
> Angel Iglesias <ang.iglesiasg@gmail.com> wrote:
>=20
> > Updated links for BMP280 and BME280 datasheets on Bosch website.
> > Datasheet of BMP180 is no longer available on the manufacturer's websit=
e,
> > changed the link to a copy hosted by a third party.
> >=20
> > Changelog in v2:
> > * Added a notice about the situation with bmp180 datasheet and list
> > =C2=A0 missing changes from newer versions.
> Change log needs to be below the ---
>=20
> We don't want that level of detail in the git logs.
>=20
> I tidied that up whilst applying.=20
>=20
> Also, it's not a good idea to have new versions as replies
> to older ones.=C2=A0 Leads to very deep nesting in email threads
> and generally makes things less readable.=C2=A0 Just post
> a fresh series each time.
>=20
> Applied to the togreg branch of iio.git and pushed out as testing=20
> for 0-day to see if it can find anything (rather unlikely on this
> patch!)
>=20
> Jonathan
>=20

OK, I'll keep it on my mind for future contributions. Thanks for your help =
and
patience!

Kind regards,
Angel

>=20
> >=20
> > Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> > ---
> > =C2=A0drivers/iio/pressure/bmp280-core.c | 12 +++++++++---
> > =C2=A01 file changed, 9 insertions(+), 3 deletions(-)
> >=20
> > diff --git a/drivers/iio/pressure/bmp280-core.c
> > b/drivers/iio/pressure/bmp280-core.c
> > index fe7aa81e7cc9..01cd32003ca8 100644
> > --- a/drivers/iio/pressure/bmp280-core.c
> > +++ b/drivers/iio/pressure/bmp280-core.c
> > @@ -9,9 +9,15 @@
> > =C2=A0 * Driver for Bosch Sensortec BMP180 and BMP280 digital pressure =
sensor.
> > =C2=A0 *
> > =C2=A0 * Datasheet:
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP1=
80-DS000-121.pdf
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP2=
80-DS001-12.pdf
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME2=
80_DS001-11.pdf
> > + * https://cdn-shop.adafruit.com/datasheets/BST-BMP180-DS000-09.pdf
> > + *
> > https://www.bosch-sensortec.com/media/boschsensortec/downloads/datashee=
ts/bst-bmp280-ds001.pdf
> > + *
> > https://www.bosch-sensortec.com/media/boschsensortec/downloads/datashee=
ts/bst-bme280-ds002.pdf
> > + *
> > + * Notice:
> > + * The link to the bmp180 datasheet points to an outdated version miss=
ing
> > these changes:
> > + * - Changed document referral from ANP015 to BST-MPS-AN004-00 on page=
 26
> > + * - Updated equation for B3 param on section 3.5 to ((((long)AC1 * 4 =
+ X3)
> > << oss) + 2) / 4
> > + * - Updated RoHS directive to 2011/65/EU effective 8 June 2011 on pag=
e 26
> > =C2=A0 */
> > =C2=A0
> > =C2=A0#define pr_fmt(fmt) "bmp280: " fmt
> >=20
> > base-commit: 2f61ff8272967c9bdcba810aa978170814b08f7c
>=20