Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220914080016.67951-1-namcaov@gmail.com> <1a1d346e-be81-19a5-5cb7-8b5ac896d835@gmail.com>
In-Reply-To: <1a1d346e-be81-19a5-5cb7-8b5ac896d835@gmail.com>
From:   Nam Cao <namcaov@gmail.com>
Date:   Thu, 15 Sep 2022 19:10:08 +0200
Message-ID: <CA+sZ8B__mUdYxCBqzD4TGAKKcaa1FtLsrJCQD=b9aYBKJhZUTA@mail.gmail.com>
Subject: Re: [PATCH] staging: vt6655: replace spin_lock_irqsave with spin_lock
To:     Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc:     forest@alittletooquiet.net, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Sep 14, 2022 at 8:55 PM Philipp Hortmann
<philipp.g.hortmann@gmail.com> wrote:
>
> On 9/14/22 10:00, Nam Cao wrote:
> > In vt6655 driver, there is a single interrupt handler: vnt_interrupt(),
> > and it does not take the spinlock. The interrupt handler only schedules
> > a workqueue, and the spinlock is taken in this workqueue. Thus, there is
> > no need to use spin_lock_irqsave, as the spinlock is never taken by an
> > interrupt. Replace spin_lock_irqsave (and spin_unlock_irqsave) with
> > spin_lock (and spin_unlock).
> >
> > Signed-off-by: Nam Cao <namcaov@gmail.com>
>
> Hi Nam,
>
> I am lol ... my computer freezed (you don mind if I do not try this
> patch again? Please send a v2) ;-)
> I was digging for the log see below. (kern.log)
> I hope you can do something with it.

Thank you so much for testing the patch and providing the log. I think my patch
introduces deadlock, which caused your computer to freeze. My bad, sorry about
that. I may send v2 in the future, when I fully understand what is going on.

Best regards,
Nam