Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Sep 2022 09:58:33 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Tony Nguyen <anthony.l.nguyen@intel.com>
CC:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        "John Fastabend" <john.fastabend@gmail.com>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>,
        <linux-hwmon@vger.kernel.org>,
        Alexander Duyck <alexander.duyck@gmail.com>,
        Gurucharan <gurucharanx.g@intel.com>
Subject: Re: [RESEND PATCH] ixgbe: Don't call kmap() on page allocated with
 GFP_ATOMIC
Message-ID: <YyNZuTlShCviTKXi@iweiny-desk3>
References: <20220915124012.28811-1-fmdefrancesco@gmail.com>
 <96855b74-5b77-4426-891b-d638ead17cd6@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <96855b74-5b77-4426-891b-d638ead17cd6@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1TGIQPOBLBQ5EO3gwJ1j9NcRI6T6yBUTwtZG53MU20QDOFLxENwF2uRZk0TI?=
 =?us-ascii?Q?AB2P3AlHHoUEBeAz8yZumSGwi8YzQqVCbyPrzoFtbiKEMEPBchS/m1xaJY+A?=
 =?us-ascii?Q?oi4jX3p1kNDDaOcMPcW5oRL9G6p6FnkmQV/B1Zp6zpiycg69+XqI4n9eYJI+?=
 =?us-ascii?Q?QcWuqo/+vjXDkU9Lb5gNGfamzbfLXBTvN+zmVzJQrSiU2h0TDmOkv6DRiAOO?=
 =?us-ascii?Q?ta3adXgadZzaTQUhFx8Ifp3GXtSZhaYizD5RYcOtQjiu5PJ4l8+1WMHSDvK9?=
 =?us-ascii?Q?6nxi/RFMflsDvPus5UQ8erYtQZaETN1m8Ye2v2iI/z2+Bg6BLuE9YaBddMQD?=
 =?us-ascii?Q?8yYS/EaX74OBIrEZQmkjSraB4oH7KKA9I129vyFcQ6GD6NvO+etdjiFKdFir?=
 =?us-ascii?Q?j7B3MqqJ+FMT1gbMYtSd+D6740gNgbpL/8vLEKGD+5hhXF7HxeXR+8hmmz6V?=
 =?us-ascii?Q?mSePJ1/6JZ8iAaRkHIAtyHF7kFN4tNrvgnlh9YXmhOeRu00vFvtSJMtyxjkP?=
 =?us-ascii?Q?QBA5Aar7k1DkQVAIhIZ5xzWnB7/bFSzhBrH7QXiD3Un0ZmFol1loXCcZDI4V?=
 =?us-ascii?Q?oHXVt9YxeFy9LT4k67GzWVnH9IhpsCVZsUNOWajSWZAnQcnQ1yOH4qDiI4+n?=
 =?us-ascii?Q?B5OkROV7f7gokEVqBgeQUfwTAva5rPsLBhvG8MNEFQFu2Tww+woellxQvde/?=
 =?us-ascii?Q?4oFf1D7J2bzR9dlAGf6zndaCIYcTgSUD+MQciUBzFZ4qcGN5ZuI0BHWvaHim?=
 =?us-ascii?Q?MGReMrZ2f5DPQNQ0TSkJ9YqZZ6kgK4f88h/W/76FAvUEo1wi/aVuwzWvbd8J?=
 =?us-ascii?Q?hcL6OcE4Da3+ornvzWm19R5G2ZhOngIhEBjkMDe7lmENc0K8QCQKWylOTZHk?=
 =?us-ascii?Q?geOH6EaKiQ8S04ouAE3EXWOhxOgeKUmIhsPS8sq7DEYq34+yg7ovrYxd1Y6G?=
 =?us-ascii?Q?+JSMwMtugMY6t7W8vBARNl24UCDzfyAhXgTnrcIK0Nrn6TaIVzfCqJUYlZHw?=
 =?us-ascii?Q?K69mdxnqoKugVAr41op34VA1BIMYgefVrFh3lZh5zOweWOU9qqFdv+yx1mN6?=
 =?us-ascii?Q?2HXY2xZECyX7EPBLuFtJojAgnYrgsIFZaZp8S6ERsuIYiCNM0jiBsm0AxbNU?=
 =?us-ascii?Q?7F3Cj8DXLfKAGb1U1uwEwKELBihZmWEfy8QagR5RSfRff++xBh95Zq/HQ/R8?=
 =?us-ascii?Q?WwqcOA7bYnuzheT/iIz2Bp9me4D99XEPkZ3t12iBJZpXILrn9VDR4usHhE4Z?=
 =?us-ascii?Q?stB/qAzRdk+lneikg8RZKKV03S1SCgm7ulrps+DzXlZ+f1mU1edX2wOZ8H0i?=
 =?us-ascii?Q?f8ahvT8ayrmvzrhL5XO/3Nd4TR544pQA4+GIz4tF99kNxvCZs/J773D8Xcwp?=
 =?us-ascii?Q?mGayLLlv0+S5+XGRBZfOU2LT9BBEruvIeZVCo2v9W4/pXfVC4v8Co9j9NRed?=
 =?us-ascii?Q?dBxXSnGgb08lnRk7TzQ2WaxWiijnfLQHr2Xe1a9kH1I/lICQKQDJty9YFpV+?=
 =?us-ascii?Q?kCv7N0tXK+vkIxCaVeMXe5h7yYE6KPeVybYr2hov5RkVii2GCTNnHqtCBTlw?=
 =?us-ascii?Q?HNaH5m567hQtiDWeZPLUS0ySrosW9ur71hMsztbu?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d1b3ba09-1594-41b1-d42b-08da973b896d
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 16:58:39.2449
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nNZc3Bi8Z3WkZdIqmXtYM3P3h4QmMDAStXKdUvFNzELmvSz1cYZesTK5OD9ltwOPMPKG1lS+aNfn36oXCZcreQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5660
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 15, 2022 at 09:30:50AM -0700, Tony Nguyen wrote:
> 
> 
> On 9/15/2022 5:40 AM, Fabio M. De Francesco wrote:
> > Pages allocated with GFP_ATOMIC cannot come from Highmem. This is why
> > there is no need to call kmap() on them.
> > 
> > Therefore, don't call kmap() on rx_buffer->page() and instead use a
> > plain page_address() to get the kernel address.
> > 
> > Suggested-by: Ira Weiny <ira.weiny@intel.com>
> > Suggested-by: Alexander Duyck <alexander.duyck@gmail.com>
> > Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> > Reviewed-by: Alexander Duyck <alexander.duyck@gmail.com>
> > Tested-by: Gurucharan <gurucharanx.g@intel.com>
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> > 
> > I send again this patch because it was submitted more than two months ago,
> > Monday 4th July 2022, but for one or more (good?) reasons it has not yet
> > reached Linus' tree. In the meantime I am also forwarding two "Reviewed-by"
> > and one "Tested-by" tags (thanks a lot to Ira, Alexander, Gurucharan).
> > Obviously I have not made any changes to the code.
> 
> Hi Fabio,
> 
> This is accepted into net-next already[1] and will land in the next kernel.

Thanks, sorry just saw this after sending my last.  :-/  :-D

Ira

> 
> Thanks,
> Tony
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=03f51719df032637250af828f9a1ffcc5695982d