Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Sep 2022 09:57:52 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>
CC:     Jesse Brandeburg <jesse.brandeburg@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "Jesper Dangaard Brouer" <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        "Jean Delvare" <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>,
        <linux-hwmon@vger.kernel.org>,
        Alexander Duyck <alexander.duyck@gmail.com>,
        Gurucharan <gurucharanx.g@intel.com>
Subject: Re: [RESEND PATCH] ixgbe: Don't call kmap() on page allocated with
 GFP_ATOMIC
Message-ID: <YyNZkPxbL6q1kd6r@iweiny-desk3>
References: <20220915124012.28811-1-fmdefrancesco@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220915124012.28811-1-fmdefrancesco@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VBXOmYZQMoIYYksNodVO96EPgVoZHRo1MLFGnYmiuWTI66vEdytf/ku5YxZ6?=
 =?us-ascii?Q?Oc7p2caGJYTcQm7W894RmixsdurC6VpmpHpCIlHgwbxIrXZIvq/HP/npNNdI?=
 =?us-ascii?Q?yNEPxw6fuf5Ih++kbIPNvQnd6StTRF+lwVrER34c1B1Y/yGULz4UdV5J7gKa?=
 =?us-ascii?Q?ql+ioc/xJMhl3NQvrCO+oN0dCV/iuqITVj8EJOCZa51y6gvR/e65Q9bhCABg?=
 =?us-ascii?Q?7+uZDUwonlzYeylw0KuYCmd0a/XAghcLvHt3Bb6ou9CWKVn+DWOmdo21tts4?=
 =?us-ascii?Q?zD7f2tViSCDaQdsr5A9DnY92YMIrNgWS8HCY22Pq5eYhtvhaaafUEYq3DOsQ?=
 =?us-ascii?Q?6jyHjjOcLvEVPy5XjGZ1oXAiRPtkQAc9C+6wC9moJNBjcI12avX/ygkFfgR2?=
 =?us-ascii?Q?8mB5Or9KPRdqHL9bCqsEICCnRRNwTixpBHUBnTbsHML90V3izS7XZLVQQO2a?=
 =?us-ascii?Q?LxIcroYgUPeuF4/HyQTuG7aCplUQUFj7QbbWAOkZDeHrK8PdNWFSIkv4wSw9?=
 =?us-ascii?Q?4VuI/tz6SUJVKan7jhIDxw8whjgFIRtbyD3pFcvodDgFjLeV7JkYhyvO/csK?=
 =?us-ascii?Q?gUy2aL+2gSOwBImrgMrvOEipySJ+bfJ8t+FcgtfBmVPGHwthSn4YVns9kZ9C?=
 =?us-ascii?Q?C9Axib2bwb5MufqDmlV8YBNzjctEyI0z4QebdzNYi8JJ2/7OacIlPigD1I6R?=
 =?us-ascii?Q?BX64iBCLz+g7hRuO/Nsg0n37m/jYrRVRQO9ZqyQtIXMNFOn6Sh2r79HbBv8K?=
 =?us-ascii?Q?ILWpt3z6WY3fQnhkf9U7BlYTBjZmLSsgDTm2sq7dMZYJpz3Xh4cqXoZ52GL/?=
 =?us-ascii?Q?w2NMv1aHA7sIs4arXnoJgtAOVedTqPKBZDkeWMLg6ZGlKLOgJBnxJDvmWs4l?=
 =?us-ascii?Q?mJ/r03JwEEMcXM0mY40rSjRbiiekkS86xrOy6PqGRzKll04FFFPVBWNPTEqb?=
 =?us-ascii?Q?wvmhLNRlWUe0mLnk2bUFWfBzdsL0NjtEhe/PmMiU9i3KMdaw6DsN9he/YRHE?=
 =?us-ascii?Q?cacSbGa7PHFfbF+Y8xoc3q0D6BtTlXPzN6H20Es395e5d2XLyB3CrojbDRih?=
 =?us-ascii?Q?0Im6sHEovqUCv15sQZ+EETqhok28oLTd9myOFp26wEKCpa7rUfn58llOkvdL?=
 =?us-ascii?Q?5A7MD+U/ydcHX4jQypFLXaX18F8ylvTuEdwIi08FVRRLdQRmSBB+kr9zMgI+?=
 =?us-ascii?Q?KsxF8NfEIxZDK/FTwWJx9ecl+NjNQcijsFy2VtBCRP00kOWAaV65OE7unTuk?=
 =?us-ascii?Q?KK4Hxm3gED8gVcCT1o1bEDexV3Umi0mXn03sSLBwzf63GOTcvpjS+tRbU/Ly?=
 =?us-ascii?Q?vnT5tZT6DGUOA61PY3ENzcNpESPk63ImHgwWCADDmCXUayRCtfLRuu2gIZxH?=
 =?us-ascii?Q?Wv8bML/AuRjrpv7BUYO501PNhIMbNN5wMHQg7VwE8WmpPz6iOpjrMim3aFJA?=
 =?us-ascii?Q?V06tVgN1qI8Z52RVHc+swMA/vsDyWxt41VcZ0TDeigRMSptyUx8sG1MMtSgm?=
 =?us-ascii?Q?xRcGVNLKS30juuUfsBbrvJhJxvi3faLnTOjGTnL6PSsUo6TAS+J4hy5Nd3p+?=
 =?us-ascii?Q?xCRBBxq/CBaq0HXIAVZ468fC7Vp2jJU4kdQ9GIX7?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a09ccf06-18d5-4155-3f6c-08da973b70f8
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 16:57:58.2403
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WihN6YKZzVAOhEgAE66K7/rofG0BM2o8ITnN9TsXnd9tpWNvtqZrlWtW7XzgwbiyaczQqOMKUY7i5cLG+BLpHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4751
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 15, 2022 at 02:40:12PM +0200, Fabio M. De Francesco wrote:
> Pages allocated with GFP_ATOMIC cannot come from Highmem. This is why
> there is no need to call kmap() on them.
> 
> Therefore, don't call kmap() on rx_buffer->page() and instead use a
> plain page_address() to get the kernel address.
> 
> Suggested-by: Ira Weiny <ira.weiny@intel.com>
> Suggested-by: Alexander Duyck <alexander.duyck@gmail.com>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Reviewed-by: Alexander Duyck <alexander.duyck@gmail.com>
> Tested-by: Gurucharan <gurucharanx.g@intel.com>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> 
> I send again this patch because it was submitted more than two months ago,
> Monday 4th July 2022, but for one or more (good?) reasons it has not yet
> reached Linus' tree. In the meantime I am also forwarding two "Reviewed-by"
> and one "Tested-by" tags (thanks a lot to Ira, Alexander, Gurucharan).
> Obviously I have not made any changes to the code.

I see this applied by Tony Nguyen in linux-next:

03f51719df03 ixgbe: Don't call kmap() on page allocated with GFP_ATOMIC

So I assume it will land in the next merge window?

Move Tony to the To line.

Ira

> 
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
> index 04f453eabef6..cb5c707538a5 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
> @@ -1964,15 +1964,13 @@ static bool ixgbe_check_lbtest_frame(struct ixgbe_rx_buffer *rx_buffer,
>  
>  	frame_size >>= 1;
>  
> -	data = kmap(rx_buffer->page) + rx_buffer->page_offset;
> +	data = page_address(rx_buffer->page) + rx_buffer->page_offset;
>  
>  	if (data[3] != 0xFF ||
>  	    data[frame_size + 10] != 0xBE ||
>  	    data[frame_size + 12] != 0xAF)
>  		match = false;
>  
> -	kunmap(rx_buffer->page);
> -
>  	return match;
>  }
>  
> -- 
> 2.37.2
>