Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1521456rwn; Thu, 15 Sep 2022 17:55:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7k69nHfYoocXvPnv4Q2bZWVpbIRtqR/QC/L+rnmevl0SCqx7H0lNNlmxPaTHu+NPIlvncH X-Received: by 2002:a17:90b:3e8b:b0:202:c85d:8ffa with SMTP id rj11-20020a17090b3e8b00b00202c85d8ffamr13742393pjb.155.1663289759387; Thu, 15 Sep 2022 17:55:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663289759; cv=none; d=google.com; s=arc-20160816; b=FH9hrkZI7ODcnHk8Coc53jaFvmJ0TJ1n2m2YRIJ8f1P/HGCvq13ge7wVoSi8gIf2gf 5YcI97ZnItaRDZjL4zEfgkKwHAy9YYAW2sRIokdl5ig+7Z+rMD3LOPPLd2Pi20AXHbPb uA23WaNGGajZ9KmpokuYB60NWD00tU0OLSXspFPTIicRWESeenERxY+9wLHl+yTuYOLD KGF4tkzxdKncufC+VDBZhNGluE2y44x+5Yh82qqqpldefJhkm3Ls9qgex84gZJHn50Pb UYV3+SHNkfPsMe2HCsYseZbCuGs5FZ45CWaNHB5vTlCAWo6XrJnpG3Pjxk6wVaa+nY1s s34g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=bSbNCUeLENVB8wVt9JCCDEElIgx000pYjkgdp0g56zA=; b=EV9xcSVEXXqoX24DTZDOTFt6SaOsBAY+8YY2Kznyv7XNKnneYmh5ZDlqLISY+ED7Hh WZx9Omj2bFj9P2zrWCajIoSXs+fRekhjmH4UNhtOuVKMGiklCj2G7j4mUgCc1NyyBJ3s joPzeYd88O7S6fSZeVergwGQkjU2rzlkLUbM3hJz37A4lEb+f1Zi/s1yHlxyO7KyfX9b t7YgrQJucj/AySeO321vyy7TvWY6ZyVBArDs2bmjM0me6x7P2UDdy0oMbGRyZ2+Hcv/s usD+p6C2MwuWKQ244IxEAh9CkvU+xRsa3UP+9lzJ7rY/DyneNPgQoFSgKLllM/yl31HN BlJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OLTrcrlk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q131-20020a632a89000000b004393adf2d36si10914516pgq.38.2022.09.15.17.55.46; Thu, 15 Sep 2022 17:55:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OLTrcrlk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229562AbiIPALV (ORCPT + 99 others); Thu, 15 Sep 2022 20:11:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiIPALU (ORCPT ); Thu, 15 Sep 2022 20:11:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E7DF57573 for ; Thu, 15 Sep 2022 17:11:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F37FA6277E for ; Fri, 16 Sep 2022 00:11:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95BEBC433C1; Fri, 16 Sep 2022 00:11:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663287078; bh=Vy69aml8hU2McMw2JQr1x3Oz7RBNUPYxKERbs9nrDQY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=OLTrcrlk//iYOL/3Cj/mI3AkwBU75vOjylohZ4EOEtPteOkOfto7yS/9SXMt7FpJE WjMzBujlqdlR39oRZOwJLgu/MHOIBZqaVFqcaseP5iXjetHW8AIPWC5Udxfi4du+u1 PTCyR2HlrDa7/051hMx2UeB/i/OflObry62g/u9eCK6nLQuhRg6FPCnJrVW9J7IcUn XPouayjNXw43swEHL4Mm0/lBXJmVg8pyXVVOrlMTIQsHMs2sj1Ns8m4m5esNP8++OQ XFSarM4KtTv9zMqJVp6iRxU2k5EViSOQylPG/aXwlfnvtjaUZelfutfvpe0d4Ykp+G 8g52HMWixRPmg== Date: Thu, 15 Sep 2022 17:11:16 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen/privcmd: remove privcmd_ioctl_mmap() In-Reply-To: Message-ID: References: <20220915083944.10097-1-jgross@suse.com> <8137166b-a4c2-aa26-84f9-7b9b2a7e028e@suse.com> <4a95c3d1-d4e8-9b59-8db8-231b59cdb8f5@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Sep 2022, Jan Beulich wrote: > On 15.09.2022 12:20, Juergen Gross wrote: > > On 15.09.22 11:32, Jan Beulich wrote: > >> On 15.09.2022 10:39, Juergen Gross wrote: > >>> The IOCTL_PRIVCMD_MMAP isn't in use by Xen since at least Xen 4.0. > >>> > >>> Remove it from the privcmd driver. > >>> > >>> Signed-off-by: Juergen Gross > >> > >> Can we reasonably remove an IOCTL, without being entirely certain that > >> no users exist outside of xen.git? > > > > This is a valid question. I'm not sure how probable it is that such a user > > is existing. Are there any Xen tool stacks not using the Xen libraries? > > > > If so, why? Do we want to support those use cases? > > I'm afraid I have no answers to these questions, and hence would generally > want to be conservative with removal of functionality. I don't know either, but maybe we could at least mark IOCTL_PRIVCMD_MMAP as deprecated in include/uapi/xen/privcmd.h ?