Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e46ea3ab-3202-bb3e-ebb6-a08444991ef0@quicinc.com>
Date:   Fri, 16 Sep 2022 09:34:05 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH v2] remoteproc: core: do pm relax when in RPROC_OFFLINE
To:     Mukesh Ojha <quic_mojha@quicinc.com>, <mathieu.poirier@linaro.org>
CC:     <linux-remoteproc@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_clew@quicinc.com>
References: <128dc161-8949-1146-bf8b-310aa33c06a8@quicinc.com>
 <1663236256-52289-1-git-send-email-quic_aiquny@quicinc.com>
 <2d6fb1c1-125b-7479-ed6c-7640c03a4cb8@quicinc.com>
From:   "Aiqun(Maria) Yu" <quic_aiquny@quicinc.com>
In-Reply-To: <2d6fb1c1-125b-7479-ed6c-7640c03a4cb8@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/15/2022 8:47 PM, Mukesh Ojha wrote:
> Hi,
> 
> On 9/15/2022 3:34 PM, Maria Yu wrote:
>> RPROC_OFFLINE state indicate there is no recovery process
>> is in progress and no chance to do the pm_relax.
>> Because when recovering from crash, rproc->lock is hold and
> 
> s/hold/held ?
> 
Thanks.
>> state is RPROC_CRASHED -> RPROC_OFFLINE -> RPROC_RUNNING,
>> and then unlock rproc->lock.
>> When the state is in RPROC_OFFLINE it means separate request
>> of rproc_stop was done and no need to hold the wakeup source
>> in crash handler to recover any more.
>>
>> Signed-off-by: Maria Yu <quic_aiquny@quicinc.com>
>> ---
>>   drivers/remoteproc/remoteproc_core.c | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/remoteproc/remoteproc_core.c 
>> b/drivers/remoteproc/remoteproc_core.c
>> index e5279ed9a8d7..247ced6b0655 100644
>> --- a/drivers/remoteproc/remoteproc_core.c
>> +++ b/drivers/remoteproc/remoteproc_core.c
>> @@ -1956,6 +1956,17 @@ static void rproc_crash_handler_work(struct 
>> work_struct *work)
>>       if (rproc->state == RPROC_CRASHED || rproc->state == 
>> RPROC_OFFLINE) {
>>           /* handle only the first crash detected */
>>           mutex_unlock(&rproc->lock);
>> +        /*
>> +         * RPROC_OFFLINE state indicate there is no recovery process
>> +         * is in progress and no chance to have pm_relax in place.
>> +         * Because when recovering from crash, rproc->lock is hold and
> 
> ..ditto..
> 
>> +         * state is RPROC_CRASHED -> RPROC_OFFLINE -> RPROC_RUNNING,
>> +         * and then unlock rproc->lock.
>> +         * RPROC_OFFLINE is only an intermediate state in recovery
>> +         * process.
>> +         */
>> +        if (rproc->state == RPROC_OFFLINE)
>> +            pm_relax(rproc->dev.parent);
> 
> 
> Looks good, apart from minor nit.
:)
> 
> Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
> 
> -Mukesh
>>           return;
>>       }


-- 
Thx and BRs,
Aiqun(Maria) Yu