Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     SEO HOYOUNG <hy50.seo@samsung.com>
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, beanhuo@micron.com, bvanassche@acm.org,
        bhoon95.kim@samsung.com, kwmad.kim@samsung.com
Subject: Re: [PATCH v2] scsi: ufs: add a variant operation in struct
 ufs_hba_variant_ops
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1czbw2ihu.fsf@ca-mkp.ca.oracle.com>
References: <CGME20220913075407epcas2p1075426e0ef45b6969e50823d59c374d3@epcas2p1.samsung.com>
        <20220912193703.102267-1-hy50.seo@samsung.com>
Date:   Thu, 15 Sep 2022 21:54:50 -0400
In-Reply-To: <20220912193703.102267-1-hy50.seo@samsung.com> (SEO HOYOUNG's
        message of "Tue, 13 Sep 2022 04:37:03 +0900")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Xy38+C6Mv0HGy6SsmwP8KvxEZIChBNC6rx/jg7y9gUqVaM3g7lnYd/JPk9c/?=
 =?us-ascii?Q?49OAIinxe+6Q65YbKYmijUh7sTjuoNjIzsDyyzQ2NSvpz2gWYPJjg1KvSj9k?=
 =?us-ascii?Q?aY9K+WOKjd5nnp+nGyHyuwuKdup2PouQp+p8mNe+pXuNlxHCg+AG3uYDharO?=
 =?us-ascii?Q?rjGO8Yb+bay2R4KwFdlygxD7wkzn9PLAErgUw3jUH8SNdhb0FqafhbnfzhlL?=
 =?us-ascii?Q?Hn6deaSt76H9uYyswf/PWHdPMrm5/tG8qHF6aoZlMSItPy2G8NCC84hW8DqX?=
 =?us-ascii?Q?4Mxb8tXQZTZDH6JYsNPtm8IhqlnD+lfzoNGzwIi8hKjoV6SI1ULCY4eSfFeX?=
 =?us-ascii?Q?3UaJOF5/29juSrg2l/MLECSR8IqYumSG6OtCEgiHqnCRXK/scUYc2cPNTg1H?=
 =?us-ascii?Q?2Go1gDX9vtzpSzUJU0qJtG32MMXXKRsvhTctRgONuCs8OWVPNJOVXa5/ZrK5?=
 =?us-ascii?Q?YIu8YA9s36iEY6wrUYNbyKr8y58BsHdkx3JNAW2xWAEfpEk/M+a4O2z/3tfu?=
 =?us-ascii?Q?hx7gze4GZuUELSpYDNWZZYwM3E6OgaHUuOoig8CLNZDHBsAfF97uNSEh/D9T?=
 =?us-ascii?Q?NhQ1oOzLey1Q194MfBjRuSB0bHbuSI9mSthdcEO1s0aRVviMCFd3eTblr14G?=
 =?us-ascii?Q?X2PH/BV+lv6KxP9+/3zASw7H3cLziUAn+M72o5fBqtdifsQ7Fs5KkPTrhhiM?=
 =?us-ascii?Q?rNHknn5JPFWefLPtn59joHmPeP99nZdPfEXsf2UOAkK1tYMQgTg4zwuRKZGN?=
 =?us-ascii?Q?Hefl9zwBcOMJkPkO3NmkU94b5WmddA8rlmwlWoDFYBJ8RhGx0P7JzTuivhyQ?=
 =?us-ascii?Q?aGsmF2Pk8MoqNh6XC9rtYVjqOvgZ1QLYymxAGRdLMDnXPEPWgbKFC8kxokqJ?=
 =?us-ascii?Q?s/bZ/33dxlzjJ5ceKfIjsAqtBbsboBHvZ+qxkJxRe6u/flaD90jNpIBw2WY4?=
 =?us-ascii?Q?9skeaFA7m2EjKeOMMcml9bDH32IxWxhrZztMo6z++b1zePjMopgxnAv8Y+U/?=
 =?us-ascii?Q?hiIwyq55Km2OmkBx7tXoAZJjc3FPhRe0hQl4wNBPSg1oc5j+Y/KNBXaMl9HP?=
 =?us-ascii?Q?GhghPxgqJdx7KbZkcwDcPdKNh2Ul3/IDsgJLrhDK3VrfbNKN6cP/V4DOaFmQ?=
 =?us-ascii?Q?8AcNul33mF2NxQv0zXeHDb0cRK+KK1dn3+iKeNKMoY1XHgY0E9m+eORMNQxE?=
 =?us-ascii?Q?QTkVRVwcDDn2kW+6htVSZDVofS4lLRZuigGiYJyHOZduuI4oegO9vEU/sS4S?=
 =?us-ascii?Q?Ueep2jLfPGRQ1+ZZOZzHb2bdxZSAJXmLNakXaV+nQRYf2SqSDf3mvs5+k8CA?=
 =?us-ascii?Q?hia5KKLS1aicyrcySsTh5AdVuq0lDzP/IgYyw939D2sI48eC2cMWVa7yG4gs?=
 =?us-ascii?Q?TC8XKmchVbk8fz2hJHgng8iEhbNq5Nobz+4zvjwKodpJ2hqZ7xBmzxCfJBlX?=
 =?us-ascii?Q?fq0h3P+C0El4VodDYy73DB+gtTmTmHRRwCsZFzUwa66kjgICF+r/MEnEytxu?=
 =?us-ascii?Q?wvB/Y58Ls4R1jHnAd8l6jZA40k+xAUkWD8H/PNHoB/jxj6PdwFFRBTpI12yt?=
 =?us-ascii?Q?gIBo5Dqux11bGqwnNaiZJ0YU84mBpbtEnas7vTc0eM1A+EHTVOwpTxLrAW6p?=
 =?us-ascii?Q?Nw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ad6e104-2d77-40b2-f068-08da978672ce
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 01:54:53.8624
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jl02DApuEmgtEqCpltUa1cjXQ1pWy3Tk/LiEkhifwzhmhGvaIIoERZHRWn+DIk2ayg3bpNyF8XJJGrZvdK1OQdjODw+1nwyEEwrgfo9e0Z0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6013
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-15_10,2022-09-14_04,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 mlxscore=0
 adultscore=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2209160012
X-Proofpoint-GUID: BoMFt60prbkgWwYckY5ych4yNYf-BxED
X-Proofpoint-ORIG-GUID: BoMFt60prbkgWwYckY5ych4yNYf-BxED
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Seo,

> +static inline void ufshcd_vops_check_int_error(struct ufs_hba *hba,
> +					       bool *queue_eh_work)
> +{
> +	if (hba->vops & hba->vops->check_int_error)

Uhm?

> +		hba->vops->check_int_error(hba, queue_eh_work);
> +}
> +

-- 
Martin K. Petersen	Oracle Linux Engineering