Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Hoyoung SEO" <hy50.seo@samsung.com>
To:     "'Martin K. Petersen'" <martin.petersen@oracle.com>
Cc:     <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
        <jejb@linux.ibm.com>, <beanhuo@micron.com>, <bvanassche@acm.org>,
        <bhoon95.kim@samsung.com>, <kwmad.kim@samsung.com>
In-Reply-To: <yq1czbw2ihu.fsf@ca-mkp.ca.oracle.com>
Subject: RE: [PATCH v2] scsi: ufs: add a variant operation in struct
 ufs_hba_variant_ops
Date:   Fri, 16 Sep 2022 10:59:38 +0900
Message-ID: <18d501d8c96f$fa5fba00$ef1f2e00$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: 7bit
Thread-Index: AQH6/1cAF6qSg90m2bD6JVyUXcFHdQLDRczJAaloHG6teXuWMA==
Content-Language: ko
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20220913075407epcas2p1075426e0ef45b6969e50823d59c374d3@epcas2p1.samsung.com>
        <20220912193703.102267-1-hy50.seo@samsung.com>
        <yq1czbw2ihu.fsf@ca-mkp.ca.oracle.com>
Precedence: bulk


> -----Original Message-----
> From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
> Sent: Friday, September 16, 2022 10:55 AM
> To: SEO HOYOUNG
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org;
> alim.akhtar@samsung.com; avri.altman@wdc.com; jejb@linux.ibm.com;
> martin.petersen@oracle.com; beanhuo@micron.com; bvanassche@acm.org;
> bhoon95.kim@samsung.com; kwmad.kim@samsung.com
> Subject: Re: [PATCH v2] scsi: ufs: add a variant operation in struct
> ufs_hba_variant_ops
> 
> 
> Seo,
> 
> > +static inline void ufshcd_vops_check_int_error(struct ufs_hba *hba,
> > +					       bool *queue_eh_work)
> > +{
> > +	if (hba->vops & hba->vops->check_int_error)
> 
> Uhm?
> 
I will fixed it.
Thanks.

> > +		hba->vops->check_int_error(hba, queue_eh_work); }
> > +
> 
> --
> Martin K. Petersen	Oracle Linux Engineering