From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Nigel Cunningham <nigel@nigel.suspend2.net>
Subject: Re: [PATCH] Optional Beeping During Resume From Suspend To Ram.
Date: Tue, 19 Jun 2007 23:33:08 +0200
User-Agent: KMail/1.9.5
Cc: LKML <linux-kernel@vger.kernel.org>, pavel@ucw.cz,
       Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@suse.de>
References: <200706192118.23706.nigel@nigel.suspend2.net>
In-Reply-To: <200706192118.23706.nigel@nigel.suspend2.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200706192333.09183.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1379
Lines: 40

Hi Nigel,

On Tuesday, 19 June 2007 13:18, Nigel Cunningham wrote:
> Hi all
> 
> Here's what I have after today's work.
> 
> I haven't yet been able to test on x86, but can confirm that it works okay on
> x86_64. I'm currently working towards testing it on my old Omnibook. My P4
> desktop won't resume from suspend to ram at all, and hasn't produced any
> beeps.   
> 
> I needed to move the BEEP invocation to after the data segment is reloaded,
> so that the test could access the variable. That was pretty tricky to find -
> no oops or anything bad prior, it just didn't beep when expected.  
> 
> A couple of notes:
> 
> - I'd like to put the BEEP macro somewhere that can be shared by x86 32 and
> 64. If that's a good idea, any suggestions on where? Nothing occurs to me
> straight off.  

I don't know either.  I think Andi is the right person to ask (CC added).

> - I've just switched from Evo to Kmail. Please let me know if there's any
> mangling of the patch. 

The patch looks good to me.  I'll try to run it on an i386 tomorrow.

Greetings,
Rafael 


-- 
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/