Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     skashyap@marvell.com, Letu Ren <fantasquex@gmail.com>,
        jejb@linux.ibm.com, jhasan@marvell.com
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-kernel@vger.kernel.org, Wende Tan <twd2.me@gmail.com>,
        Zheyu Ma <zheyuma97@gmail.com>, linux-scsi@vger.kernel.org,
        GR-QLogic-Storage-Upstream@marvell.com
Subject: Re: [PATCH] scsi: qedf: Fix a UAF bug in __qedf_probe
Date:   Thu, 15 Sep 2022 23:01:55 -0400
Message-Id: <166329729477.12731.17768877694121234425.b4-ty@oracle.com>
In-Reply-To: <20211112120641.16073-1-fantasquex@gmail.com>
References: <20211112120641.16073-1-fantasquex@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 12 Nov 2021 20:06:41 +0800, Letu Ren wrote:

> In __qedf_probe, if `qedf->cdev` is NULL which means
> qed_ops->common->probe() failed, then the program will goto label err1,
> scsi_host_put() will free `lport->host` pointer. Because the memory `qedf`
> points to is allocated by libfc_host_alloc(), it will be freed by
> scsi_host_put(). However, the if statement below label err0 only checks
> whether qedf is NULL but doesn't check whether the memory has been freed.
> So a UAF bug occurred.
> 
> [...]

Applied to 6.0/scsi-fixes, thanks!

[1/1] scsi: qedf: Fix a UAF bug in __qedf_probe
      https://git.kernel.org/mkp/scsi/c/fbfe96869b78

-- 
Martin K. Petersen	Oracle Linux Engineering