Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220815025006.48167-1-mie@igel.co.jp> <20220815184142.GA1960338@bhelgaas>
In-Reply-To: <20220815184142.GA1960338@bhelgaas>
From:   Shunsuke Mie <mie@igel.co.jp>
Date:   Fri, 16 Sep 2022 12:13:00 +0900
Message-ID: <CANXvt5pYHDx=eneaRxZ0K=psQXsaLyp5dGA7OgoKYJaJ543mqQ@mail.gmail.com>
Subject: Re: [PATCH] PCI: endpoint: fix Kconfig indent style
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     Jon Mason <jdmason@kudzu.us>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Frank Li <Frank.Li@nxp.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Ren Zhijie <renzhijie2@huawei.com>, linux-pci@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Lorenzo,

2022=E5=B9=B48=E6=9C=8816=E6=97=A5(=E7=81=AB) 3:41 Bjorn Helgaas <helgaas@k=
ernel.org>:
>
> On Mon, Aug 15, 2022 at 11:50:06AM +0900, Shunsuke Mie wrote:
> > Change to follow the Kconfig style guide. This patch fixes to use tab
> > rather than space to indent, while help text is indented an additional
> > two spaces.
> >
> > Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC an=
d EP")
> > Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
>
> Thanks for doing this.  In the future make the subject line match the
> history, e.g.,
>
>   $ git log --oneline drivers/pci/endpoint/functions/Kconfig
>   556a2c7dca33 ("PCI: endpoint: Fix Kconfig dependency")
>   e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
>   8b821cf76150 ("PCI: endpoint: Add EP function driver to provide NTB fun=
ctionality")
>   98dbf5af4fdd ("PCI: endpoint: Select CRC32 to fix test build error")
>   349e7a85b25f ("PCI: endpoint: functions: Add an EP function to test PCI=
")
>
> Note that these are all capitalized ("Fix Kconfig indent style").
>
> Lorenzo will likely fix this up when applying, so no need to repost
> for this.
This is a gentle ping.
>
> > ---
> >  drivers/pci/endpoint/functions/Kconfig | 18 +++++++++---------
> >  1 file changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/pci/endpoint/functions/Kconfig b/drivers/pci/endpo=
int/functions/Kconfig
> > index 295a033ee9a2..9fd560886871 100644
> > --- a/drivers/pci/endpoint/functions/Kconfig
> > +++ b/drivers/pci/endpoint/functions/Kconfig
> > @@ -27,13 +27,13 @@ config PCI_EPF_NTB
> >         If in doubt, say "N" to disable Endpoint NTB driver.
> >
> >  config PCI_EPF_VNTB
> > -        tristate "PCI Endpoint NTB driver"
> > -        depends on PCI_ENDPOINT
> > -        depends on NTB
> > -        select CONFIGFS_FS
> > -        help
> > -          Select this configuration option to enable the Non-Transpare=
nt
> > -          Bridge (NTB) driver for PCIe Endpoint. NTB driver implements=
 NTB
> > -          between PCI Root Port and PCIe Endpoint.
> > +     tristate "PCI Endpoint NTB driver"
> > +     depends on PCI_ENDPOINT
> > +     depends on NTB
> > +     select CONFIGFS_FS
> > +     help
> > +       Select this configuration option to enable the Non-Transparent
> > +       Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NT=
B
> > +       between PCI Root Port and PCIe Endpoint.
> >
> > -          If in doubt, say "N" to disable Endpoint NTB driver.
> > +       If in doubt, say "N" to disable Endpoint NTB driver.
> > --
> > 2.17.1
> >
thanks,
Shunsuke