Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756814AbXFSVtO (ORCPT ); Tue, 19 Jun 2007 17:49:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753399AbXFSVtA (ORCPT ); Tue, 19 Jun 2007 17:49:00 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:44376 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752744AbXFSVs7 (ORCPT ); Tue, 19 Jun 2007 17:48:59 -0400 Date: Tue, 19 Jun 2007 14:48:44 -0700 (PDT) From: Linus Torvalds To: Mariusz Kozlowski cc: Linux Kernel Mailing List , Alan Cox Subject: Re: And now for something _totally_ different: Linux v2.6.22-rc5 In-Reply-To: <200706192337.49505.m.kozlowski@tuxland.pl> Message-ID: References: <200706192337.49505.m.kozlowski@tuxland.pl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1317 Lines: 39 On Tue, 19 Jun 2007, Mariusz Kozlowski wrote: > > MAINTAINERS says riscom8 is orphaned so not sure > if anybody cares. Spotted this when playing with modprobe > walking /lib/modules/`uname -r`/kernel in a loop ;) Oh wow. I wonder why it does that. The code literally does: save_flags(flags); cli(); tty_unregister_driver(riscom_driver); put_tty_driver(riscom_driver); restore_flags(flags); and I don't see the point. (And that's what then causes the warning: tty_unregister_driver will eventually get a mutex, but the caller had disabled hardware interrupts.. I see absolutely *zero* reason for that whole save_flags/cli/restore_flags dance at all, so I think the right thing to do is to just remove it. I'm Cc'ing Alan, in case he cares. Mariusz, if you actually *use* the dang thing, and really care, you can send me a tested patch. I can pretty much guarantee that removing those irq games won't make things any worse, but no way am I going to just remove it on my own without any users or any testing. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/