Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Sep 2022 09:56:47 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Russ Weight <russell.h.weight@intel.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org, Xu Yilun <yilun.xu@intel.com>,
        Tom Rix <trix@redhat.com>
Subject: drivers/fpga/intel-m10-bmc-sec-update.c:103 flash_count_show() warn:
 possible memory leak of 'flash_buf'
Message-ID: <202209160713.HoIRfGTB-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gXLuEaIWFQUICkwl7RvyIuq59cwYftPVnrCQwpxCKRvGoVbjYhkt5CV71PGO?=
 =?us-ascii?Q?VPJgLzWNUzBy8hUQVehCVR91RIUjZvyfV8IVdv4EkSwecUIjGKVOiYFWKbsm?=
 =?us-ascii?Q?mse9PiOjj2zdtjoY8ElUFwdmsE0RM8bBILodf1sqA7zOfaCcfzs8hHIDuRoz?=
 =?us-ascii?Q?EkgkXYM1lJ6j8rJSLxyaJThhBidq92J9EYc82YnZ39NOZPtylNwpx3sP3G4q?=
 =?us-ascii?Q?KuaeqMkx2sQTLJQKsi2AF/V+Kqm6dO7CVcLHNjhd3RJoDBSi3/KK0OgFbtu8?=
 =?us-ascii?Q?aWFoCnEYk1zJJ1zRxezRsGfx/5kEy2/PB6ASEmv3gTFSwruL6M3MacnzOgrm?=
 =?us-ascii?Q?qvz4IGfODShrhGs4ptzes6LAdXQj8c1Ldo181b6J1+s+t1xIoOx4hAAGxViH?=
 =?us-ascii?Q?ecojbk0rfdGidB5u0BXWaktQ3GwOeVZpZ161Qewr3Z41+Yxl2n2+ycbW/n4t?=
 =?us-ascii?Q?KlLx8poc72hvXaPngyrN7qBReUX5Mtn0PrExVfgFIyQSPzaULEsqoVXkXxxZ?=
 =?us-ascii?Q?KUB6X0MV9SW5S+0yxuX57Hm3RFoqcwNsFV2Mp3usyiTy67LOPpQbc1nL93Fb?=
 =?us-ascii?Q?5CPWZSnbEFzbi6/KUr4V94ws/uwHKJlQfEPx0kyIqHY/eOo0ZU6xphSWxSbg?=
 =?us-ascii?Q?DeqVqzH0lBpiTGBNXBTSGpGpHp7+NMMuCJkggVuFgpaEswi6B9m9tlhRyTaJ?=
 =?us-ascii?Q?qMFTq7gWd8hwTXLE3u+JDk4Omr5G4NXkkBdAYquBi2MiaWZaLFS0qwlDgtxR?=
 =?us-ascii?Q?YzApBvAfReig07hor1Sc5z1qcav2rkya6jhIWXCFzawlV/wRrK5ArIlas8C/?=
 =?us-ascii?Q?dAJepZodOKAswD0rdb0SotR+oAsNmpF4dhQqaquebDCdc3awJxEyyPTv8wQy?=
 =?us-ascii?Q?C02hMN2CIoreGQIikfl1zYLNmJNbdsmtI1k57hJjBlNBVgvpdPiqCSgzYtkq?=
 =?us-ascii?Q?+jgGi37fuoZuEToIH1bjn+EarVYq4iLwh8CVW3dXyVwO0FEQurcoGGQbIo53?=
 =?us-ascii?Q?xrqtXxPDKv4Hfh2LKXq28xxkTUF2+Me+EVIcJMPC88H/FeJvLIAS0hoT3fVE?=
 =?us-ascii?Q?yAhtJjIoc/Xhx4/JjNQ5mYHecWPbkG3073BMtmRGuhIGRIcx7KAbWFb8O52D?=
 =?us-ascii?Q?6z0CLy4FjF+e+ukQvk99maeV/Lq7HvP1Hi3Sf8tx307NfKuGBx3jdPqNykey?=
 =?us-ascii?Q?wmc1NJ5nJo4vfMWqVKuvpPelpHXgk9zlRebShrJ3tF0idjZYYm+/ZClsUJk8?=
 =?us-ascii?Q?/EdxlYSbZbHG3GnYZ506HFppxe09UfvKUcFR6S755VR/sWweQ4KLkXUrL/ex?=
 =?us-ascii?Q?a5NUvg+EQEPpUDX4N4NaCy9ArdG2Mp52ugZULh69/29vR/KqkNLX05ls8tAd?=
 =?us-ascii?Q?WZIfI4kNojjAoq77xWz2kkKSCNzkUpYsPIg19BTJMa+xeNNoeNXBgLJ6S5Je?=
 =?us-ascii?Q?++iiyhg+F7i3JS1MoVZVCRo9NYZ2X9XNpSFiQawCpFyoNyIQeTwb450ueWDD?=
 =?us-ascii?Q?0mXvD/qH+F8rYY7nKF7hI1+cfz4nQojyFURUGqn/LPN+XGNpmIhFUTucoiQQ?=
 =?us-ascii?Q?u8Dycrsb6RSPwnoYzexJGNqdcMNWnj7RRCHhhC07lqyllOq8GmAbf49r94iT?=
 =?us-ascii?Q?PA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 626b9171-2870-478f-b71c-08da97b0abe1
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 06:57:08.1331
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JdR1fRYk932AcM1sgyDxlfo1D0ki0nPSJtJAO8n6deiqTQPnVGqonF8veNwAwg1D4X006SNyjxtdpl0DAd7ylzTMbSMjIS5rkVlVbCB0sO4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4952
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-16_02,2022-09-14_04,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 malwarescore=0 mlxscore=0 spamscore=0 suspectscore=0 bulkscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2209160050
X-Proofpoint-GUID: eLlGsWmn7l_rTQsVWSyDqVo5WDgpVNgE
X-Proofpoint-ORIG-GUID: eLlGsWmn7l_rTQsVWSyDqVo5WDgpVNgE
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3245cb65fd91cd514801bf91f5a3066d562f0ac4
commit: 154afa5c31cd2de5e6c2c4f35eee390993ee345a fpga: m10bmc-sec: expose max10 flash update count
config: m68k-randconfig-m031-20220914 (https://download.01.org/0day-ci/archive/20220916/202209160713.HoIRfGTB-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/fpga/intel-m10-bmc-sec-update.c:103 flash_count_show() warn: possible memory leak of 'flash_buf'

vim +/flash_buf +103 drivers/fpga/intel-m10-bmc-sec-update.c

154afa5c31cd2d Russ Weight 2022-06-06   83  static ssize_t flash_count_show(struct device *dev,
154afa5c31cd2d Russ Weight 2022-06-06   84  				struct device_attribute *attr, char *buf)
154afa5c31cd2d Russ Weight 2022-06-06   85  {
154afa5c31cd2d Russ Weight 2022-06-06   86  	struct m10bmc_sec *sec = dev_get_drvdata(dev);
154afa5c31cd2d Russ Weight 2022-06-06   87  	unsigned int stride, num_bits;
154afa5c31cd2d Russ Weight 2022-06-06   88  	u8 *flash_buf;
154afa5c31cd2d Russ Weight 2022-06-06   89  	int cnt, ret;
154afa5c31cd2d Russ Weight 2022-06-06   90  
154afa5c31cd2d Russ Weight 2022-06-06   91  	stride = regmap_get_reg_stride(sec->m10bmc->regmap);
154afa5c31cd2d Russ Weight 2022-06-06   92  	num_bits = FLASH_COUNT_SIZE * 8;
154afa5c31cd2d Russ Weight 2022-06-06   93  
154afa5c31cd2d Russ Weight 2022-06-06   94  	flash_buf = kmalloc(FLASH_COUNT_SIZE, GFP_KERNEL);
154afa5c31cd2d Russ Weight 2022-06-06   95  	if (!flash_buf)
154afa5c31cd2d Russ Weight 2022-06-06   96  		return -ENOMEM;
154afa5c31cd2d Russ Weight 2022-06-06   97  
154afa5c31cd2d Russ Weight 2022-06-06   98  	if (FLASH_COUNT_SIZE % stride) {
154afa5c31cd2d Russ Weight 2022-06-06   99  		dev_err(sec->dev,
154afa5c31cd2d Russ Weight 2022-06-06  100  			"FLASH_COUNT_SIZE (0x%x) not aligned to stride (0x%x)\n",
154afa5c31cd2d Russ Weight 2022-06-06  101  			FLASH_COUNT_SIZE, stride);
154afa5c31cd2d Russ Weight 2022-06-06  102  		WARN_ON_ONCE(1);

do this check before the kmalloc()?

154afa5c31cd2d Russ Weight 2022-06-06 @103  		return -EINVAL;
154afa5c31cd2d Russ Weight 2022-06-06  104  	}
154afa5c31cd2d Russ Weight 2022-06-06  105  
154afa5c31cd2d Russ Weight 2022-06-06  106  	ret = regmap_bulk_read(sec->m10bmc->regmap, STAGING_FLASH_COUNT,
154afa5c31cd2d Russ Weight 2022-06-06  107  			       flash_buf, FLASH_COUNT_SIZE / stride);
154afa5c31cd2d Russ Weight 2022-06-06  108  	if (ret) {
154afa5c31cd2d Russ Weight 2022-06-06  109  		dev_err(sec->dev,
154afa5c31cd2d Russ Weight 2022-06-06  110  			"failed to read flash count: %x cnt %x: %d\n",
154afa5c31cd2d Russ Weight 2022-06-06  111  			STAGING_FLASH_COUNT, FLASH_COUNT_SIZE / stride, ret);
154afa5c31cd2d Russ Weight 2022-06-06  112  		goto exit_free;
154afa5c31cd2d Russ Weight 2022-06-06  113  	}
154afa5c31cd2d Russ Weight 2022-06-06  114  	cnt = num_bits - bitmap_weight((unsigned long *)flash_buf, num_bits);
154afa5c31cd2d Russ Weight 2022-06-06  115  
154afa5c31cd2d Russ Weight 2022-06-06  116  exit_free:
154afa5c31cd2d Russ Weight 2022-06-06  117  	kfree(flash_buf);
154afa5c31cd2d Russ Weight 2022-06-06  118  
154afa5c31cd2d Russ Weight 2022-06-06  119  	return ret ? : sysfs_emit(buf, "%u\n", cnt);
154afa5c31cd2d Russ Weight 2022-06-06  120  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp