Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1837676rwn; Fri, 16 Sep 2022 01:18:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4ImF8sS58Mn2gdKz/Oy1221M1j07X+OhHRhcogN7v0QDrtrf6t/f5UpQnm4nQAZ4gae9la X-Received: by 2002:a05:6402:524a:b0:450:bab6:cd5f with SMTP id t10-20020a056402524a00b00450bab6cd5fmr2970671edd.233.1663316308520; Fri, 16 Sep 2022 01:18:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663316308; cv=none; d=google.com; s=arc-20160816; b=iqvjxWlNocHp8LjjDl+SFiyaFAwFmwAX5XnJB7SAP+BQlHu3dXOwKu2/YFIh5Fwbzc TInen14ytfacplUhflFKGpt4TI6+QA+iHF6B78JWIGoIj56khVgRGHgwjHCIW+onoacJ 54C3dE0L1CwV56SjR9EdmtJwwuhycMR4dZv0MWGaYv2ZGzinjb947hhfxL+cYs7dd99r 9t5QvFjIE3krgTpZOgsAPy987Cr7d5HK1K/ormlSEmsl/8XmnDkOpxD1Bw6i/SPTcx+K IEk/uuETPXbkGsHPctAI5FWFTPj5oliTDEww/Zb1yW1HFmW4wlcHgQgo36gw0CgkfsGB Onfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HAXwkx/uYexRSiAooA8OWBY5Zfggqz9KkW8MSeKRhAY=; b=xHuvydC1WsEYe/OVq79pT6pf3AsnafD34GiVtUrCkrIpPFBMkm9J/aXgUtBC7faaGI 5iu0xFfehrD73SudprUZC9ANJxBODQSlWHGAMD6LCjX5zR8iH00/QleTqz7ldQTsXtp4 +DtagvHx2ruU0PsZHsPeHT2IEJqARC9NUOhPSF7gqc/4dKUuo+WARt5nL8q/DtLL7Gvx JaNwYmViHniO9sJsewAwPzh+K1VYNLPmpb4PbRW5jyNWCzEuBd2YYZ5aSjLykbQThPZe sjeXhZVR/W6MEeE4feBcynRlcAoEbr3HVB1TFEZyBebLjbFuQ9fFHqkqsqyu96fWvgKv /RVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LgoHcR42; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c23-20020a50f617000000b00450ba83d4c2si1677254edn.344.2022.09.16.01.18.03; Fri, 16 Sep 2022 01:18:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LgoHcR42; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229894AbiIPILb (ORCPT + 99 others); Fri, 16 Sep 2022 04:11:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229929AbiIPILa (ORCPT ); Fri, 16 Sep 2022 04:11:30 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 758744F675 for ; Fri, 16 Sep 2022 01:11:29 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id c24so19647147pgg.11 for ; Fri, 16 Sep 2022 01:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=HAXwkx/uYexRSiAooA8OWBY5Zfggqz9KkW8MSeKRhAY=; b=LgoHcR422J6Q1Fa4t3wbWbINjlk1+7//FJ8ydCb6FHgcS//+MLNGBgFMQw6hME1VyK EDu+pUfvqGbH78wfaQC8NGh5JxGTecaUd5eqdEUazwaQZkz5SEV5oWtm5NKkEgWExboe tvPlqRN4RRX6copZ9lcEwJnhVUZ8ou4RXY33Ax0TZEQe8Ab3/qmcmoIr5egNE3tJ8TMK P3s0gYq1qRLGQ59ixIQwNlLJXq6Y+WP+5UlPhJhFk0vPRCF/X0QfV/1rP4KBgityKpc/ q4ijbkkVvkdYAPnXnOwc1W8kJBPzTyK5IY81poIf18W8iFCSKg/4EB/orv0FvDflqyWq 1jvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=HAXwkx/uYexRSiAooA8OWBY5Zfggqz9KkW8MSeKRhAY=; b=kVf8b1Eje9ec5Bu+6H9T/jgL284CR3h0UTRrjEAPNK+dqVw97gx29ra4CKOOx2benf VmIagIZ/zWTewVw86Omf9H0JAQWEUjzANbnx9APxmlID1oYDnByTewsiInkKMQDGym+b TJYXC51qzLH4Z/d/hMTc/DzDT3KwiCeX0RrJWShm55b5rXU+eEKu0CXXg00wXUndQYxn KUJrFTeK1Cde7HEbslZ0r7jhzY78KaGCKD06LZfAKfl1II2ZyUBSwo3c7j/EhrTDLtQ3 GQ1P3HYXVWGxVa15VwfmXTiE+UvI/q6oecWI3a9on8pMM9kPEpnegvpAyQDwnp8+WAks IIBw== X-Gm-Message-State: ACrzQf11KCRF4gv/dKDqxAbAc13iKBq6SSlzi1TXMTrkR0oQyAYQHN4H Th5CxUvaAuSVpCazwheo94o= X-Received: by 2002:a05:6a00:a83:b0:54a:e52e:9472 with SMTP id b3-20020a056a000a8300b0054ae52e9472mr1975111pfl.50.1663315888960; Fri, 16 Sep 2022 01:11:28 -0700 (PDT) Received: from ubuntu ([175.124.254.119]) by smtp.gmail.com with ESMTPSA id y8-20020aa79428000000b0053fa7ccf7e5sm13911747pfo.25.2022.09.16.01.11.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 01:11:28 -0700 (PDT) Date: Fri, 16 Sep 2022 01:11:24 -0700 From: Hyunwoo Kim To: Arnd Bergmann Cc: Lubomir Rintel , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, imv4bel@gmail.com Subject: Re: [PATCH] char: pcmcia: scr24x_cs: Fix use-after-free in scr24x_fops Message-ID: <20220916081124.GA189795@ubuntu> References: <20220916050006.GA188273@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2022 at 08:59:44AM +0200, Arnd Bergmann wrote: > This appears to introduce a new use-after-free, when the kref_put() > frees the 'dev' structure and you unlock the mutex in that structure > afterwards. yes. Every patch I've submitted has this issue. I'll replace the mutex with a global variable and submit a v2 patch that fixes other issues.