Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC:     Dan Carpenter <dan.carpenter@oracle.com>,
        "kbuild@lists.01.org" <kbuild@lists.01.org>,
        "Hennerich, Michael" <Michael.Hennerich@analog.com>,
        "lkp@intel.com" <lkp@intel.com>,
        "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [jic23-iio:testing 149/150] drivers/iio/dac/ad5593r.c:87
 ad5593r_gpio_read() error: uninitialized symbol 'val'.
Thread-Topic: [jic23-iio:testing 149/150] drivers/iio/dac/ad5593r.c:87
 ad5593r_gpio_read() error: uninitialized symbol 'val'.
Thread-Index: AQHYyZllGwG13peD5U2AjjCO3xWkAq3hoyOggAAZHQCAAAU5UA==
Date:   Fri, 16 Sep 2022 08:58:40 +0000
Message-ID: <SJ0PR03MB677872E614E229D0A3618CAC99489@SJ0PR03MB6778.namprd03.prod.outlook.com>
References: <202209160614.IE7ciPMN-lkp@intel.com>
        <SJ0PR03MB6778F73D1F3C08012C6B277299489@SJ0PR03MB6778.namprd03.prod.outlook.com>
 <20220916093842.0000535c@huawei.com>
In-Reply-To: <20220916093842.0000535c@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?HO7xKF2c7+5xHJxGLa3s1kdl+xQT5DKBI7eb8H5J4DrGJJLLhmP9uFwgPy?=
 =?iso-8859-1?Q?6adaK2yhvKOHHoFQjbw1pWyaZhhF6G8bVjoy5cPyxoUMADcIR2w+I8ltR1?=
 =?iso-8859-1?Q?pYR+eo33QB/3wa8p1mDW6K7bw0f4BiybvwQsZXJvjUOonp72ferTNY2ELo?=
 =?iso-8859-1?Q?3tHj1YU3aPTWyAyKzF6fHUvx3arVuvBUlYlJzbvYbSezh/hB1GTDeK5/po?=
 =?iso-8859-1?Q?n3YfiaaDbnipqvMqeQF1/5rNp7Oa8+a+sXrFCR6+mx9HOz4uDh1JkNSKnT?=
 =?iso-8859-1?Q?oOALKFdmRF2y+t+ffn113pjy65jtsaOwfRaICbCPXTa/paH9GuOky3lEUX?=
 =?iso-8859-1?Q?yl/FEigJSAnZb7zGj67ZZykk2mVck9wXqzgZc8DGdDByFtahXd99PZs57F?=
 =?iso-8859-1?Q?jZrTwKu626nlE8p9ZlppbwwdjnyrMviEYwpPE3u313N206l22rv8ITOP0L?=
 =?iso-8859-1?Q?kid+Rb86sbr0yhbhUGHDncwxYZ3hWL3xLSzhP2X3iC+OT+lt3/TBV9nvFL?=
 =?iso-8859-1?Q?bj9OfEvGTy+wL/k6rCGU6meO21HQpT8dcTwCUk84zyRicowCkCLW6j/a20?=
 =?iso-8859-1?Q?mS1l4Znw7Bvufx4T9q1yudo8FVuqGVXOK8KDlX3hPdUm4iJOxTYrfjfFGa?=
 =?iso-8859-1?Q?9sOvUDslxgQXL6pmqCMKqzhK/kA/hJdjKu65cArT8de2FHMTmMosY4kUDg?=
 =?iso-8859-1?Q?3DoG4sg51e8ST5y4O3Dau5YsHThr1Jvbcj84qapqIZS0V/WppMYdTLo6vg?=
 =?iso-8859-1?Q?YYjl4HETWTiOj2iGE2EWIdqXlPAWux61RhJEUIhT7stktvPvKH57KJoy5w?=
 =?iso-8859-1?Q?ZxPTW7rmW9XbGG30Uw+JcjqWuicU7BhWs/yQXjwXkZzLqiJSn0OOVdPjzQ?=
 =?iso-8859-1?Q?mNcBLJtO9wTkbuWBRbmr1ip+EgwhpssFODDNf0Tmhv3Zs6VaPnUGREtlHC?=
 =?iso-8859-1?Q?g87pYDd9iGpBeoT1S3C6AqMvI6BH/cPYirrk46J6LvKB8Hul/2ADOPJpRh?=
 =?iso-8859-1?Q?pv1AzNsAiqdjt45iVw09hoWtf5o/89D3uFt4YbSF2mMcQjREaCXKgOWtKS?=
 =?iso-8859-1?Q?BxPUwZ9FFYOXQ4nsY6HW8ECw2LjEEmYKEUXe+Ub8gYhWL36pXYLGXREOBO?=
 =?iso-8859-1?Q?VMcHPe3AupdTbd8HhoOo2Wb6Wwyn2BIb8ZnxV9J2Y303l0hwypRxdc20Sv?=
 =?iso-8859-1?Q?/GKA7mD/mu7iOj3nI37GytujmmrvInJ6hqysicVATJOtvsKYOxJvhFe8nA?=
 =?iso-8859-1?Q?yRYhb47Ac3ILq/p1bO4YYqs/IsiTF7VVN5E6+uddUseRdZiak5Hx9MuJJ1?=
 =?iso-8859-1?Q?R0BwPkcgzG2fQGIQ9IBUXwfygLVv6twbZqeKVy0iOwL68cWQnqb1zAJ4Ws?=
 =?iso-8859-1?Q?LIx4BtFgPkSAficZIfVBTD74X6YFtDcm1O7esO/MetyvmJlzPZu9USp8G0?=
 =?iso-8859-1?Q?GABzEnnjlxtJiAkHYuzlmCJ+f7BeiiCSimH7IcuIthxo03eRN+7wymJAgJ?=
 =?iso-8859-1?Q?I42C7QS0Db/tDZygFrGI/HtuHEIcHhql4/M7DvsADB+P4wk3cckWyD6v/L?=
 =?iso-8859-1?Q?8jeLXE/Hq48D+8JGfPSpEa2siKcpY4IxvdnTo638yaDuUMTUp8S911uSYE?=
 =?iso-8859-1?Q?SSGqYkA2x0lGSwE6OTF88DZvSWx1cMlulw?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6778.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f23e095-14da-4741-da39-08da97c1a6d2
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2022 08:58:40.9352
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5r19fN+NdnbVyZQJIDAbWo8ZhweQ886Ws9zwRZZxAIv+kwU7W5WBNCGUuCXWwSBu6/o8aT2cZdZG1+N/U6sDww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6696
X-Proofpoint-ORIG-GUID: yFIGXM23Prh1a03mm81POSimvWM_O9dX
X-Proofpoint-GUID: 8gP8XHjbgpB8_fQRrO2X1b5kbzt_a9cz
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-16_04,2022-09-14_04,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0
 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 malwarescore=0
 adultscore=0 mlxlogscore=999 lowpriorityscore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2209160066
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Sent: Friday, September 16, 2022 10:39 AM
> To: Sa, Nuno <Nuno.Sa@analog.com>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>; kbuild@lists.01.org;
> Hennerich, Michael <Michael.Hennerich@analog.com>; lkp@intel.com;
> kbuild-all@lists.01.org; linux-kernel@vger.kernel.org
> Subject: Re: [jic23-iio:testing 149/150] drivers/iio/dac/ad5593r.c:87
> ad5593r_gpio_read() error: uninitialized symbol 'val'.
>=20
> [External]
>=20
> On Fri, 16 Sep 2022 07:11:54 +0000
> "Sa, Nuno" <Nuno.Sa@analog.com> wrote:
>=20
> > Hi Dan,
> >
> > > From: Dan Carpenter <dan.carpenter@oracle.com>
> > > Sent: Friday, September 16, 2022 8:56 AM
> > > To: kbuild@lists.01.org; Hennerich, Michael
> > > <Michael.Hennerich@analog.com>
> > > Cc: lkp@intel.com; kbuild-all@lists.01.org; linux-kernel@vger.kernel.=
org;
> > > Jonathan Cameron <Jonathan.Cameron@huawei.com>; Sa, Nuno
> > > <Nuno.Sa@analog.com>
> > > Subject: [jic23-iio:testing 149/150] drivers/iio/dac/ad5593r.c:87
> > > ad5593r_gpio_read() error: uninitialized symbol 'val'.
> > >
> > > [External]
> > >
> > > tree:
> > >
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/g
> > >
> it/jic23/iio.git__;!!A3Ni8CS0y2Y!94Jf_eIoy5zwbmsSRdWgugxbqkbgHFd0A88T
> > > z4SKRufGLX24YYSEzKlB13AXeYzsBWzd5HW-SqPpIzc8hvh-6w$   testing
> > > head:   62a6e699f4669b2c51f408273756f93b21c9f1a1
> > > commit: 53b6e3b2164c5807669fbf6b3df0e1494b4d03b8 [149/150] iio: dac:
> > > ad5593r: Fix i2c read protocol requirements
> > > config: x86_64-randconfig-m001
> > > compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
> > >
> > > If you fix the issue, kindly add following tag where applicable
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > >
> > > smatch warnings:
> > > drivers/iio/dac/ad5593r.c:87 ad5593r_gpio_read() error: uninitialized
> symbol
> > > 'val'.
> > >
> > > vim +/val +87 drivers/iio/dac/ad5593r.c
> > >
> > > 56ca9db862bf3d7 Paul Cercueil     2016-04-05  79  static int
> > > ad5593r_gpio_read(struct ad5592r_state *st, u8 *value)
> > > 56ca9db862bf3d7 Paul Cercueil     2016-04-05  80  {
> > > 56ca9db862bf3d7 Paul Cercueil     2016-04-05  81  	struct i2c_client =
*i2c =3D
> > > to_i2c_client(st->dev);
> > > 53b6e3b2164c580 Michael Hennerich 2022-09-13  82  	u16 val;
> > > 53b6e3b2164c580 Michael Hennerich 2022-09-13  83  	int ret;
> > > 56ca9db862bf3d7 Paul Cercueil     2016-04-05  84
> > > 53b6e3b2164c580 Michael Hennerich 2022-09-13  85  	ret =3D
> > > ad5593r_read_word(i2c, AD5593R_MODE_GPIO_READBACK, &val);
> > > 56ca9db862bf3d7 Paul Cercueil     2016-04-05  86
> > > 56ca9db862bf3d7 Paul Cercueil     2016-04-05 @87  	*value =3D (u8) va=
l;
> > >
> > >
> > > In the original code the error checking prevented reading uninitializ=
ed
> > > variables.  It's not really a problem, because ad5593r_read_word() ca=
n't
> > > actually fail but, you know?  Technically the checker is correct.
> >
> > Hmm, in theory, it can if one of the i2c functions (for some reason) re=
turn
> error.
> > Not sure how to handle this... Given this is still in the testing branc=
h should I
> > just re-spin another version of the series? Jonathan?
>=20
> Either a fix patch or a respin is fine as long as I haven't pushed it out=
 as togreg
> (once that happens I would almost always want a fix on top).
>=20
> Separate fix is slightly easier for me.
>=20

fix it is...

- Nuno S=E1