Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <08cd7add-b2a5-da3f-1d2c-efa0e7c80511@gmail.com>
Date:   Fri, 16 Sep 2022 18:02:48 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.2.2
Subject: Re: [PATCH] selftests: kvm: Fix a compile error in
 selftests/kvm/rseq_test.c
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     Sean Christopherson <seanjc@google.com>,
        Liam Merwick <liam.merwick@oracle.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Joerg Roedel <joro@8bytes.org>,
        Jinrong Liang <cloudliang@tencent.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220802071240.84626-1-cloudliang@tencent.com>
 <YxjAZOGF9uSE2+AT@google.com>
 <fdfb143a-45c4-aaff-aa95-d20c076ff555@oracle.com>
From:   JinrongLiang <ljr.kernel@gmail.com>
In-Reply-To: <fdfb143a-45c4-aaff-aa95-d20c076ff555@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2022/9/8 00:54, Liam Merwick wrote:
> On 07/09/2022 17:01, Sean Christopherson wrote:
>> On Tue, Aug 02, 2022, Jinrong Liang wrote:
>>> From: Jinrong Liang <cloudliang@tencent.com>
>>>
>>> The following warning appears when executing:
>>>     make -C tools/testing/selftests/kvm
>>>
>>> rseq_test.c: In function ‘main’:
>>> rseq_test.c:237:33: warning: implicit declaration of function 
>>> ‘gettid’; did you mean ‘getgid’? [-Wimplicit-function-declaration]
>>>            (void *)(unsigned long)gettid());
>>>                                   ^~~~~~
>>>                                   getgid
>>> /usr/bin/ld: /tmp/ccr5mMko.o: in function `main':
>>> ../kvm/tools/testing/selftests/kvm/rseq_test.c:237: undefined 
>>> reference to `gettid'
>>> collect2: error: ld returned 1 exit status
>>> make: *** [../lib.mk:173: 
>>> ../kvm/tools/testing/selftests/kvm/rseq_test] Error 1
>>>
>>> Use the more compatible syscall(SYS_gettid) instead of gettid() to 
>>> fix it.
>>> More subsequent reuse may cause it to be wrapped in a lib file.
>>>
>>> Signed-off-by: Jinrong Liang <cloudliang@tencent.com>
>>> ---
>>
>> Reviewed-by: Sean Christopherson <seanjc@google.com>
>>
> 
> Can a 'Cc: stable@vger.kernel.org' be added also as e923b0537d28 got 
> backported to v5.15.58
> 
> Reviewed-by: Liam Merwick <liam.merwick@oracle.com>
> 
> 
>>
>> Paolo, do you want to grab this for 6.0?  It doesn't look like we're 
>> going to have
>> a more elegant solution anytime soon...
> 
Ping?