Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fd7cf2d0-b115-a13b-7056-0b96fc14b618@linaro.org>
Date:   Fri, 16 Sep 2022 10:57:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] nvmem: u-boot-env: find Device Tree nodes for NVMEM cells
Content-Language: en-US
To:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
Cc:     Tom Rini <trini@konsulko.com>, Michael Walle <michael@walle.cc>,
        linux-arm-kernel@lists.infradead.org, u-boot@lists.denx.de,
        linux-kernel@vger.kernel.org,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
References: <20220915200629.10270-1-zajec5@gmail.com>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
In-Reply-To: <20220915200629.10270-1-zajec5@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 15/09/2022 21:06, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> DT binding allows specifying NVMEM cells as NVMEM device (provider)
> subnodes. Looks for such subnodes when building NVMEM cells.
> 
> This allows NVMEM consumers to use U-Boot environment variables.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Applied thanks,

--srini
> ---
>   drivers/nvmem/u-boot-env.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvmem/u-boot-env.c b/drivers/nvmem/u-boot-env.c
> index 9b9abfb8f187..d17a164ae705 100644
> --- a/drivers/nvmem/u-boot-env.c
> +++ b/drivers/nvmem/u-boot-env.c
> @@ -92,6 +92,7 @@ static int u_boot_env_add_cells(struct u_boot_env *priv, uint8_t *buf,
>   			return -ENOMEM;
>   		priv->cells[idx].offset = data_offset + value - data;
>   		priv->cells[idx].bytes = strlen(value);
> +		priv->cells[idx].np = of_get_child_by_name(dev->of_node, priv->cells[idx].name);
>   	}
>   
>   	if (WARN_ON(idx != priv->ncells))