Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Sep 2022 12:07:43 +0200
Message-ID: <874jx7vdhs.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Pshou <pshou@realtek.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Takashi Iwai" <tiwai@suse.de>,
        "Arava, Jairaj" <jairaj.arava@intel.com>,
        "Nujella, Sathyanarayana" <sathyanarayana.nujella@intel.com>,
        "Prabhu, Swarna" <swarna.prabhu@intel.com>,
        "Afzal, Naeem M" <naeem.m.afzal@intel.com>,
        Shui-Wen Hsu <swhsu4021@realtek.com>,
        "Perati, RK" <rk.perati@intel.com>,
        "Mandri, Padmashree" <padmashree.mandri@intel.com>,
        Kailang <kailang@realtek.com>
Subject: Re: Sarien/Dorset device: After system resumed from suspend, 3.5m jack is still shown as detected when unplugged during suspend 
In-Reply-To: <ee87941f7f654213924aa1bc79db32f7@realtek.com>
References: <ee87941f7f654213924aa1bc79db32f7@realtek.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 16 Sep 2022 07:34:38 +0200,
Pshou wrote:
> 
> 
> Hi Takashi Iwai:
> 
> Can you help me update this PATCH file?
> 
> Check if ignore unsol events duing system suspend/resume and NVIDIA chip in
> hda_codec_unsol_event().
> 
> Signed-off-by:PeiSen Hou<pshou@realtek.com>
> 
> Signed-off-by: Jairaj Arava <jairaj.arava@intel.com>
> 
> diff --git a/sound/pci/hda/hda_bind.c b/sound/pci/hda/hda_bind.c
> 
> index 1a868dd9dc4b..75560ff6eb83 100644
> 
> --- a/sound/pci/hda/hda_bind.c
> 
> +++ b/sound/pci/hda/hda_bind.c
> 
> @@ -50,7 +50,8 @@ static void hda_codec_unsol_event(struct hdac_device *dev,
> unsigned int ev)
> 
>        /* ignore unsol events during system suspend/resume */
> 
>       if (codec->core.dev.power.power_state.event != PM_EVENT_ON)
> 
> -               return;
> 
> +              if (codec->core.vendor_id == PCI_VENDOR_ID_NVIDIA)
> 
> +                      return;
> 
>        if (codec->patch_ops.unsol_event)
> 
>               codec->patch_ops.unsol_event(codec, ev);

Hmm, this doesn't look safe.  We also want to avoid the unsol event
handling during the PM state transition, too.  So, if any, this should
be allowed only at PM_EVENT_SUSPEND or PM_EVENT_HIBERNATE.

Also, checking the codec vendor ID here is no good way.  We may add a
new flag for the special behavior (either allowing the unsol handling
or prohibiting).

But, from your patch, I don't see any reason *why* this has to be
changed in that way.  Could you give more backgrounds?


thanks,

Takashi