Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1943215rwn; Fri, 16 Sep 2022 03:20:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6i/hcG5FK6OOUCKTRXY7KyFK7kW7uQ4dZDRyXHsaUnaMHELuTYiXpTSWLtIf3O2r2vOTKQ X-Received: by 2002:a17:902:e5cd:b0:176:ad01:ab47 with SMTP id u13-20020a170902e5cd00b00176ad01ab47mr4035020plf.133.1663323633947; Fri, 16 Sep 2022 03:20:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663323633; cv=none; d=google.com; s=arc-20160816; b=yFGStB2UBDpbk6NkOMJRSS1dBpShb3Vge54hznTMiZVzpxIEaS0OI0OM/lFhik2sWL 55V1dG6GdeUMVZSBzBydsHrB9QxV3Q1JtCFUchONuoEbAv0dNusYHGkKVA/hwyxMA3G7 WGKbHOVnXYSstsCmpJVOAddqoNsByFrf23A3D3RaDVGKZ4x5YGur8sJt75S7FCGWkaFn cctzTGJugwYYJwHDHAgpsB4/X+cAO7dSKkoncqBFDMY+0xHTp7mKoxAXcSlXFleHhg2p 0xicgIlOixbLEyhcfNuIOkO8dSrV1Xcv/3Dt8+PCFaXBalnRcxx31aLSMGdHSjXLAeNP lvzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7ROqvZ9z3HQ2BR8zZVVc1OV9/Uh8cnvQrsOXwkWxXDs=; b=xO3L156FOiKkIIr3cKyW2a2wnBOtcpzszZzchU28yu6nRdP4cvLKByWxDBrJhghcvS 1f0UIDwvU9gZO7OzjgWxRBu5BzIzYTHVMdcQZmOBQZ642Q6FdhKvc0f8hCT6QVtizbpl nLwiR9Swk2J/HAe3vcHfMHIpimN0aiAMzDzIvDM2Y5q3ml9Ysq3aDC+AcTvTBxiw7RkN KxW2i4AzZohfA3NqAJ8DLg424ekd1I8Abg9GUsM78iop7D+fty1t1xuFDXNW7O7hqI6F ES5zPyJYQZH4cJRN+LKzDFtPip1YNsbZ4UmY4tMp2d2hBp4DwTrxfg0wWA3mGgg91YZA FHmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qPVuK2t2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e3-20020a170902ef4300b00176cbe4c8e5si21849211plx.579.2022.09.16.03.20.21; Fri, 16 Sep 2022 03:20:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qPVuK2t2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231266AbiIPKKO (ORCPT + 99 others); Fri, 16 Sep 2022 06:10:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231226AbiIPKJe (ORCPT ); Fri, 16 Sep 2022 06:09:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61FD1AB189; Fri, 16 Sep 2022 03:08:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 12E68629EF; Fri, 16 Sep 2022 10:08:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 049B3C433D6; Fri, 16 Sep 2022 10:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663322905; bh=83Z+ftewRYZSS+0yDzkJlq/oMgWCS6t1P3oo5EZP2hw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qPVuK2t2d7Y8f0GwSSePPfED8VCb97Oy3vdnQ9yeTcU3heCkAqHU80Tstp4KK8IO0 1tkG4+Y7/PHqjNigTc7WHjpeiFCTZdlgWMWZzBzTXQjVnNwhXIJAeoala4q9kT6CS5 gkU3c4DF0wri97etNCryZZtd18++yA6z9PAvE3N0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Enguerrand de Ribaucourt , Andrew Lunn , Jakub Kicinski Subject: [PATCH 4.19 10/11] net: dp83822: disable rx error interrupt Date: Fri, 16 Sep 2022 12:08:06 +0200 Message-Id: <20220916100443.166239140@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220916100442.662955946@linuxfoundation.org> References: <20220916100442.662955946@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Enguerrand de Ribaucourt commit 0e597e2affb90d6ea48df6890d882924acf71e19 upstream. Some RX errors, notably when disconnecting the cable, increase the RCSR register. Once half full (0x7fff), an interrupt flood is generated. I measured ~3k/s interrupts even after the RX errors transfer was stopped. Since we don't read and clear the RCSR register, we should disable this interrupt. Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission") Signed-off-by: Enguerrand de Ribaucourt Reviewed-by: Andrew Lunn Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/phy/dp83822.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/phy/dp83822.c +++ b/drivers/net/phy/dp83822.c @@ -203,8 +203,7 @@ static int dp83822_config_intr(struct ph if (misr_status < 0) return misr_status; - misr_status |= (DP83822_RX_ERR_HF_INT_EN | - DP83822_ANEG_COMPLETE_INT_EN | + misr_status |= (DP83822_ANEG_COMPLETE_INT_EN | DP83822_DUP_MODE_CHANGE_INT_EN | DP83822_SPEED_CHANGED_INT_EN | DP83822_LINK_STAT_INT_EN |