Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1996529rwn; Fri, 16 Sep 2022 04:16:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7QCJa2LLA+1FUnPLvC6hMH0b6bJjsqXjZtqE34dFqQpZztcDLHczKIL/VpffiNe6PjYnIy X-Received: by 2002:a17:90b:2704:b0:1fd:aaa9:6d0b with SMTP id px4-20020a17090b270400b001fdaaa96d0bmr5015643pjb.128.1663326997450; Fri, 16 Sep 2022 04:16:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663326997; cv=none; d=google.com; s=arc-20160816; b=vpkn480p0TB/uNlNQfPT/PsPYjFxE4b1zs/ZesiE85O9jYc2ZrGXGPQhrrUafR3ziu AMnd5eWoZQdb0/VaydR1oI7f/1D6gPvb4LN6BdImROmmE98kQGBAfg78zecvnnmPhjKM dm9ITXkUe/b4lfgJhUUJxuay0eJMdhpL/Uf0yjx2zoTUn/6bc+iUIi3CXzixuCD12qa3 H4Ch3zLwiMM5w5V8RA2QdzFey3f0pIJni30xarVpyo6Oqro2r8RBEWchJzMHR5dZDqjU P+PTkT56/gESlx3811lUWYq+ST9+VXMgqdP5dwY+hiMa802DGd8bjjLZGg/XIAs7OumF UhUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qolk//PbSiJep8f/ppmJLtSQPlLqoJawkzylXr+LQHw=; b=ryeMojJnWJjlmR5cJGt9ez+E8NFbvhuF8zh7grDaJggvBt7HRlSeUm1/M/r0gqROVQ fFrmmxEkwc/Odv0L06SapbJt7Wvz1U0qxX+iNBFLL6i9+4ol3dsBBBpXYE5txPKpxZcr y+d69hbs/YSJscVK5cSCmdaLY5RM+4ArKmxwUTmr6/fIolMusnydmXLfosKdyFQROWS6 baVUGc1PLg6dO35CWuvW58iLkWmdXBX3wtyUHL1gHfcS5e9LTMQI8UcbV97KtPjYqHV6 irnliTH8envPMMgt9w+sj9Ds9Y/nWrsQKttJajbXgtPUH8REMlUM3eK2vNGevGwdJbpn Xsag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="UNm5/LMR"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b62-20020a62cf41000000b0053a94865d0esi19715749pfg.80.2022.09.16.04.16.25; Fri, 16 Sep 2022 04:16:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="UNm5/LMR"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229821AbiIPKVz (ORCPT + 99 others); Fri, 16 Sep 2022 06:21:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231701AbiIPKUU (ORCPT ); Fri, 16 Sep 2022 06:20:20 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91A90B08A3; Fri, 16 Sep 2022 03:13:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 43732B82548; Fri, 16 Sep 2022 10:13:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A639C43149; Fri, 16 Sep 2022 10:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663323188; bh=yxmTmAmQYOY0Y1XhFJJ91Ijes9f9h/iULVvKrO+XC0U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UNm5/LMR5umcl4SGonvGipHojehhFjphK68EPwFhwj51gsQKE06S7ideHeKRxK/pW K+RVT6MOn+IvWxfXCT18G++Aylq2m1X0L/MX+E8CA44z2STMHIF1oo7+Pz/Cr0gTnW OcJJlIREkOiRvwZWIz2U4CMLdhe8tk6rEyf8LToc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kurt Kanzenbach , Andrew Lunn , Vladimir Oltean , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 26/35] net: dsa: hellcreek: Print warning only once Date: Fri, 16 Sep 2022 12:08:49 +0200 Message-Id: <20220916100448.045361017@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220916100446.916515275@linuxfoundation.org> References: <20220916100446.916515275@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kurt Kanzenbach [ Upstream commit 52267ce25f60f37ae40ccbca0b21328ebae5ae75 ] In case the source port cannot be decoded, print the warning only once. This still brings attention to the user and does not spam the logs at the same time. Signed-off-by: Kurt Kanzenbach Reviewed-by: Andrew Lunn Reviewed-by: Vladimir Oltean Link: https://lore.kernel.org/r/20220830163448.8921-1-kurt@linutronix.de Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/dsa/tag_hellcreek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/tag_hellcreek.c b/net/dsa/tag_hellcreek.c index eb204ad36eeec..846588c0070a5 100644 --- a/net/dsa/tag_hellcreek.c +++ b/net/dsa/tag_hellcreek.c @@ -45,7 +45,7 @@ static struct sk_buff *hellcreek_rcv(struct sk_buff *skb, skb->dev = dsa_master_find_slave(dev, 0, port); if (!skb->dev) { - netdev_warn(dev, "Failed to get source port: %d\n", port); + netdev_warn_once(dev, "Failed to get source port: %d\n", port); return NULL; } -- 2.35.1