Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220913160224.14951-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20220914214132.GA2173@tom-ThinkPad-T14s-Gen-2i> <CA+V-a8ufbsiz3p2n3LmYxES2aJYN9y8byF9bSyckNFz=fB-5LQ@mail.gmail.com>
 <7a01b1cc-6d00-715c-1e21-b8836a64a9a0@linaro.org>
In-Reply-To: <7a01b1cc-6d00-715c-1e21-b8836a64a9a0@linaro.org>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Fri, 16 Sep 2022 11:40:05 +0100
Message-ID: <CA+V-a8uL=cwYXJD9j61LcM0xXweeVp-Q3fgd5n8C3BM+D9vLXg@mail.gmail.com>
Subject: Re: [PATCH] media: dt-bindings: ov5645: Convert OV5645 binding to a schema
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Tommaso Merciai <tommaso.merciai@amarulasolutions.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Sep 16, 2022 at 11:28 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 16/09/2022 11:24, Lad, Prabhakar wrote:
> >>> +required:
> >>> +  - compatible
> >>> +  - reg
> >>> +  - clocks
> >>> +  - clock-names
> >>> +  - clock-frequency
> >>> +  - vdda-supply
> >>> +  - vddd-supply
> >>> +  - vdddo-supply
> >>> +  - enable-gpios
> >>> +  - reset-gpios
> >>> +  - port
> >>
> >> I think we don't need all of these properties as required.
> >> The only "really" required are:
> >>
> >>   - compatible
> >>   - reg
> >>   - clocks
> >>   - port
> >>
> > Agreed, it's just the driver requirement hence the previous bindings
> > had marked them as required.
>
> Please mention the change from pure conversion (with reason) in the
> commit msg.
>
Sure will do.

Cheers,
Prabhakar