Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-935-ge4ccd4c47b-fm-20220914.001-ge4ccd4c4
Mime-Version: 1.0
Message-Id: <e5433179-c300-482e-9dad-b1b15c56970a@www.fastmail.com>
In-Reply-To: <CAAhV-H7fiyq7tKJw3CsYDBWjJu89oBJqgNZLxgd+UQE=+X6Czw@mail.gmail.com>
References: <20220818040413.2865849-1-chenhuacai@loongson.cn>
 <CAAhV-H7fiyq7tKJw3CsYDBWjJu89oBJqgNZLxgd+UQE=+X6Czw@mail.gmail.com>
Date:   Fri, 16 Sep 2022 12:16:25 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Huacai Chen" <chenhuacai@kernel.org>,
        "Huacai Chen" <chenhuacai@loongson.cn>
Cc:     "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
        loongarch@lists.linux.dev, Linux-Arch <linux-arch@vger.kernel.org>,
        "Xuefeng Li" <lixuefeng@loongson.cn>, guoren <guoren@kernel.org>,
        "WANG Xuerui" <kernel@xen0n.name>,
        "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
        linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        "Jianmin Lv" <lvjianmin@loongson.cn>
Subject: Re: [PATCH] Input: i8042 - Add PNP checking hook for Loongson
Content-Type: text/plain
Precedence: bulk

On Fri, Sep 16, 2022, at 11:53 AM, Huacai Chen wrote:
> Ping?
>
> On Thu, Aug 18, 2022 at 12:04 PM Huacai Chen <chenhuacai@loongson.cn> wrote:
>>
>> Add PNP checking related functions for Loongson, so that i8042 driver
>> can work well under the ACPI firmware with PNP typed keyboard and mouse
>> configured in DSDT.
>>
>> Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn>
>> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
>> ---
>>  drivers/input/serio/i8042-loongsonio.h | 330 +++++++++++++++++++++++++
>>  drivers/input/serio/i8042.h            |   2 +
>>  2 files changed, 332 insertions(+)

This looks like you are just duplicating code from
i8042-x86ia64io.h. Can't you just use that version
directly?

      Arnd