Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp2133929rwn; Fri, 16 Sep 2022 06:14:57 -0700 (PDT) X-Google-Smtp-Source: AMsMyM66kq3UxXv4kCKrGGKvCJMiUmmVmAiH0uE/duxGWaIUwscKpNLcJtFgiHsgSAPluP61+IVN X-Received: by 2002:a17:90b:3ec9:b0:203:27a3:166f with SMTP id rm9-20020a17090b3ec900b0020327a3166fmr12006912pjb.109.1663334097405; Fri, 16 Sep 2022 06:14:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663334097; cv=none; d=google.com; s=arc-20160816; b=A1m8F/5YfjMKk5aD2waV146r2Sdp6dvd5Vg7HkQt/v1iDIH8l99hswZOpVcZKkCDlW 2u2aEyLhjL3/Nku+PwAl+DZbQvNo67AMg4nOOmsqiFzI5gJuJ1QWg79GKLJ3mpEFDOeU p6HJxCW813i2YMCJbLL0gUQrec/EqIL1VEmPpmQNscatZb5nZiGKH+WeCeY2S7daL6+/ mt8D75rBKDCufaTYd9nwhFhEoRL3p2vT7G3xSv0ZolIQQ7d49Zk5xFXIsXD/p8q6XbnP 1Pn+T7n7k8ADVwF8DrQsmRIdS3BNGaPiNCAMp2Gp++CiXbEXWcswt934fId7KZ7vyZHG MlEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Gm1/lfkl3EpEnC+EwOvWMRVvW8rNsAvnsutIh85OzGw=; b=qM6OdKI2a2qPYfr/nMjdgAGuJ2mQ6jYiwy6EKULpfCGwk0HnN1VVUL87ysvcvL5lv9 f3MzvQkDFy23DUD65HKFQmDvKP9nXyZLLkvmkL/FMV/jU2fP375z495fuOrXUR1MDXNJ bTTA7oYQkaBC/dlC/0dE1tktMvXA8TaNARgLwxVGuyJY6VOJyMwWRiDx0lRkFxv1yX0F gGKtigliv1JSYxfZVjf3cbKI4hMr1gbh/Vmbcwa3+fXFYhaFpbYfePze0GS+yN/gUYZo 0y0drdt8e8xwrEozxhAOMuE4ipNU1nWxuoAk4H7DhPFB8xuPIqLf2H/AbT5tMPCQe/UG M8sQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j63-20020a638b42000000b00429f4b62461si20591468pge.431.2022.09.16.06.14.44; Fri, 16 Sep 2022 06:14:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231230AbiIPNAq (ORCPT + 99 others); Fri, 16 Sep 2022 09:00:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230327AbiIPNAl (ORCPT ); Fri, 16 Sep 2022 09:00:41 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DF62E9E6AD; Fri, 16 Sep 2022 06:00:39 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 03EF1153B; Fri, 16 Sep 2022 06:00:46 -0700 (PDT) Received: from bogus (unknown [10.57.48.254]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1274E3F71A; Fri, 16 Sep 2022 06:00:37 -0700 (PDT) Date: Fri, 16 Sep 2022 14:00:35 +0100 From: Sudeep Holla To: Vijayenthiran Subramaniam Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, suzuki.poulose@arm.com, thomas.abraham@arm.com Subject: Re: [PATCH] coresight: acpi: add support for amba dma-330 controller Message-ID: <20220916130035.pbavnjlkh4envc4u@bogus> References: <20220916111912.42733-1-vijayenthiran.subramaniam@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220916111912.42733-1-vijayenthiran.subramaniam@arm.com> X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2022 at 04:49:12PM +0530, Vijayenthiran Subramaniam wrote: > Add ACPI ID for ARM DMA-330 controller to AMBA id list to allow the > probing of the device. > $subject pattern is simply wrong and I see this is just copied from the previous commit which makes no sense here. You can see other commits and their patterns too. Use prefix something like: ACPI / amba: or ACPI: amba: Also "Add .." in the $subject sounds like you are adding the support for the controller here which is not the case. Enable support for Arm Primecell PL330 dma controller Or Add Arm Primecell PL330 dma controller to the supported list -- Regards, Sudeep