Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c97f34a6-8929-1ca3-00db-3926c3229920@intel.com>
Date:   Fri, 16 Sep 2022 15:35:02 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [Intel-gfx] [PATCH v3 02/37] drm/i915: display: fix kernel-doc
 markup warnings
Content-Language: en-US
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
CC:     <dri-devel@lists.freedesktop.org>, David Airlie <airlied@linux.ie>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Lucas De Marchi <lucas.demarchi@intel.com>,
        <linux-kernel@vger.kernel.org>, Sean Paul <seanpaul@chromium.org>,
        Fernando Ramos <greenfoo@u92.eu>,
        Daniel Vetter <daniel@ffwll.ch>,
        <intel-gfx@lists.freedesktop.org>
References: <cover.1662708705.git.mchehab@kernel.org>
 <7e3429ae63900ede4ac2c95f281e2e0221e6946f.1662708705.git.mchehab@kernel.org>
From:   Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
In-Reply-To: <7e3429ae63900ede4ac2c95f281e2e0221e6946f.1662708705.git.mchehab@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0k2K0JUTzFyczNheVEwLzBoM2ZqbEYzSDM4Z0dLSjc3UzJsMmIzMFRNY00x?=
 =?utf-8?B?ZlcxM0p5amlWdG5kMmZoNXdhSnlER0hrMXZ5WFl5Q0xCT3hDTDVyR2VHdjZZ?=
 =?utf-8?B?UXozSVRmLzJqaytia0tXRmNPQXJpQlNPZUF4RGhpL1dsZ2VPbWkwWEhyeis3?=
 =?utf-8?B?NjlUa2tFSis5aGhib09GQWhoeUtwcGNtM0pLNjBYUWZ1SkZ0aTM3QlBCN1NZ?=
 =?utf-8?B?a1gvVlQzOVJsOGZtZmU4WlA5c0ZGK2I4aWxMREdhSS9WSjArL2x3S01FYWNi?=
 =?utf-8?B?QTh0RE1NaFVUeHNBaGxFcE9RNXBvV3hOV3hmUFNTVXVWSzNoMkJUMFBwMlRz?=
 =?utf-8?B?K2lpT0lmbjFFOEMvUG5LM2pmc1pPSndYc0hpSGN6NVQ0MXZFY24rQWhzTFZl?=
 =?utf-8?B?QW9iSVhUZU1kOThGaW8waytJdmxqeVIrSUxQSkxuTHFTdVNhNkVLRWR2V0Vu?=
 =?utf-8?B?a01Qbnd2cy8xVHFzUHcxWWdzRTJBVGRJcCtYS3REK2JlOHROV0xTelhkRDBX?=
 =?utf-8?B?YUdLeFpYQjQ4L1lLY1dWLy9aaC9la1ZUTStSSHFaZDg1K0I5WWFJMDQ0bTZI?=
 =?utf-8?B?ZFdwaTlNTzE1NUZxRFhoSGZNbEYxRjV3M3k2R2ZqUFdkTU90RFdrYkRZUHJx?=
 =?utf-8?B?bjJDVk5MTFo5bHd5NjlLdGlvM1VrS3hrSStyaFRjQ3RxaW05VVhxSGg1ajg1?=
 =?utf-8?B?aVlGSnRLMnZRMnJtR3JyUTdEa0xEQ1N6UXlwdEJwaG90SHlKMWVtL1FqcGRN?=
 =?utf-8?B?ZkY4NUU5dGtuZDV0a3FJaEpKd1UyTnlVT3Z1bXlUQitqQ0Nxd3NOMnNZNytl?=
 =?utf-8?B?eGV6YWVBa1VNK0ZDbFQvS2k3cDlUSDFvM0xpS2FnY2dhOXl5TCtyeHZVbmVX?=
 =?utf-8?B?RFh5S1lYTzU5TTM3QmE0cHpxVEFaRmZFczI5MitSS0pkR2xxZk51UHVlOE8r?=
 =?utf-8?B?VHlsWWFMVFJtZDBIK1BOeVpPdkNDM3dPUk5GcjR2ZTUvT1pSd3V3UU1XaExE?=
 =?utf-8?B?S2pMKzl4R2hLekVFUHh2RHdmeEpuTWpKV1lVTWpsMUJlcWM2Um9zajU0TDZZ?=
 =?utf-8?B?cU1WUHppU20rZ1BWeEZ6WktwM3ZjamZKWkFsaTd1MXAvQW9rTWl6UGx0Ri92?=
 =?utf-8?B?SEdrUkpCSTZ0b0NNODk2TlhVRXZrb0lyWEFranJLcFUrMWN4TTU4NVE3NWto?=
 =?utf-8?B?b2hBbElINmtwSzVQOFI2VFQ1NEFoZC9wWWNtUmV5cEZURzJ5UlpTbkQ2TEY2?=
 =?utf-8?B?TVYvTUt3RzZWc2hEMzlGa3A0SHdIMWJwdmVkdVBFYmZ3L0tmZDJ2Qm5JQStF?=
 =?utf-8?B?Wld0RUM2aGs1RWZnUzRhTXdhejJ5SnM0MjRVZFg3ZWR5M2xUVW5iekNlSmpB?=
 =?utf-8?B?ellrWUxzK3RKT1pldW5sSll4QXdyS1ZFblBVZHNZZDdBejF6cW5oK2lteVM0?=
 =?utf-8?B?WkhqR0ZBdjlDS1o3dzQvdU9tNmxlODM4L09qV1FwSGFjNndLa0JEWVVMRkN2?=
 =?utf-8?B?MHpaWjM0VmY2TmhWbTBuVkIyZnhDcCt4MmlFakViLzdhWnpRNmNuZVNRVlJx?=
 =?utf-8?B?U05MTnJWUGhBM05mb2F4VVBXM1dmRG9kazZJMXdYZ1ArdjJ0WEJmbE1Idjg4?=
 =?utf-8?B?ZFdLelNuODd4Z0thR0ZVdjQxbzFiR2MyRkh6RGlVVTY5SkhCeXBUSkNFU2NO?=
 =?utf-8?B?c3JOWTJNeTNzWEdCc1UrcHI4cnNxQ0JkdDhodklScnd2VW1IZDAwWWpZRmpF?=
 =?utf-8?B?U0M1OE9KcGNTcDdYNURySE85VEVxRGRuRXRzYkVNT3FuTjlNaWkvTWRFSFlS?=
 =?utf-8?B?WU1wUzJXOThXZ3A5UnVxRGYyRkVKUEhiN3l5UUhMZWp6eXdwY2ZRVSsrU3Zp?=
 =?utf-8?B?R1lhcnNJQjhkMURGNURTUW5SVzZTNU04YmtMdW1iVDYxVTZEamV3RDkxeFVH?=
 =?utf-8?B?QWpaZHFGeU9XdlFZZTZrMFhCRDlyQnlWSkZoeUcxNnU3bzFqYTFuKzZLYWtH?=
 =?utf-8?B?d2o3M1dMK3hsQ3V6V1hHb3ZtQWpHZ3g4clBKWUdYU292QXE1NXpabnJlYXF0?=
 =?utf-8?B?N0hzOHo5N2JITUNuVkxPclhHVDVDMDJQQWZxbS9YYVM2MHArTWlpM3lwaUgr?=
 =?utf-8?B?SjRQQVduTG92dFZDT01xTU4xVmwrVkZjV1lKSFBYME9KdkJUam05VFVMYytM?=
 =?utf-8?B?cnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6798b839-a478-45a0-f52f-08da97dff273
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5409.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 12:35:33.3313
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: plDpS2adVZXF63fK3sruxQlTrlNlPLUhKz6l9WZV/zRKUFWJYM6bBExIPStVZxDRc0zU+OIt1gag94rFk5OtHE6xqIurCBYE8R/hUONZZ4s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7151
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks good to me.

Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>

On 9/9/22 10:34 AM, Mauro Carvalho Chehab wrote:
> There are a couple of issues at i915 display kernel-doc markups:
> 
> 	drivers/gpu/drm/i915/display/intel_display_debugfs.c:2238: warning: Function parameter or member 'intel_connector' not described in 'intel_connector_debugfs_add'
> 	drivers/gpu/drm/i915/display/intel_display_debugfs.c:2238: warning: Excess function parameter 'connector' description in 'intel_connector_debugfs_add'
> 	drivers/gpu/drm/i915/display/intel_display_power.c:700: warning: expecting prototype for intel_display_power_put_async(). Prototype was for __intel_display_power_put_async() instead
> 	drivers/gpu/drm/i915/display/intel_tc.c:807: warning: Function parameter or member 'work' not described in 'intel_tc_port_disconnect_phy_work'
> 	drivers/gpu/drm/i915/display/intel_tc.c:807: warning: Excess function parameter 'dig_port' description in 'intel_tc_port_disconnect_phy_work'
> 
> Those are due to wrong parameter of function name. Address them.
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
> 
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/37] at: https://lore.kernel.org/all/cover.1662708705.git.mchehab@kernel.org/
> 
>   drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +-
>   drivers/gpu/drm/i915/display/intel_display_power.c   | 2 +-
>   drivers/gpu/drm/i915/display/intel_tc.c              | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 5dc364e9db49..e8433aa50905 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -2232,7 +2232,7 @@ DEFINE_SHOW_ATTRIBUTE(i915_current_bpc);
>   
>   /**
>    * intel_connector_debugfs_add - add i915 specific connector debugfs files
> - * @connector: pointer to a registered drm_connector
> + * @intel_connector: pointer to a registered drm_connector
>    *
>    * Cleanup will be done by drm_connector_unregister() through a call to
>    * drm_debugfs_connector_remove().
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index 1af1705d730d..b080d65d4461 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -686,7 +686,7 @@ intel_display_power_put_async_work(struct work_struct *work)
>   }
>   
>   /**
> - * intel_display_power_put_async - release a power domain reference asynchronously
> + * __intel_display_power_put_async - release a power domain reference asynchronously
>    * @i915: i915 device instance
>    * @domain: power domain to reference
>    * @wakeref: wakeref acquired for the reference that is being released
> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
> index e5af955b5600..10cda362537e 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.c
> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
> @@ -797,7 +797,7 @@ void intel_tc_port_lock(struct intel_digital_port *dig_port)
>   
>   /**
>    * intel_tc_port_disconnect_phy_work: disconnect TypeC PHY from display port
> - * @dig_port: digital port
> + * @work: workqueue struct
>    *
>    * Disconnect the given digital port from its TypeC PHY (handing back the
>    * control of the PHY to the TypeC subsystem). This will happen in a delayed