Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp2148382rwn; Fri, 16 Sep 2022 06:26:12 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4TXlYK+z3rmJz3ZZT1VFRN5o4nzhMhEaczRO9ANvpoX7k73ncSYKt9bzTlVnPwZ54jUkKG X-Received: by 2002:a17:906:a219:b0:6e4:86a3:44ea with SMTP id r25-20020a170906a21900b006e486a344eamr3735835ejy.385.1663334772619; Fri, 16 Sep 2022 06:26:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663334772; cv=none; d=google.com; s=arc-20160816; b=n8lYjeNt+A/1UoFE11/pFP38YA30iWO3chUyubZCGjCXTut5VzoHNmnRLjd90Nioq1 dpIgACNP9cf0Ai8I/WXy4PiP22WIrJs2alZAHlEh8736h6Cg+z9Bmg0by/ibrS8ZeX/v Iwm1KIHW96QVYTjmNhIWg/3gFwLbzPZLFmiO/WEIpMoPxdpl0fSySlGtmq1dKxJTXaJs aP9AGpOxSOL2JIbCOQClOps601y6S+0v7BPU5bxYoOBRwTNXv6taRAy3mhU2Pz6xS5HY ZEsadVmmCa2wMZgOZ0RSM6M8k7b/IBLG53X3SKac7guNAYWralfJfF69J0rfC+kCLh10 R7Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2x1KQsNKeV0XB9Xv+IrmbO09stNWRLC5Mmb0lQO2Zyo=; b=rs+tdnDpUK0K/ypF1ZpNSzpfsXqOt4il05VbkdJqZiAn/G6XJnYZGeds1vjLMtKdYd jU85ZZbAhVEp3GX+4abdZ67ZUqi5Epqyj0T1mp8sVehfR2FNFXiC+dNskyJGzyBlL7lc Z6Tz0pVkWUYbRM2X66hhhkEsrj2Ppyt0/ljGJvXgM/adVJ4lm1M/4/w6iQhTbnrqrLYu HDztG6pIWsL4kJAOfU8vibZeQHaAgdW6oMr7b+gL2bGSi8hmM4WqFfPMMM1qKPR2AMrD YsbsRfmRXK4PaWmD5wLTlRnfcUA8BCZ8BuiRni5X6HBAlsVUZzuViiJW/+X6Yp0fndQZ Kwhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XMZ6sPmK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jg13-20020a170907970d00b0077c3308aea9si14892358ejc.707.2022.09.16.06.25.46; Fri, 16 Sep 2022 06:26:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XMZ6sPmK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231495AbiIPNN0 (ORCPT + 99 others); Fri, 16 Sep 2022 09:13:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231488AbiIPNNQ (ORCPT ); Fri, 16 Sep 2022 09:13:16 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 090709E6A1; Fri, 16 Sep 2022 06:13:11 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id b21so21402458plz.7; Fri, 16 Sep 2022 06:13:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=2x1KQsNKeV0XB9Xv+IrmbO09stNWRLC5Mmb0lQO2Zyo=; b=XMZ6sPmKspzAh/mU5BE8oUJga20qrfdpZaI+8ae+Q4PHI2WHvMkjKG8fpn8hrxIgp9 cZuNYf1iRJgJud6XO0mQQo1P8lkBFiGR1fPPNrYVEYpjw0C78IYAwuhyTPuaxzSyKQQo 91hH+mHUnMT/Y9e4AkQ7lGoGnwXBcpW6BkQeloJlIIB8oNZh9nsWbYCSZg1bEbCpARL8 43aqXoNe9c7CCLtGZNB7YW9V52K/83AZQC3A2t40uPBBXfglzDUdbi+/XJmakvpeFzjX fmJpwPWdIk+aMICgpl095aNoSe2dI5ExR4pzsIlfExx/7QNs3cm8PjJHOIKr0Ex4L1p/ 7GZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=2x1KQsNKeV0XB9Xv+IrmbO09stNWRLC5Mmb0lQO2Zyo=; b=vsv9+mL4+V8gR/+86uRYk0hSfY0PjvhL7zOqsBoKrwR32Ne4li59x2miGIZTxyR0hu /Dy2p9GyW1ES5+tttls/qFkSdZsZJTIu0bIcQvSypzst4XvlvIxLESTvaZfscm+u8/ID 3T0Deu9ky1fl0NIoPfh910qrk11OrzdGt203qUfaOfyaGiWtNuLXa2WGGGGv8sMAF8pd B2+uu90gnjvdBrrUj0pVmdWGo0ONzdZ65E3IG5fyJKHM7jNty7f0OaRBnR19W0NS8Baq 1x0roL8smtHuO6tkdn2QELHpT52ctgibEl9L9IoSUQLYupmcZfd0oOKThspXEnKtruI6 Wr8g== X-Gm-Message-State: ACrzQf3iIoivGE+iOn3IbEU5CA5wPzSMQxZgcqm8Tw/Ipr91nSW+WaAR EVd2Pkr/+YcEnHTpX76McwjmBYjRPA0Png== X-Received: by 2002:a17:90a:f3d3:b0:203:182b:9cd9 with SMTP id ha19-20020a17090af3d300b00203182b9cd9mr5447745pjb.41.1663333990389; Fri, 16 Sep 2022 06:13:10 -0700 (PDT) Received: from google.com ([2620:15c:202:201:4b0f:4d7b:7d46:26aa]) by smtp.gmail.com with ESMTPSA id q6-20020aa78426000000b0053b9e5d365bsm9620498pfn.216.2022.09.16.06.13.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 06:13:08 -0700 (PDT) Date: Fri, 16 Sep 2022 06:13:06 -0700 From: Dmitry Torokhov To: Michael Walle Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpiolib: fix OOB access in quirk callbacks Message-ID: References: <20220916110118.446132-1-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220916110118.446132-1-michael@walle.cc> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2022 at 01:01:18PM +0200, Michael Walle wrote: > Commit a2b5e207cade ("gpiolib: rework quirk handling in of_find_gpio()") > introduced an array of quirk functions which get iterated over. But a > sentinal value is missing. Add it. Oof... Sorry about that. > > Fixes: a2b5e207cade ("gpiolib: rework quirk handling in of_find_gpio()") > Signed-off-by: Michael Walle Reviewed-by: Dmitry Torokhov Thanks. -- Dmitry