Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: Re: [PATCH 1/2] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0
From:   Alexander Stein <alexander.stein@ew.tq-group.com>
To:     Viorel Suman <viorel.suman@oss.nxp.com>
Cc:     Abel Vesa <abelvesa@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Viorel Suman <viorel.suman@nxp.com>, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Date:   Fri, 16 Sep 2022 15:03:47 +0200
Message-ID: <24402933.EfDdHjke4D@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <20220916110936.jmxgjps5zrcndjxn@fsr-ub1664-116>
References: <20220915181805.424670-1-viorel.suman@oss.nxp.com> <5993734.44csPzL39Z@steina-w> <20220916110936.jmxgjps5zrcndjxn@fsr-ub1664-116>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Hi Viorel,

added missing CC.

Am Freitag, 16. September 2022, 13:09:36 CEST schrieb Viorel Suman:
> On 22-09-16 08:30:46, Alexander Stein wrote:
> > Am Donnerstag, 15. September 2022, 20:18:04 CEST schrieb Viorel Suman 
(OSS):
> > > From: Viorel Suman <viorel.suman@nxp.com>
> > > 
> > > Sync defines with the latest available SCFW kit version 1.13.0,
> > > may be found at the address below:
> > > 
> > > https://www.nxp.com/webapp/Download?colCode=L5.15.32_2.0.0_SCFWKIT-1.13.
> > > 0&ap pType=license
> > > 
> > > Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> > > ---
> > > 
> > >  include/dt-bindings/firmware/imx/rsrc.h | 299 ++++++++++++++++--------
> > >  1 file changed, 203 insertions(+), 96 deletions(-)
> > 
> > This is not bisectable and breaks compilation, as this patch removes
> > symbols which are still used in drivers/clk/imx/clk-imx8qm-rsrc.c
> > (addressed in 2nd patch). IMHO this series should be squashed into one
> > patch.
> 
> Hi Alexander,
> 
> Thank you for review, you are right. Is sending a squashed v2 the usual
> approach in such case or shall I hope that the maintainer will squash them
> before push ? Just want to avoid unnecessary noise.

AFAIK maintainers will not squash patches. This is something you will need to 
do yourself. So sending a v2 seems right.
Also please keep all the other recipients on CC.

Best regards,
Alexander