Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <95073ce7-6f4e-0adf-0c23-44351af0061b@linux.intel.com>
Date:   Fri, 16 Sep 2022 10:23:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH linux-next] ASoC: Intel: sof_cs42l42: use function
 devm_kcalloc() instead of devm_kzalloc()
Content-Language: en-US
To:     cgel.zte@gmail.com, broonie@kernel.org
Cc:     alsa-devel@alsa-project.org, cezary.rojewski@intel.com,
        kai.vehmanen@linux.intel.com, peter.ujfalusi@linux.intel.com,
        Zeal Robot <zealci@zte.com.cn>, tiwai@suse.com,
        ranjani.sridharan@linux.intel.com, liam.r.girdwood@linux.intel.com,
        akihiko.odaki@gmail.com, ye xingchen <ye.xingchen@zte.com.cn>,
        yung-chuan.liao@linux.intel.com, brent.lu@intel.com,
        linux-kernel@vger.kernel.org
References: <20220916062234.153275-1-ye.xingchen@zte.com.cn>
From:   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
In-Reply-To: <20220916062234.153275-1-ye.xingchen@zte.com.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/16/22 08:22, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Use 2-factor multiplication argument form devm_kcalloc() instead
> of devm_kzalloc().
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> ---
>  sound/soc/intel/boards/sof_cs42l42.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/sound/soc/intel/boards/sof_cs42l42.c b/sound/soc/intel/boards/sof_cs42l42.c
> index 85ffd065895d..e38bd2831e6a 100644
> --- a/sound/soc/intel/boards/sof_cs42l42.c
> +++ b/sound/soc/intel/boards/sof_cs42l42.c
> @@ -445,9 +445,9 @@ static int create_hdmi_dai_links(struct device *dev,
>  	if (hdmi_num <= 0)
>  		return 0;
>  
> -	idisp_components = devm_kzalloc(dev,
> -					sizeof(struct snd_soc_dai_link_component) *
> -					hdmi_num, GFP_KERNEL);
> +	idisp_components = devm_kcalloc(dev,
> +					hdmi_num,
> +					sizeof(struct snd_soc_dai_link_component), GFP_KERNEL);
>  	if (!idisp_components)
>  		goto devm_err;
>  
> @@ -543,10 +543,10 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev,
>  	struct snd_soc_dai_link *links;
>  	int ret, id = 0, link_seq;
>  
> -	links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) *
> -			     sof_audio_card_cs42l42.num_links, GFP_KERNEL);
> -	cpus = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link_component) *
> -			     sof_audio_card_cs42l42.num_links, GFP_KERNEL);
> +	links = devm_kcalloc(dev, sof_audio_card_cs42l42.num_links,
> +			    sizeof(struct snd_soc_dai_link), GFP_KERNEL);
> +	cpus = devm_kcalloc(dev, sof_audio_card_cs42l42.num_links,
> +			    sizeof(struct snd_soc_dai_link_component), GFP_KERNEL);
>  	if (!links || !cpus)
>  		goto devm_err;
>