Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Sep 2022 07:03:53 -0700
From:   Hyunwoo Kim <imv4bel@gmail.com>
To:     Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     arnd@arndb.de, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>, imv4bel@gmail.com
Subject: Re: [PATCH v3] char: pcmcia: synclink_cs: Fix use-after-free in
 mgslpc_ops
Message-ID: <20220916140353.GA235538@ubuntu>
References: <20220916134751.GA234676@ubuntu>
 <21d84319-4d1a-8d8e-a098-947772406faf@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <21d84319-4d1a-8d8e-a098-947772406faf@linux.intel.com>
Precedence: bulk

On Fri, Sep 16, 2022 at 04:54:11PM +0300, Ilpo J?rvinen wrote:
> On Fri, 16 Sep 2022, Hyunwoo Kim wrote:
> 
> > A race condition may occur if the user physically removes
> > the pcmcia device while calling ioctl() for this tty device node.
> > 
> > This is a race condition between the mgslpc_ioctl() function and
> > the mgslpc_detach() function, which may eventually result in UAF.
> > 
> > So, add a refcount check to mgslpc_detach() to free the structure
> > after the tty device node is close()d.
> > 
> > Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com>
> 
> > @@ -2517,9 +2548,14 @@ static int mgslpc_open(struct tty_struct *tty, struct file * filp)
> >  	if (debug_level >= DEBUG_LEVEL_INFO)
> >  		printk("%s(%d):mgslpc_open(%s) success\n",
> >  			 __FILE__, __LINE__, info->device_name);
> > +
> > +	kref_get(&info->refcnt);
> >  	retval = 0;
> > +	mutex_unlock(&remove_mutex);
> >  
> > +	return retval;
> >  cleanup:
> > +	mutex_unlock(&remove_mutex);
> >  	return retval;
> 
> Just move the cleanup label instead.

I'm sorry, but could you please explain a bit more?


Best Regards,
Hyunwoo Kim.