Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759527AbXFSXtS (ORCPT ); Tue, 19 Jun 2007 19:49:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756599AbXFSXtH (ORCPT ); Tue, 19 Jun 2007 19:49:07 -0400 Received: from x35.xmailserver.org ([64.71.152.41]:1447 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756336AbXFSXtE (ORCPT ); Tue, 19 Jun 2007 19:49:04 -0400 X-AuthUser: davidel@xmailserver.org Date: Tue, 19 Jun 2007 16:49:01 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@alien.or.mcafeemobile.com To: Oleg Nesterov cc: Linus Torvalds , Benjamin Herrenschmidt , Nicholas Miell , Linux Kernel Mailing List Subject: Re: Fix signalfd interaction with thread-private signals In-Reply-To: <20070619091452.GA94@tv-sign.ru> Message-ID: References: <1182064500.2798.6.camel@entropy> <1182108399.3794.4.camel@entropy> <1182125303.3794.8.camel@entropy> <1182127391.26853.207.camel@localhost.localdomain> <20070619091452.GA94@tv-sign.ru> X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 894 Lines: 32 On Tue, 19 Jun 2007, Oleg Nesterov wrote: > The commited "Fix signalfd interaction with thread-private signals" > (commit caec4e8dc85e0644ec24aeb36285e1ba02da58cc) doesn't implement > this. > > We can do something like > > int signalfd_dequeue_signal(struct task_struct *tsk, sigset_t *mask, siginfo_t *info) > { > if (tsk->tgid == current->tgid) > tsk = current; > > return dequeue_signal(tsk, mask, info); > } > > (still I can't understand why should we change signalfd). Actually, I think signalfd is fine as is, with Ben's patch applied. Signalfd should only fetch shared signals, not specific ones (in any case). - Davide - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/