Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <84da1039-20e0-e0fa-84d2-e718e746fed8@intel.com>
Date:   Fri, 16 Sep 2022 08:52:37 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.2
Subject: Re: [PATCH v4 01/13] x86/resctrl: Fix min_cbm_bits for AMD
Content-Language: en-US
To:     <babu.moger@amd.com>, James Morse <james.morse@arm.com>,
        <corbet@lwn.net>, <tglx@linutronix.de>, <mingo@redhat.com>,
        <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <bagasdotme@gmail.com>, <eranian@google.com>
References: <166257348081.1043018.11227924488792315932.stgit@bmoger-ubuntu>
 <166257359679.1043018.9253512972611409799.stgit@bmoger-ubuntu>
 <a60be378-dce6-08fb-02b8-1efc660ee3cb@arm.com>
 <b3b25255-c5de-f358-33df-1dc53939a5c7@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <b3b25255-c5de-f358-33df-1dc53939a5c7@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUdocUg4Zk9vZ0p2b1owZTArek1IT1V2SVVTdE1sQWlydVV6NkZiMmNVNjRi?=
 =?utf-8?B?ZEZlcDU3MnRvWDBZQjZ3VEYzQXZjMmxiMHloMFQ3MFA1WUVkbWZ0RmZJU1py?=
 =?utf-8?B?STE2K1BLdDFucnQwMUpLR1ROOENQNFRoUjRUZkxVZi9jeE96aW9UY2Z2aDh2?=
 =?utf-8?B?cnB1eWloOU9TREJQd1FUMEpLT01sY3RKYVRPQUw0UXFMUjZkTnZmTjdkenFh?=
 =?utf-8?B?Z0Z2WWh2QTc2MSsycVpEeFBjUisyeWRXZVFiRXhvanc2MzRKclZoeVhzT2tN?=
 =?utf-8?B?UVJpbVRLa0F6V0hUSGhLd0FmelVCcFRPc2dESlZvd1ZzYmZwV2RMT2RzUGFO?=
 =?utf-8?B?YUp0UDJhWGhpZDVld0NXZFNHSDhXT1F1aGRkOUFsM053UXhyalpHK044MHFF?=
 =?utf-8?B?VUNPU2RJTnVTajc5Q0xUbU16eVhNeEpxMDB5RUg4cUEyUHpTTVpFemNNSk80?=
 =?utf-8?B?bElaeFIyam5iRHd1K21ERHNyS1pxdmJtem1ZT01mMDNlalY0eWc2cTl3VkQ2?=
 =?utf-8?B?dUthWGsvdU5CdkNBOFZERzRJcTJRZnRWTzZRaXRqZEZrbWRMMmxRVkRhL01k?=
 =?utf-8?B?S2VPd0VvSER3Q2RTelp5dmVxbFlWMkxLTmw0cnFyT05yWmhWejZlcERzTVZt?=
 =?utf-8?B?OHhDSlZyaXNheThJdWd6OTdXUWVRK0xhM0tVK0dqK1FkUEFmNmt0YWNUQk9D?=
 =?utf-8?B?T3hVMkRHRllDcnl4eUFjL01UME5McWJndFluTXBpcEFPY3BsK2tUMm9sNHNw?=
 =?utf-8?B?T29kSUR6TlNhRXRnQ1dBRzV3ckpFd3FpdEhnem55WlA2U0tyNDh2MlhraEVw?=
 =?utf-8?B?ZkdnOS9JNG9DYTJFUENzVnUvaXNjWTE3b3hMV2xPcjlIMUNyeGM3S0RvU0ky?=
 =?utf-8?B?bHlxUGx5WmhhYmpFRGdOVk9xMFhoTnpZMlJKRkYrTWpibjk5d1F5RFBXdWcv?=
 =?utf-8?B?RjYwM3B5cFNhRENXUElmbERQYURsY1RVc25XSi82dGgyUHl6SS9WTGY0c1dn?=
 =?utf-8?B?QXZ4ZzUzWU9oc2hwSEZTRUsrTlUyUkpSajU3ZkxuZWVIQlR6Wm9CRTNtQ3h2?=
 =?utf-8?B?VysrNzAwSjNSYi9vZHlmeXFWVFZ0Y3E2UHZ4bytWV0lTZHBsY0tpZWNRYTVU?=
 =?utf-8?B?UUdBeWlIN3E3N2IvYnVuZXdVT0lhZGNHUGVEK3FIaktKTHpRUWpvdTRpdm1l?=
 =?utf-8?B?YkkySUZxcUhOZW16TSs2ZkJYbWZwWjR0NXVaUE5saE5FakpHK0ZaZE50WmI3?=
 =?utf-8?B?NHhNcnQzNzRmSlJ6c0RTRlliMnllOGZwall3eUpBQTJwSmhBaGFja3VZa01X?=
 =?utf-8?B?c0VQSHFwMEtIMTJwb2xCa2s4TXlONzZUZ0NhcE9QeXFaUmVkK3pUSytKMlZ0?=
 =?utf-8?B?ODRQOGJobVZSaDZZNm1GWEZ2NHgwNUJSUDFTZExnbWt4QWNDbnNDQXZPenhl?=
 =?utf-8?B?M0xUdS8vT2hkZVpVM1RWaW5HUGxtakErMUZBZEpjdTA0Y0ROdnRIaHEwbVVO?=
 =?utf-8?B?YnBUc0g3S0orWDRGNC9BNDVBNnJiY0ZnbUcwL1ppTElIVmc3MVpnVVBiTk9L?=
 =?utf-8?B?Z1hWbXpWdTJTUkpZNzU3MHlCdDhSY3l1dHppR2xzK3FlbmNnc0ExUFdLMlM5?=
 =?utf-8?B?cm1pNmQ4ZkZqdUZFc2tHbGxsUHpJQmJmd2Y1Tk9rOGdTakw1TkswcEExSWNT?=
 =?utf-8?B?azdjcjI2WVFwYmh4bE91aGxQbTRLeXFlbjJoSXR4KzBySDFoeFMrb0N4WW5E?=
 =?utf-8?B?RDdURmRoOUxNejlIYkRrRG5qWlRqWW5DdUtXK2ptUHZkblEzeG03OHlwQU92?=
 =?utf-8?B?MzNIODU1SnMxeDBCdmdjL2hFV0xiSW9SWkFBa1pMM0tpTkRqaTB1ejhramVO?=
 =?utf-8?B?NFdicFpUQ3FUSm5vRDhrTGZhNGhOQitXdFFLRE5MeEZHZnBzVEhIamtsajJx?=
 =?utf-8?B?WjNpd3dLWEF0TGNmZjR2ekNheGJSNXkyd3doTWFmdm9sQ09VV0dpeVFtekgx?=
 =?utf-8?B?cHd1QmhtMDM1K2thdkl4NEdCUjg0bzNLZkdDUm9ZbDFYV0VHTk1PUk45dkwv?=
 =?utf-8?B?NUw2bVRPNzFjVi95ckQvczY3V0RiVEdFdGRBRkh4dUxsZklkdjQ2U1d5QUZn?=
 =?utf-8?B?N05NdS9oeDBtekx6bms1L2VGU2JjTEdNcXF4OStUZEFmYUc5MmI5cmt5ckJM?=
 =?utf-8?B?bmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a24dded-ff10-45c0-b12a-08da97fb7d63
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 15:52:42.7304
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p5eMYPnw3KWrE5Zamz8waa1FMsR0eFzSgU0ZouhXN+y9tvUPBKfNEyPr7SVkibYrdj+91Aq+F/NhM8+vgxFT/IB65OapEvcE3Ckw9ZI2KZY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4656
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 9/12/2022 7:54 AM, Moger, Babu wrote:
> On 9/9/22 12:00, James Morse wrote:
>> On 07/09/2022 18:59, Babu Moger wrote:


>>> Fixes: 316e7f901f5a ("x86/resctrl: Add struct rdt_cache::arch_has_{sparse, empty}_bitmaps")
>>> Signed-off-by: Stephane Eranian <eranian@google.com>
>>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> Er, who is the author if this patch? If you are reposting Stephane's patch then there
>> needs to be a 'From: ' at the top of the email so that git preserves the ownership. You
> 
> I can add Stephane's name in "From" if it is right thing to do. But this
> patch was modified from the original version Stephane posted.
> 
> https://lore.kernel.org/lkml/20220517001234.3137157-1-eranian@google.com/

True, but also please consider what Stephane posted originally:
https://lore.kernel.org/lkml/20220516055055.2734840-1-eranian@google.com/

A "Co-developed-by" may help with attribution: 

Co-developed-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Babu Moger <babu.moger@amd.com>

Reinette