Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp2406021rwn; Fri, 16 Sep 2022 09:47:27 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6bYDCO3dzX2xUbkRjvkdIn2MQznGNrhTQ3YGai+ZtqGhJ3JMc8E8lYRpbPho7/XUGy0Dmd X-Received: by 2002:a17:902:da82:b0:178:38ee:70b with SMTP id j2-20020a170902da8200b0017838ee070bmr688143plx.85.1663346847367; Fri, 16 Sep 2022 09:47:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663346847; cv=none; d=google.com; s=arc-20160816; b=eaCV8+OvsBC4KeCJ+JljegU0OXigNYFK0uw2QZ5DNxK7y32sGQ+oK5hBDLVwVRKlzn paYArj1AtFiiZsCGs0D18xiTz2zR9yg3GtaHW4lPOotK+JF8JLfhKQ/upjTOsv3OyzKG PVtGMPvZt3zWWCSFhhoRpskoI6aBa5mzzDHpa8AO4RS1DRwVWL29IMOjtiBYMftET7RI At5FMvjC1i3tX0v6PoUVBWl1ct69weoLpmMFyH7rfsr3I6XxrPNAEU1f6DlNf3CpKhem L88WiLfBPqsUcAsQWqzn4GP278DjiS6FdPFkV1jKs8eSe7ERcYs4GfrA5Ou2cNR3fB0A xYMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=e2p+OySg34u2Cmnm2TX2BMviAi6Cnk2NeRN4VrOI9yM=; b=sJHp6PP6ZC9BJIWR7K8kTiMjDGTS1l4PGKVvw4xyzBN5p92STI2SpxnMsKGlpfsZMg tbu1NtDhyNWX4GECm1aSHIRaFIZELcMYMWQ+fjAoaeyw2FK6JtHLyPKspacxGtq760pB Cm8O1aRf44mxkH23wWY2Js6wFtv3jNKdYpKkynEpei+7Lr5ORCxGG/cbtBFrfg29ATuW FkFJhkK7/4IMnLxVZWhtvlVW8yujANPn1tJYhSQOP6y/LSii5bRgsFuosIljfMd1iHSx FUSCHPaxVOjwNPJ/NpR2B52Phq+2wb4gpUDxmM6JZBvR1N9CX5FzkMrUG+vPm2eQOdyW Dnow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sj+xbk4M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 133-20020a63048b000000b00439befc0a0dsi1777040pge.57.2022.09.16.09.47.16; Fri, 16 Sep 2022 09:47:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sj+xbk4M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229709AbiIPQh0 (ORCPT + 99 others); Fri, 16 Sep 2022 12:37:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229690AbiIPQhY (ORCPT ); Fri, 16 Sep 2022 12:37:24 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E199088DF2 for ; Fri, 16 Sep 2022 09:37:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A8AF1B82865 for ; Fri, 16 Sep 2022 16:37:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4795C433C1; Fri, 16 Sep 2022 16:37:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663346241; bh=vLKW3Gq6muuTLKVz5phR18jx4OuzQbbEePlcPKmt4oo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sj+xbk4MXxrHXdhICPcKsreC2faYMsGk+DvIEUmZ9rbxopWBVIaSfPMVS4MB3z0fX bwrOfcnvn2C8tK8+O5zANRFoMd9TfsPZ29Vy8mcAWkIihafPE0Wqe/uHR1Ozko0/ED VKEPQfi+y3MYSLYh5YzaIMKN3a15EjKt44aG2hcNfm+TwQJTiQIcP5v+9QOsBqb2QB 01fjiK8lJ1XRuXHnJ+jpHXlmuycYsYLMmCGWRRuMBIO2UejhRsidKd5T2+TgUlEuTw p8Futp9m2xy4jDbtd6JWYYeVDUo2JwXjHEZvZ04qu2y3uSoOsrLnxtdbO+TlFEWjdh TVLGslW9yRcQg== From: SeongJae Park To: xiakaixu1987@gmail.com Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH] mm/damon: return void from damon_set_schemes() Date: Fri, 16 Sep 2022 16:37:19 +0000 Message-Id: <20220916163719.17577-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1663341635-12675-1-git-send-email-kaixuxia@tencent.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Sep 2022 23:20:35 +0800 xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > There is no point in returning an int from damon_set_schemes(). > It always returns 0 which is meaningless for the caller, so > change it to return void directly. > > Signed-off-by: Kaixu Xia Reviewed-by: SeongJae Park Thanks, SJ [...]