Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <75585c26-b4bc-8004-dc45-cedba6b8b392@kernel.org>
Date:   Fri, 16 Sep 2022 10:43:01 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.13.0
Subject: Re: [net-next v2 1/3] seg6: add netlink_ext_ack support in parsing
 SRv6 behavior attributes
Content-Language: en-US
To:     Andrea Mayer <andrea.mayer@uniroma2.it>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        Shuah Khan <shuah@kernel.org>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
        bpf@vger.kernel.org
Cc:     Stefano Salsano <stefano.salsano@uniroma2.it>,
        Paolo Lungaroni <paolo.lungaroni@uniroma2.it>,
        Ahmed Abdelsalam <ahabdels.dev@gmail.com>
References: <20220912171619.16943-1-andrea.mayer@uniroma2.it>
 <20220912171619.16943-2-andrea.mayer@uniroma2.it>
From:   David Ahern <dsahern@kernel.org>
In-Reply-To: <20220912171619.16943-2-andrea.mayer@uniroma2.it>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/12/22 11:16 AM, Andrea Mayer wrote:
> An SRv6 behavior instance can be set up using mandatory and/or optional
> attributes.
> In the setup phase, each supplied attribute is parsed and processed. If
> the parsing operation fails, the creation of the behavior instance stops
> and an error number/code is reported to the user.  In many cases, it is
> challenging for the user to figure out exactly what happened by relying
> only on the error code.
> 
> For this reason, we add the support for netlink_ext_ack in parsing SRv6
> behavior attributes. In this way, when an SRv6 behavior attribute is
> parsed and an error occurs, the kernel can send a message to the
> userspace describing the error through a meaningful text message in
> addition to the classic error code.
> 
> Signed-off-by: Andrea Mayer <andrea.mayer@uniroma2.it>
> ---
>  net/ipv6/seg6_local.c | 44 +++++++++++++++++++++++++++----------------
>  1 file changed, 28 insertions(+), 16 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>