Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <622ae86d-39ad-c45e-ec48-42abf4b257d2@samsung.com>
Date:   Fri, 16 Sep 2022 19:57:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
        Thunderbird/91.11.0
Subject: Re: [PATCH v13 13/13] dm: add power-of-2 target for zoned devices
 with non power-of-2 zone sizes
Content-Language: en-US
From:   Pankaj Raghav <p.raghav@samsung.com>
To:     Mike Snitzer <snitzer@redhat.com>
CC:     <hch@lst.de>, <agk@redhat.com>, <damien.lemoal@opensource.wdc.com>,
        <axboe@kernel.dk>, <snitzer@kernel.org>,
        <linux-kernel@vger.kernel.org>, <Johannes.Thumshirn@wdc.com>,
        <linux-nvme@lists.infradead.org>, <pankydev8@gmail.com>,
        <matias.bjorling@wdc.com>, <linux-block@vger.kernel.org>,
        <bvanassche@acm.org>, <gost.dev@samsung.com>,
        <dm-devel@redhat.com>, <hare@suse.de>, <jaegeuk@kernel.org>,
        Damien Le Moal <damien.lemoal@wdc.com>
In-Reply-To: <e42a0579-61b2-7b77-08cb-6723278490cc@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
CMS-TYPE: 201P
References: <20220912082204.51189-1-p.raghav@samsung.com>
        <CGME20220912082220eucas1p24605fdcf22aedc4c40d5303da8f17ad5@eucas1p2.samsung.com>
        <20220912082204.51189-14-p.raghav@samsung.com> <YyIG3i++QriS9Gyy@redhat.com>
        <e42a0579-61b2-7b77-08cb-6723278490cc@samsung.com>
Precedence: bulk

>>
>> Are you certain you shouldn't at least be exposing a different
>> logical_block_size to upper layers?
>>
> To be honest, I tested my patches in QEMU with 4k Logical block size and on
> a device with 4k LBA size.
> 
> I did a quick test with 512B LBA size in QEMU, and I didn't see any
> failures when I ran my normal test suite.
> 
> Do you see any problem with exposing the same LBA as the underlying device?
> 

Do you see any issues here? If not, I can send the next version with the
other two changes you suggested.

Thanks,
Pankaj