Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Sep 2022 10:44:56 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Lee Jones <lee@kernel.org>
Subject: Re: [RFC v1 net-next 2/8] net: mscc: ocelot: expose regfield
 definition to be used by other drivers
Message-ID: <YyS2GHqAxczc73f+@euler>
References: <20220911200244.549029-1-colin.foster@in-advantage.com>
 <20220911200244.549029-1-colin.foster@in-advantage.com>
 <20220911200244.549029-3-colin.foster@in-advantage.com>
 <20220911200244.549029-3-colin.foster@in-advantage.com>
 <20220912154715.lrt4ynyhsfvdbyno@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220912154715.lrt4ynyhsfvdbyno@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?djpS3l/PZUv8rfHIEUTqFBc+GSk0rUDwQ53i401N2wst8NWFm7+nYq30Yt55?=
 =?us-ascii?Q?Nz57N6WG2Hjquwwy8AqMUEflbQSoJn10yzPhM4WK4OZhrFv4RQZ2IsGUeM4X?=
 =?us-ascii?Q?rZTVSIiIhAuUhZ3A1IxDHwBSDtJvyCbnVlQ6iVlLCWe14XmtNc1q3TGZ8B9p?=
 =?us-ascii?Q?8QhzOYAxqFYAKLeLofH+a+ngGIt3RbypKKKpaLAVakICTAtNNXJ9H+nhnoII?=
 =?us-ascii?Q?18LbEdL5A+aZ0GpNFES4AmY5DgQZSvQ6N6+gTchqAKZToXoUDuK6zSiQpJ2m?=
 =?us-ascii?Q?O0sJwRirEXSTWR841y0ZjZkMnDdZbwiqLKaBLxYaz8k1HxZCK4nrRBgbf0bw?=
 =?us-ascii?Q?vcguP1YwnF+IdxrpQk9rjrA4JOw4XahxGK9Pyykc/p9gibQLx0z4MHzM8ioD?=
 =?us-ascii?Q?4A3YeeYWiwi4NuaO+gpx4hae9Pr1gDhGSNRSaWHpcf6Xn+S41aLeMWR9zlps?=
 =?us-ascii?Q?YeR98GIZHE8VNFYxI8/wdxRN1wtioulmxJWlX8VL142fncOsdFdA78EV2N5Q?=
 =?us-ascii?Q?ywjvChI5vBjprIqhnB0LI3fzEdJUDHWpe/sxT3QMlGR9jvu8Jsb2beWAj/9X?=
 =?us-ascii?Q?zsfNLBouMKnLrl02xwqL+tVKezZM/7aC2W+aIBQrH/pqziqAld9uXUf0KKap?=
 =?us-ascii?Q?cCiRhzFc0jpHzNDUmFTJ3cLgq0gm/yXx3FHP8Xyg46v7WnlXO8IX8wq7Bq+8?=
 =?us-ascii?Q?D1phfl2SUjnqOxlTFBAK7H1zo0ZbgYuvFmZ8TqlutcGmBsiomn42fIgKFS1G?=
 =?us-ascii?Q?WhBr1rZAGkpECKoIOGVI77V5kPdzemPdOvpm5sRIo+eGqRZlZZXuF6SqYPlu?=
 =?us-ascii?Q?iPhw/CkOAhOdrKieedTV71RK41OI9Qyg1WDoDU17SYGH4kblFmokOSV7TCC6?=
 =?us-ascii?Q?UjtKnro/NoeaxCU9CeFt86Jfdj9mqj2IcfznGMK90nCwJSE/AwZnTRdNMQHy?=
 =?us-ascii?Q?eNCiBHkzhd+NVHkX+yr3kqtRuMN8XITyVLpEJmfHpjtenISP8a/hJ1Ifayph?=
 =?us-ascii?Q?Bugv4pUvssYvOuyWa9Q8/d8NxkIZF2ih1e/8lBPZNZdzKCH7boREg2RcbB87?=
 =?us-ascii?Q?9a8UQedWFoN1em8NEEAZgiuzCUNl/lwLOlAsVFjOXBU43LDBXR79kFK5DNuj?=
 =?us-ascii?Q?7hOWvAZZPK8VUBAuueHGinrvhDxVYGxc//L6zngsX7556ufgf9ybOa5WqyS4?=
 =?us-ascii?Q?gVUVenGIF/7lM8YgC5ScCSMlokj/zlafBG96kmnmljj1XYlC+/ejv3ZiCAZ2?=
 =?us-ascii?Q?P6cJFtwQ+IZfGktXKfkW79PbOmmsyqd871IEfQzZBwKCX32OW1XMVoiS+0n1?=
 =?us-ascii?Q?7V1/G8riS3rms/uj0zXlpzNQ4OycOSsrHiEGAmMeX2viYeolOefLUz8U8Fd7?=
 =?us-ascii?Q?Jx/sTn1nlXk20S0s+iy7uR37iq70XTwUVPfc0qMfk0XV6foWUDAvWCZ3YzGE?=
 =?us-ascii?Q?jUYjhzLTzQbcnyHK/kwaEIbPhM7mmzQxSnuvqyJDd+f3Bzb7TCWZmd7yTR0R?=
 =?us-ascii?Q?vT9skw/REpX7CNvYj/ABmrpZVz1mkH+G9hRgKgDht094ZWihKvZzLP40Wflp?=
 =?us-ascii?Q?229keYg7F6KitJ+HWhfGEWPZWkorCp5Kr0LIaP9iy6YU0hXLge52nStooHMH?=
 =?us-ascii?Q?3g=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d0b6953-5476-4bf4-f5d0-08da980b2d9e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 17:45:00.5675
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +E0VZ9rJIKUqtWFf3JeiE9jmYOBrRRJrf/GrBAoP2VWufyVZwB/Jgj+iuHq+QRT4nm99DYUzs0ytMaZqeGPoXm2gHeP6yoI0DPyq3s4o1TM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5228
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 12, 2022 at 03:47:15PM +0000, Vladimir Oltean wrote:
> On Sun, Sep 11, 2022 at 01:02:38PM -0700, Colin Foster wrote:
> > The ocelot_regfields struct is common between several different chips, some
> > of which can only be controlled externally. Export this structure so it
> > doesn't have to be duplicated in these other drivers.
> > 
> > Rename the structure as well, to follow the conventions of other shared
> > resources.
> > 
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > ---
> 
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

I'm assuming you'll agree with my a-ha moment regarding ocelot_reset()
being in the ocelot_lib.

There might be a few others as well. Should I add them as more "export
function X" commits, or squash them (and these already-reviewed commits)
in a larger "export a bunch of resources and symbols" type commit to
keep the patch count low?