Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7c01a2b8-bfb7-df72-faae-0b940ea0f149@linux.dev>
Date:   Fri, 16 Sep 2022 11:37:46 -0700
MIME-Version: 1.0
Subject: Re: [PATCH bpf-next] bpf/btf: Use btf_type_str() whenever possible
To:     Peilin Ye <yepeilin.cs@gmail.com>
Cc:     Peilin Ye <peilin.ye@bytedance.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220914021328.17039-1-yepeilin.cs@gmail.com>
Content-Language: en-US
From:   Martin KaFai Lau <martin.lau@linux.dev>
In-Reply-To: <20220914021328.17039-1-yepeilin.cs@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/13/22 7:13 PM, Peilin Ye wrote:
> From: Peilin Ye <peilin.ye@bytedance.com>
> 
> We have btf_type_str().  Use it whenever possible in btf.c, instead of
> "btf_kind_str[BTF_INFO_KIND(t->info)]".
> 
> Signed-off-by: Peilin Ye <peilin.ye@bytedance.com>
> ---
>   kernel/bpf/btf.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> index cad4657ba2ce..81dc7423d723 100644

This clean up makes sense.  The patch cannot be applied though [0], so 
it is marked as 'Changes Requested'.  Also, where is the cad4657ba2ce 
coming from?  It can't be found in the bpf-next tree.  Please rebase on 
the bpf-next and resend.


[0]: 
https://patchwork.kernel.org/project/netdevbpf/patch/20220914021328.17039-1-yepeilin.cs@gmail.com/