Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp2533331rwn; Fri, 16 Sep 2022 11:47:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5TxZK/S/5v5l6vpzVXBdt8eyN1YWDzFcOrpiFo/w9TZMj51voQt1jj0qtD003s10udXxae X-Received: by 2002:a63:6b44:0:b0:434:ad17:5e1a with SMTP id g65-20020a636b44000000b00434ad175e1amr5785802pgc.452.1663354023100; Fri, 16 Sep 2022 11:47:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663354023; cv=none; d=google.com; s=arc-20160816; b=0eRojPmm9wj/PkcFHypNDz3UZZ7enZzy5RQN4bsl6+2LjcRzb5vsRqD0jTmoMYpCf2 B+n9ArPs/SM9rnHCR8mvV3BCvCoHD52StdBy26HVt/+60BSUDQECOECcHpVJSWfzV2aF ywMkWZwljUrnbVawgPDMXpKz5oV1yWmDm5r4pVRC9grC2GGjwVxKT2yC3/mIyG/YQQ4v CZ5RGJ7d7npOBdx6ecP53BOSMT6XGw0ikgngk7UHS3CbEG1EZ/CdfUjq0RgLY/4pWl6o UyEKTZ4Cpc+jBbtfFKPTC4KP2ICek22awIiVpj1oH6tf2FaLoWwMREcYZ0zvxOdpeAaA Bstw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:in-reply-to :from:references:cc:to:content-language:user-agent:mime-version:date :message-id:dkim-signature; bh=PHd6kjLnJ0eKhdd4fw/gC/C7d0LeZYsJWCumoJ4LYDY=; b=gB6qOZjBMJy08h4nf+EO4J5sNQNV0fx2oFkNswXsEaBWfwzdKCwYnEW4SfLugj1Qq7 iMfe6jhwQ2Fq5TW07mQLXrR8xLB5y9aMU+WOiBqLDX85IzIz5ZY5hI+BIowu7jOmHA1b 4PBDOs/6x0PQG8hvSW+KwRZXMjWl7LG6PUgGFBDHb5gapJ86mqVHP5Zp5wWoURtleGLh W6jPGtWyyiz7QZhXdzBznvI0IidUNDVR8ZMIEkqVF56xduFUEcKQcVSf6quaPWEB4jnr Vsh+iOOELa4znNX6Pczm7EzwJbHVm2HN+zwyaPL6Lg8W7EY8hNz/ZUnqfj0vzbUCMdk6 0Ewg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@deltatee.com header.s=20200525 header.b=SqFbAwCB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=deltatee.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q17-20020a056a00089100b0052d9e5f07d9si19969853pfj.210.2022.09.16.11.46.51; Fri, 16 Sep 2022 11:47:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@deltatee.com header.s=20200525 header.b=SqFbAwCB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=deltatee.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229997AbiIPSgp (ORCPT + 99 others); Fri, 16 Sep 2022 14:36:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230038AbiIPSgd (ORCPT ); Fri, 16 Sep 2022 14:36:33 -0400 Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B63CCB81EC; Fri, 16 Sep 2022 11:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:content-disposition; bh=PHd6kjLnJ0eKhdd4fw/gC/C7d0LeZYsJWCumoJ4LYDY=; b=SqFbAwCBJ+aLnzqE/IAGgf9qjk I3bRLpsEs5GvSkVyfDD4ftjJQ18I8JpnT+LippC9e751+OoSsdi56VoDucXZLWlFK+mLrvrPi2r8N dr7vuFsqKrWarj+YpWDj6kdZF0srp7IdxT78KK9riADKPBJ5neJUBxmtfb9ibnFJjqfZSFJlgzMYx F4QOW5EXqNuEXEeXod1IguibisyTljzFZWcA87RpA7h6zZRpjl/MuU/XfdKbrlkQ0Fdx+6Vnv58oS 2XLG0BV/v6Im84usR2nPaODigeGH7kvjDhF99thqje5M+yKLeqS1nEQkD9QtfH/2CSe/vqcFaUCuA pbLQqzug==; Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1oZGCR-003JPg-1M; Fri, 16 Sep 2022 12:36:27 -0600 Message-ID: Date: Fri, 16 Sep 2022 12:36:26 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-CA To: Yu Kuai , song@kernel.org, guoqing.jiang@linux.dev, pmenzel@molgen.mpg.de Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com References: <20220916113428.774061-1-yukuai1@huaweicloud.com> <20220916113428.774061-5-yukuai1@huaweicloud.com> From: Logan Gunthorpe In-Reply-To: <20220916113428.774061-5-yukuai1@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: yukuai1@huaweicloud.com, song@kernel.org, guoqing.jiang@linux.dev, pmenzel@molgen.mpg.de, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com X-SA-Exim-Mail-From: logang@deltatee.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Subject: Re: [PATCH v3 4/5] md/raid10: fix improper BUG_ON() in raise_barrier() X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-09-16 05:34, Yu Kuai wrote: > From: Yu Kuai > > 'conf->barrier' is protected by 'conf->resync_lock', reading > 'conf->barrier' without holding the lock is wrong. > > Signed-off-by: Yu Kuai Reviewed-by: Logan Gunthorpe