Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp2562317rwn; Fri, 16 Sep 2022 12:16:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5NhSQad3JWS32rM9spBZXTBBGbKnbQB61NZBs4Iy91IEqdgZ1y1L6vYQyCCN4fBoJIXWPr X-Received: by 2002:a05:6402:d0b:b0:443:df38:9df with SMTP id eb11-20020a0564020d0b00b00443df3809dfmr5063284edb.9.1663355765362; Fri, 16 Sep 2022 12:16:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663355765; cv=none; d=google.com; s=arc-20160816; b=vC1do/PniDIIcSKzkWZJnTT3TCUAZo4wIYqoRIlgFqRjG895dYe5t08TWMSWWWKDlQ 3R4i7Cq8zspoNhymg6qSnevAZ5PUkCh+ZWGUK/NGqeZ8sXh25+HZPqiw9a7vLdOy/NZ+ qmaWOHenDMxPx6z/d7/lSiQO3XIgWMR58riKfqCPpPWRTbnUPGjCvLu9/q0aSV0/zl4p ssdgfdtPM5dlDYKTlSXd7BtJeqeTNbHOfh3PMe9yYRtUSkjdo+8jH3e5e+DGNXeDNiB5 wcNJH0r5iMGKUdgNDlITQm9p/zirXkJo+h6mgSfzIRoe5pcwe8W/AtuXy7Elt3aMdFPl rn6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:in-reply-to :from:references:cc:to:content-language:user-agent:mime-version:date :message-id:dkim-signature; bh=4+dPLZdWUnKzU4ZkJ4V0RP0ju1C8Qy705+qCVjBHdRE=; b=PVcIbqQt5NRuCB2K8+dsPhKSvP6MfBSqoVPOq4MKq4nN9V4lvU27HnCY93dlQL69bm SBiHsOaQ7RBosYrAdVt8xzIqN6km7uY09u3KqvwpnePiDFWEK7T7QYQehMOGcGjc/80o bBKPs3KF4Xs1/dKBx58xt6kX2Zv5OdvX7zRrZIrqVSH76ifRDe4BulqYHryuWFRg9LGc jxFl5jPqH1/kN4/rwP93aTooLibrT2L4HaHqmgqfe4CpwK2TRxQB6IZCHRfkoaIP9IzE Mf/ljsvx97usYeTv/By862Uzqd5q8qdt+XPSTGJIDjCn7i+BLMQbAt3Ghdzas0CC/Zap 1+RQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@deltatee.com header.s=20200525 header.b=KBGBDU5f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=deltatee.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g15-20020a1709065d0f00b0077f92be81aasi12515294ejt.379.2022.09.16.12.15.38; Fri, 16 Sep 2022 12:16:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@deltatee.com header.s=20200525 header.b=KBGBDU5f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=deltatee.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230072AbiIPSiL (ORCPT + 99 others); Fri, 16 Sep 2022 14:38:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230105AbiIPSiG (ORCPT ); Fri, 16 Sep 2022 14:38:06 -0400 Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD162B7EEE; Fri, 16 Sep 2022 11:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:content-disposition; bh=4+dPLZdWUnKzU4ZkJ4V0RP0ju1C8Qy705+qCVjBHdRE=; b=KBGBDU5flIZiXtwxOkpRrwNZ3X TDSCi56pEtLE4YWFm+e3pqgLQmWoSBej9nI1JVVf5h6aGUncEjIqD4n877IFykd1Cnq3eHwqS2gwJ HqvYP+QQR2d8KgjJGj+AJCq7noHbR+euAzXrebrW1UdjfOOHoJBQQV8edYHLptDh2Dmlti+BVJ1M7 1OnP4agyVxfrMq/UPU3YiCZbPo8LTfnKpTsccWCZWnLlA25G+fG8VueqoIw3IqySSB3AU1dwiyVzT hgem3IqdKffmp1KbJkGZY9f1G/7KAdYQHu2KKRr1SItaK43I7zkkiQ1XD+Mik+aOoVOMfGlkkvsik aQ3mtELw==; Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1oZGDt-003JQG-Rj; Fri, 16 Sep 2022 12:37:58 -0600 Message-ID: Date: Fri, 16 Sep 2022 12:37:57 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-CA To: Yu Kuai , song@kernel.org, guoqing.jiang@linux.dev, pmenzel@molgen.mpg.de Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com References: <20220916113428.774061-1-yukuai1@huaweicloud.com> <20220916113428.774061-6-yukuai1@huaweicloud.com> From: Logan Gunthorpe In-Reply-To: <20220916113428.774061-6-yukuai1@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: yukuai1@huaweicloud.com, song@kernel.org, guoqing.jiang@linux.dev, pmenzel@molgen.mpg.de, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com X-SA-Exim-Mail-From: logang@deltatee.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Subject: Re: [PATCH v3 5/5] md/raid10: convert resync_lock to use seqlock X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-09-16 05:34, Yu Kuai wrote: > From: Yu Kuai > > Currently, wait_barrier() will hold 'resync_lock' to read 'conf->barrier', > and io can't be dispatched until 'barrier' is dropped. > > Since holding the 'barrier' is not common, convert 'resync_lock' to use > seqlock so that holding lock can be avoided in fast path. > > Signed-off-by: Yu Kuai Reviewed-and-Tested-by: Logan Gunthorpe So far, I've run this series 3 times through the mdadm test suite and haven't detected any issues. Thanks, Logan