Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Sep 2022 14:41:45 -0500
From:   Bjorn Andersson <andersson@kernel.org>
To:     Rajendra Nayak <quic_rjendra@quicinc.com>
Cc:     agross@kernel.org, konrad.dybcio@somainline.org,
        mturquette@baylibre.com, sboyd@kernel.org, mka@chromium.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        johan+linaro@kernel.org, quic_kriskura@quicinc.com,
        dianders@chromium.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 3/3] clk: qcom: gcc-sc7280: Update the .pwrsts for usb
 gdscs
Message-ID: <20220916194145.ec25i3ph3u6p5mhz@builder.lan>
References: <20220916102417.24549-1-quic_rjendra@quicinc.com>
 <20220916102417.24549-3-quic_rjendra@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220916102417.24549-3-quic_rjendra@quicinc.com>
Precedence: bulk

On Fri, Sep 16, 2022 at 03:54:17PM +0530, Rajendra Nayak wrote:
> The USB controllers on sc7280 do not retain the state when
> the system goes into low power state and the GDSCs are
> turned off. This results in the controllers reinitializing and
> re-enumerating all the connected devices (resulting in additional
> delay while coming out of suspend)
> Fix this by updating the .pwrsts for the USB GDSCs so they only
> transition to retention state in low power.
> 
> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> Tested-by: Matthias Kaehlcke <mka@chromium.org>

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

> ---
> v2:
> *Updated the changelog
> *Updated .pwrsts for gcc_usb30_sec_gdsc
> 
>  drivers/clk/qcom/gcc-sc7280.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/qcom/gcc-sc7280.c b/drivers/clk/qcom/gcc-sc7280.c
> index 7ff64d4d5920..7b6e5a86c11f 100644
> --- a/drivers/clk/qcom/gcc-sc7280.c
> +++ b/drivers/clk/qcom/gcc-sc7280.c
> @@ -3126,7 +3126,7 @@ static struct gdsc gcc_usb30_prim_gdsc = {
>  	.pd = {
>  		.name = "gcc_usb30_prim_gdsc",
>  	},
> -	.pwrsts = PWRSTS_OFF_ON,
> +	.pwrsts = PWRSTS_RET_ON,
>  	.flags = VOTABLE,
>  };
>  
> @@ -3135,7 +3135,7 @@ static struct gdsc gcc_usb30_sec_gdsc = {
>  	.pd = {
>  		.name = "gcc_usb30_sec_gdsc",
>  	},
> -	.pwrsts = PWRSTS_OFF_ON,
> +	.pwrsts = PWRSTS_RET_ON,
>  	.flags = VOTABLE,
>  };
>  
> -- 
> 2.17.1
>