Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Sep 2022 14:11:41 -0500
From:   Bjorn Andersson <andersson@kernel.org>
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc:     Vinod Koul <vkoul@kernel.org>, linux-arm-msm@vger.kernel.org,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] arm64: dts: qcom: sc8180x: Introduce Lenovo Flex 5G
Message-ID: <20220916191141.xf2pdioeleyjbmg5@builder.lan>
References: <20220916121204.3880182-1-vkoul@kernel.org>
 <20220916121204.3880182-7-vkoul@kernel.org>
 <CAA8EJprcqrmHQCtYbOT=DWp-0iEWWVC0=-KZRz1DZqK6gE94qA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAA8EJprcqrmHQCtYbOT=DWp-0iEWWVC0=-KZRz1DZqK6gE94qA@mail.gmail.com>
Precedence: bulk

On Fri, Sep 16, 2022 at 03:26:59PM +0300, Dmitry Baryshkov wrote:
> On Fri, 16 Sept 2022 at 15:13, Vinod Koul <vkoul@kernel.org> wrote:
> >
> > From: Bjorn Andersson <bjorn.andersson@linaro.org>
> >
> > Introduce support for the Lenovo Flex 5G laptop, built on the Qualcomm
> > SC8180X platform. Supported peripherals includes keyboard, touchpad,
> > UFS storage, external USB and WiFi.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> >  arch/arm64/boot/dts/qcom/Makefile             |   1 +
> >  .../boot/dts/qcom/sc8180x-lenovo-flex-5g.dts  | 590 ++++++++++++++++++
> >  2 files changed, 591 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> >
> 
> [skipped]
> 
> > +&gpu {
> > +       status = "okay";
> > +
> > +       zap-shader {
> > +               memory-region = <&gpu_mem>;
> > +               firmware-name = "qcom/sc8180x/qcdxkmsuc8180.mbn";
> 
> Is the firmware signed with the test key or with the proper vendor
> key? If the latter is true, the firmware should go to the subdir
> inside the SoC (I'd suggest following the example and using
> sc8180x/LENOVO/dmi_id/)
> 

Correct, this and the remoteprocs should be pointed to
qcom/sc8180x/LENOVO/82AK/

Regards,
Bjorn

> > +       };
> > +};
> > +
> 
> -- 
> With best wishes
> Dmitry