Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Sep 2022 14:09:57 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Xin Hao <xhao@linux.alibaba.com>, songmuchun@bytedance.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] mm/hugetlb: add is_resv_equal_free() func
Message-ID: <YyTmJUsKqAPVk6BH@monkey>
References: <20220916064127.1904-1-xhao@linux.alibaba.com>
 <20220916131249.68d59133cdb0366e0831592b@linux-foundation.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220916131249.68d59133cdb0366e0831592b@linux-foundation.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?r6cEa77SfdMP4pu6kuqHPF4B9sndvlqU3SjUUqDebr8TfCtR6I6xLGmBJ1gz?=
 =?us-ascii?Q?YQk/p9D1QZUVCzvNbEiJ7urza/GzY1q/DohoufzhspO+WKHSU6xLgYQEm0LU?=
 =?us-ascii?Q?K7QR4a1Ja8QVKU3H4+fLoyxBRhfzU2qv8TDQ7QPuyPHXwR5vWZUVAOkD7gZP?=
 =?us-ascii?Q?QcihVMwbr8Ry92Nx+gmAXPFJR6jltvsgjFBH7m8LqUtybPKufzWahhV4yuDp?=
 =?us-ascii?Q?xtQnJV+sYsMvYxFehHDHLThjrfWAq2IH9QjkKiTViGyD1HEFoEwio/1wHcuv?=
 =?us-ascii?Q?LACv2Lw92kgDi+IRbjAzYZukQZie5j6t8lpK7sE9Wf0ETUakYwA/5nZn4Wo6?=
 =?us-ascii?Q?ncXH4dvJzKa2IPSNmofYjlbvR89qhakTgkv2Gzn9/MRN/HbBQHcFOPH4vCyy?=
 =?us-ascii?Q?N8Ky86K/GsVwcL6hQrPFuAzZpLwlLVhqrtWNOBN6RRwWRQIJBC9IUKIJzZ1L?=
 =?us-ascii?Q?bE+d1WXioB6kQ1f66itHlEC48fiGH+hGKypEqG2zLnUiebWO/t9qIjMHonPs?=
 =?us-ascii?Q?kKBZKGyhD+5o9nkaE0ppaKdxO5BNbdFX9EPHEqksaTuuRncn0ANcWWTxx3+Y?=
 =?us-ascii?Q?dYs0saMupYMQ2H6KXnx2SbUesoDWgq/ogiLJu9fb6F+fg7/xcyNrPd8JFcDK?=
 =?us-ascii?Q?XIAZVQuFhdns4fa2VoZjL0bQL0kl5wQstf/9+MkGIy7h85JNvcNyeBMsHzeQ?=
 =?us-ascii?Q?gO7yNOmNRgYgtH2glST2Z/7/lZpm1o8BQY/zA1rWbxvmmLY9XXMVM1AWOuCn?=
 =?us-ascii?Q?+EHeV8j/1yA18QwtZ8JwewJNOfbCFJ4sehoCEtdHqJ9ft6BkAyxdh7P6pFeI?=
 =?us-ascii?Q?O/0ot877VFd4WeG54hDVRopI7KU+EHqURrMc/DodBzS3zLdkEv46A6s601UW?=
 =?us-ascii?Q?XI7CHW0gx1q3qzdNw21YDlUEXEKfKTp98wJ7YNz0D1EcZL5wGh30a/LHeNi4?=
 =?us-ascii?Q?pWcvXLwg0NG64D7SJEx9Hw4NZKqMSyK5SCum88tc/caFr/Kzch4rAX0O05L0?=
 =?us-ascii?Q?kdJKK3TthhWvO+FEMk7/dwLHuuzQuZPG0HPaAcLEB5P7Co4cB1bKYiKUkk5Q?=
 =?us-ascii?Q?Pnr7AV/pi6KLCEuy0xkIQIheDSeqT8v0ybGLu1gvtx+z3xaEmJ2NHyIR/vi/?=
 =?us-ascii?Q?qPAVNgovJVIyqTSHiPqM7rdBuBYmF9njDPX6LF2AkWpeuaFOxFyU0sEu8Nv7?=
 =?us-ascii?Q?U4t8WtyIlGkGk9o4Qd2Rsz0hLR51fdFgz++ZnAgQqOyt7/6gx5cGykMAV2J7?=
 =?us-ascii?Q?6nq8COLgxPrKoAUDHMEV6X+Cm2ATai0MJ5ShqzLQGxP7PRbjVHQO587Atekk?=
 =?us-ascii?Q?Xk8APZVBqTwoZTvfDAF5b8jalOfBDLBmwtn2DdKAq+KD8ZYnakiuXwnsAErz?=
 =?us-ascii?Q?JvXx+aQZ+fh2zl0fWWCCTFscYZDE1sWrNfseCVVaNXtYaT7IU1Sb52MzmqmB?=
 =?us-ascii?Q?unxdPAWYYrWWGsw/lKNQyt4hzbgTNeVRrbXxPzMxNkzmz20BrYjmmKi4dUS7?=
 =?us-ascii?Q?iC68CbAgVS7T5PJLRA+ZTZyKQ/HUIU9KFgLNNCN6oRiTqzi/4IGWnBq7dYpE?=
 =?us-ascii?Q?VqNV/a1gTCVOVpfETud8RiWHc28z1l+1CKk3ezwmUS2Rvyzt+xML4/YOmFgo?=
 =?us-ascii?Q?1A=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8801e01c-2ebf-414a-d200-08da9827d0ee
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 21:10:00.3899
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WzYRgBIG+0uWOVHigSMII8rBJt2UhEh0ef+9xWnJrgSJyGzpwdtn/Z8UvEidrZuMYpTv2EC8KTtmPf5Cdj49yQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5369
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-16_14,2022-09-16_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=890 mlxscore=0
 adultscore=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2209160151
X-Proofpoint-ORIG-GUID: aEh9je0K3uQ40LgNe_42jLnfUVxvmgSB
X-Proofpoint-GUID: aEh9je0K3uQ40LgNe_42jLnfUVxvmgSB
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/16/22 13:12, Andrew Morton wrote:
> On Fri, 16 Sep 2022 14:41:27 +0800 Xin Hao <xhao@linux.alibaba.com> wrote:
> 
> > In hugetlb.c file, there are several places to compare the values of
> > 'h->free_huge_pages' and 'h->resv_huge_pages', it looks a bit messy, so
> > there add a new is_resv_equal_free() func to do these.
> > 
> > ...
> >
> > --- a/mm/hugetlb.c
> > +++ b/mm/hugetlb.c
> > @@ -1191,6 +1191,11 @@ static struct page *dequeue_huge_page_nodemask(struct hstate *h, gfp_t gfp_mask,
> >  	return NULL;
> >  }
> > 
> > +static inline bool is_resv_equal_free(struct hstate *h)
> 
> I'm not sure that's a well chosen name.  A better name would reflect
> the *meaning* of free_huge_pages being equal to resv_huge_pages.  Maybe
> something like reserves_exhausted()?

How about calling it free_non_reserved_huge_pages() and returning the actual
value (h->free_huge_pages - h->resv_huge_pages)?

Perhaps available_huge_pages()?

It could then be used in at least one other place
- if (h->free_huge_pages - h->resv_huge_pages > 0)

> This would all be clearer if we'd bothered to document the fields of
> struct hstate :(

Agree, and discussed elsewhwere some may even be able to be eliminated.  I can
add that to my todo list.
-- 
Mike Kravetz

> 
> 
> > +{
> > +	return (h->free_huge_pages - h->resv_huge_pages == 0) ? true : false;
> 
> 	return h->free_huge_pages == h->resv_huge_pages;
> 
> > +}
>