Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v1 net-next 2/2] net: mscc: ocelot: check return values of
 writes during reset
Thread-Topic: [PATCH v1 net-next 2/2] net: mscc: ocelot: check return values
 of writes during reset
Thread-Index: AQHYygB+3lNUS9Vav0i1SxPnUbd9eg==
Date:   Fri, 16 Sep 2022 22:40:10 +0000
Message-ID: <20220916224009.g4prlpphnji5i4zi@skbuf>
References: <20220916191349.1659269-1-colin.foster@in-advantage.com>
 <20220916191349.1659269-1-colin.foster@in-advantage.com>
 <20220916191349.1659269-3-colin.foster@in-advantage.com>
 <20220916191349.1659269-3-colin.foster@in-advantage.com>
In-Reply-To: <20220916191349.1659269-3-colin.foster@in-advantage.com>
 <20220916191349.1659269-3-colin.foster@in-advantage.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z1P2MQ/pzUArJF0hx8l69LffYmoql0OXC4EUO7jD6bpk1FPTdj5BSlcIp+Rn?=
 =?us-ascii?Q?foWt2AKgcaL/KumDiMdnwJcQAcdQY2Bh7KREz1Ej6YbYf3xjtzgFYHze7j3x?=
 =?us-ascii?Q?aAoN7JlvJBeLb4KlOSb4i9KSFih3dVaa9X0c7/BDp4ibt2xQUyMpE1yhQ781?=
 =?us-ascii?Q?wziow//BA6f/HTPfRE78UgdaCwt1Kaj4l4EmThc4Rp58IWMoQMoHBGkU7Y4e?=
 =?us-ascii?Q?NZMmcy6J7WaVUbqw+Yu10lycwdG/RZHZcltlirymVWGkW5Kp51pn/sRa4b+s?=
 =?us-ascii?Q?i2zsRFweVz+Iniz8VF61zy4yt7GJMoNdSDvEoqVkVw+spNZSUgSDl3m9lyFC?=
 =?us-ascii?Q?iiELyV2gwn/lTB+VLjScMqPrGC1ohVX+ALlSXzCQUfEg5OIE+ZA/afM9yHM7?=
 =?us-ascii?Q?2jiEHWNfvBfp+I+1DWfLjV04e+iqn9sL7+IOe1UU78zi3c/INpIkdzHKuJhJ?=
 =?us-ascii?Q?Xji7yT7U65Zp3ZZzm2b5MovNzvgsYd4A6ez/2VNabgp0G6fTDaq/mFODcpXV?=
 =?us-ascii?Q?WPbxY+GCs+4hKKPBupGYUceRWTguBG8WISKOzqN4K/3aDZsEWJhnoNRyLO55?=
 =?us-ascii?Q?azaTROU1tuz0TaiAHgXmN9w3mELtIkDoGOxCxx1kobSkseFQBfbuL9zv0XaM?=
 =?us-ascii?Q?z3R+4XKClXakthLx3myWVZuqzYE/u86EPmLq8TnbuYMH5NnKr0kuSOwlMEN2?=
 =?us-ascii?Q?JtHPF2Oph7lHacNqy/HuslN0wWSsu2unef4c1FDpqRNPEQWx6zZTy800JVQ8?=
 =?us-ascii?Q?NPZWP7OqdvNdhZXdHvG+88lsT8doUxlOiZFkIS+QxIohN7/Yk2UsPQP++3gt?=
 =?us-ascii?Q?QLhaRUHvpdDC1HChDqd0mln8q0s3FVcZ983SewSc88A1k4HrH1DUnPSD9bsA?=
 =?us-ascii?Q?F1Yu7M6vMrN2SesRN0PKz0N+fp9pb5dtJS93B4jKSh/wj5tVtxbI71+y4aNx?=
 =?us-ascii?Q?HyGX7MchpgD21ml4itakqKKcK5HOmSXE71er/iVZ3tg1o2B+vOSga4pH0MTs?=
 =?us-ascii?Q?MoflrauvdYBaUnLWYexq1pq2zU6ZzYRrVtJNlC+UKKNGhDQT8pNmXQFFS0Xe?=
 =?us-ascii?Q?p7UfboGpPhL5lOOvIvkSQopDM+61XesooKa/kKYnHlFxsghXx1S/eUt2Tyok?=
 =?us-ascii?Q?vdB5S0GkUmV793kQYrHdJ6+z0u4DTYsJtBVLAiuabpn0AS8RkytIIQ7vusVo?=
 =?us-ascii?Q?wZcupgjX8HbA2S+J/nQp6QI65VySIUJV8DwYhlzX9UOp9Es9OI7hvdqVCHNE?=
 =?us-ascii?Q?9JjN577cjka/w+oCMXbPanOiy5h9NbOl+pyUGcUYmhtuBVYYXB1Evl7xMYWR?=
 =?us-ascii?Q?tIkG5soLEzAA5bMFQCBTjNTbwHlR+Imt4rdgRHzD6JNXbjnCA0ZkP1FL0SXH?=
 =?us-ascii?Q?B8laN7RJ6j7QpEkzOsTufXtOjMJPHAAuGPH6hw7offaVPTyDNEf0lk6iGHpL?=
 =?us-ascii?Q?ZJB/d4O1hRq2oKnFE082HjieHbvfJ5kjhkW/xpwn4KHPlQDv36yN02nuvKY/?=
 =?us-ascii?Q?AHCBDhbMryc3BRANl3wRsz2i77zwXAzDJP1MI4ORormmwATcEcO08WqODxFl?=
 =?us-ascii?Q?XoZ2Cs1v4r5u4fA9bumzV6ZPMm+AOOUVUC8Isrox08nzvZpNgqsXqcCD1JyN?=
 =?us-ascii?Q?Pw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D52FBC02A2DF5745AE4822F04E3CC754@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e775d20d-3c45-4db3-6a09-08da9834698f
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2022 22:40:10.2918
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oEJFTM2KrNYLAKdRokYUInMxSV3nezVtLgS1ltd0aEI0/F/OtYgPfcK4Q/5P5mPIsWUlR/LqjjAaJQojXkebVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9340
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 16, 2022 at 12:13:49PM -0700, Colin Foster wrote:
> -	regmap_field_write(ocelot->regfields[SYS_RESET_CFG_MEM_ENA], 1);
> -	regmap_field_write(ocelot->regfields[SYS_RESET_CFG_CORE_ENA], 1);
> +	err =3D regmap_field_write(ocelot->regfields[SYS_RESET_CFG_MEM_ENA], 1)=
;
> +	if (err)
> +		return err;
> =20
> -	return 0;
> +	err =3D regmap_field_write(ocelot->regfields[SYS_RESET_CFG_CORE_ENA], 1=
);
> +
> +	return err;
>  }

A kernel janitor will come and patch this up to:

	return regmap_field_write(ocelot->regfields[SYS_RESET_CFG_CORE_ENA], 1);

so it's better to do it yourself.=