Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Sep 2022 16:10:36 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Lee Jones <lee@kernel.org>
Subject: Re: [RFC v1 net-next 8/8] net: dsa: ocelot: add external ocelot
 switch control
Message-ID: <YyUCbLeXmHPs5gJM@euler>
References: <20220911200244.549029-1-colin.foster@in-advantage.com>
 <20220911200244.549029-1-colin.foster@in-advantage.com>
 <20220911200244.549029-9-colin.foster@in-advantage.com>
 <20220911200244.549029-9-colin.foster@in-advantage.com>
 <20220912172109.ezilo6su5w6dihrk@skbuf>
 <YySqm8t0pbH4cqR/@euler>
 <20220916223146.a5djbyvwlh6jekw6@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220916223146.a5djbyvwlh6jekw6@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FvXjEYZtdfwpYv4FYfJevJY3OfPDlK12z1D+VNt/Ldwyndq7khaBX3JyvqQk?=
 =?us-ascii?Q?N2F6Vz1ma+h02fyWXEcYg1Bs74EnvosftNWsX+Ll1fib+rNyD1a8rvn4E7XI?=
 =?us-ascii?Q?mkR86p5NLeBEd09dQEFnf4HXrIRLerII3VsBE7ycp2Kl9o1hd0rc/CKkHJYZ?=
 =?us-ascii?Q?/guKEBdIgj9LyXwYhUWFhDjU+xV8DhP9ANil6bvTRc1raDQecPex+YbPMNUg?=
 =?us-ascii?Q?ToG03u6mKu63OQf03OIbNqmpzjSYtDZgtP/swksDCkMyfwJLryg8nFDn3msB?=
 =?us-ascii?Q?soDpivcoIKhTznTag5K+W/brJXbaXTaCRh0c4gWA7HLbruOzFI2NW2kJhW5B?=
 =?us-ascii?Q?ud6wKZyI74zMlLsSNsyrUf7A1OO+pgFHHiwQttJAfnmq2m1SLlIZ6YFgHKuW?=
 =?us-ascii?Q?Iw+kyTJXK/1mdAq0EeLlf5fon09oA1JGBfUdsoea4NNC0UR5uXwzK5qkT5Q8?=
 =?us-ascii?Q?98Cpl0LhLXllk4DBtaR54AwUuvv282siOG0TQfMeoIlE8+FYTBiwRmFJZvN8?=
 =?us-ascii?Q?u109y1mvDuMd/XgRdFOa11pRmaGGqUFxuGf6YkswUV4ytbU3CIv9RSNRT8LF?=
 =?us-ascii?Q?DBoHExY+uIQtE0z9rRSGFWVarrsZjDyEprYLypJ5Xjgq20O6l+izg9sDHfG+?=
 =?us-ascii?Q?Ea6ex9OOKBNm8SCptws2ucOGo9d/OCWCzx+5BVajRlhGQu+BndYlrRc8Kya1?=
 =?us-ascii?Q?AhVw3Ih3qKL/6PF433s0MRFVfAMDScx8YU+gBrgfORBltByaviOPvx4ZwJ6r?=
 =?us-ascii?Q?sQ7OoxnuF51k01OUv8wPfYSbNcSjPlE6xbzt6Qd9SjhT0GsxGcE3EnrN7BPO?=
 =?us-ascii?Q?21n5VSas+WDupFRUmpyp2ZKCcecvjRdyVgBfLZr02Pm33aIP5T9N/cxYUMI3?=
 =?us-ascii?Q?05jW0uMylXfHv2uQvb2OVr1YcijIb6XV8rcpjNHNbsrbBm5KDc+dBx9fyyFh?=
 =?us-ascii?Q?eTUSMlKRQtBC8kchrbMQqJo2W5Q2a8m7CgzR2LsdxHNDdtB7wESVhhPiZ9bS?=
 =?us-ascii?Q?/ml0RXAC0I7wRu3SwmBf3NNEd76+g1S7ktCKEl9bnk7vGugGNr1Nj8Bbdtbw?=
 =?us-ascii?Q?LIMB5YzvE+SUTUSb9+/mHWqmSAjoBEHVzooZnDiLYpCVqu7DlHyWOMPGzPAI?=
 =?us-ascii?Q?bC0P2gaeEXBhcJt/xLZ2IEHbQAmZ9yQZhmd3gsQjPM/b+An7DC1Y0hEkcx9p?=
 =?us-ascii?Q?ZDmGt9WoYu/5gGVMeLANLHSGjezcHcKETb1m4abJA9qO9QKNIoepJqsJDsqx?=
 =?us-ascii?Q?SlO4zbj7d2iVFcxZrO1/u1gq3hZN3z6ArkQpZwrw9LSE+FtkboJIPeTNJiDy?=
 =?us-ascii?Q?jb8gS2vUOOEj82WmUjAhgRGiXjT5diA5YazaxyCknnD6KzfP4Op+F1JK9vcw?=
 =?us-ascii?Q?Y56nCC1dDMZExJ+1JEi6oBjHt9qo/EHOz05BlX07L5QjCSrZMo0zVwduECpj?=
 =?us-ascii?Q?vnciubwAT6GAwzHx67To6cyA3LyFltI4/G4/MEKxUOKjYgZRAgWjbrC/hZKE?=
 =?us-ascii?Q?2n9ZCuN7fzQAv7HScZUQZxMSBkQzzJ4uA7V1ihSwxGM5zJi2YTLDZzgFoF76?=
 =?us-ascii?Q?EzqqJw4DGmTHM72FB4BEBtPBz+UyKcHnmKGBNrDgtCdObZl8aTJXR855trYC?=
 =?us-ascii?Q?73jItGcY0WnMDaVI5e0K/78=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6270e6a7-b946-4991-723e-08da9838abf1
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 23:10:39.8539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ftND0Ty58QaHvkfHThuZohPK9g2Jlpq2O0D8Wax+EQROxPBY/zBrltN4bLp5T9xhmA2ipLIfrpKBPm6X0v3jnJ5klvDCS2Jcb8QF/a/309k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6202
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 16, 2022 at 10:31:47PM +0000, Vladimir Oltean wrote:
> On Fri, Sep 16, 2022 at 09:55:55AM -0700, Colin Foster wrote:
> Yes, please use as much as possible from the ocelot switch library,
> after all you are driving pretty much the same hardware. I'm glad for
> your revelation and sorry that I didn't think of expressing it this way
> sooner. I think the reset procedure used to be slightly different in the
> times when the ocelot_ext DSA driver also took care of setting up what
> is now the responsibility of the ocelot-mfd driver.

That's exactly right. Early on ocelot_ext was doing all sorts of things
that are now the control of ocelot-mfd and the various subsystems. These
couple procedures seem to be the last relics of those early days.

As I cleaned this up, I realized ocelot_ext_reset_phys() is no longer
needed, as it is handled in the MDIO driver. It looks like there won't
be much to remove when this is all said and done :-)

> Between then and
> now, some time has passed (years if I'm not mistaken)

Thanks for reminding me. If I knew then what I know now... maybe I'd ask
the hardware person to spec a different chip ;-)

I'm joking of course, and looking forward to being able to use this
thing!