Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Sep 2022 16:12:14 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v1 net-next 2/2] net: mscc: ocelot: check return values
 of writes during reset
Message-ID: <YyUCzh0HdEZ3DlQa@euler>
References: <20220916191349.1659269-1-colin.foster@in-advantage.com>
 <20220916191349.1659269-1-colin.foster@in-advantage.com>
 <20220916191349.1659269-3-colin.foster@in-advantage.com>
 <20220916191349.1659269-3-colin.foster@in-advantage.com>
 <20220916224009.g4prlpphnji5i4zi@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220916224009.g4prlpphnji5i4zi@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?npzk+FgIzzPShnKeSigK182u96iAPiTVGyHqpMpAEehI7fyQr1axQtkdFdRo?=
 =?us-ascii?Q?mX8OdIWMe2aX4wkMuB/XO9aadRmT3oUJKPbq7c2kFyeOytTH0gTeSC1JPqJs?=
 =?us-ascii?Q?Ze+SI7f+DNtcFizoEe/SjsP0onZXr9XKTVnCOprKZEpOi7wc99b7MlsKmfB9?=
 =?us-ascii?Q?UMVD9i8ur5evGO5AV0ELcUKfVF3GaVnp952Txit5Tc7uIwtD0yV43oWOiutF?=
 =?us-ascii?Q?QJ+KxBEVVEfc4fJEIIf31FOF9CQhfkIaQ6y8ab6oUM2ZQ8GWxb4d2xQ7xUmz?=
 =?us-ascii?Q?i8vuPSqaxqDMQQg4XSYcx6A03O6Sh2YFNKRCcZAqotXa+65gApaX3jOjEn1b?=
 =?us-ascii?Q?gLcMKfe5NC7fd171PG6CLIzKqJyve567n+p7BdbH8UaayoxuKnFetvxMpJkK?=
 =?us-ascii?Q?XD3EhiLBFSMF31F4HLhWFbMiIhs6dju53QkDNpsJOEITTAzUw1UIJj+/Osa+?=
 =?us-ascii?Q?G/1ujsX7KnM1LUEx3h+B14kldzYJ8uW5jWSZnc35YexwO2QsYqIyhymEFkmK?=
 =?us-ascii?Q?vFiH91VLcp5Z0UjEXen+to0l9+o5A6j06jQLKhqW3veIwC+WdMoGgEHErmO/?=
 =?us-ascii?Q?j6YdwqYQ92ejn4fkL3QfkUu5Fi7h+1KXY/p4HoGzTboJ9uIlcQOuIfuOH0Wj?=
 =?us-ascii?Q?d24YyVFRNsZmmPcQeweZoeDEKho9RQArvDzcGBCEKiVn0/TVuo5zoco9/ZM9?=
 =?us-ascii?Q?B+2PgmvbtvpaNOHcCbT12n8zSqDPF5sN4JLUFQ3JmfMEwkPzCateW6HANLHq?=
 =?us-ascii?Q?wnqYSps77sY+y5Gm/5K7wTryaSrsF6oRYUXrO5b7xRZqqba8c3/dAV6NaVSJ?=
 =?us-ascii?Q?Qz78JDJQOoTFGSaIHG0DbSzVpYLPc78uDDTqN1bVmkqmoC+HqZEfhu8vjIqU?=
 =?us-ascii?Q?6lIa6YFwwapQ2nfH3+kcOcIaSmCjrfqgdeUGoToWtiG2Qb9OdxyXtAQA93BX?=
 =?us-ascii?Q?5Y4Ci8hUktPbSyiZzF8WX3ju3atTNeM0IH9mW9FseCvaP53Aw6CI9xfyD5is?=
 =?us-ascii?Q?vKyAEpdp6fsJuUB5n+PykcbsTpZHh4jliE7ffbd+CGx6uStB8Xu8CB9gj7p2?=
 =?us-ascii?Q?kz4Lvxm/eEtbYS5orGoOKodK75qlmE3uVIVKoNYxjZM3C8aFQZicKLUvtWF4?=
 =?us-ascii?Q?jkO7Wf8J/ZeJoz1xlYPFjLepqkebHF2Q0GAuc29avJOIoKy5gHoebUjhkBbz?=
 =?us-ascii?Q?/Uu5oFCTI9IVvGkdRgZwIYTpRggkaeexlhzrtqvIVYJAij2nPP0ymb4F1iSZ?=
 =?us-ascii?Q?Ei0nGiQ0/Irqcn3IXggFN8J1/kUB28/pGZ4Dj6f28jpfu3PjW7Rz8JUgS6fx?=
 =?us-ascii?Q?WJPvy6lWtN8tbEszRh3qmVabiu0VOrXnu7KBPRIrcILmE2zFOt2QL9RA0wLS?=
 =?us-ascii?Q?ughFzBWpiW9O9JXdWDNbx5PxjBzm2+I4PuymkxtPx/nlnMW28p18ENCF/7ka?=
 =?us-ascii?Q?A/rnqfN39SplCxhn6A0FAnH5uPBLmPvbcT1+qi8hLiMG5Zg3cKPZUjq7Fo+S?=
 =?us-ascii?Q?iXv8bBgsTejSjWJRj7KyrzOoNnyA5TnRNTEZcIJlCEgghcwbrDp1JIMoG9i/?=
 =?us-ascii?Q?dQYNHkYN7pSBpzMrESk0+pTf64GFc5WppBEgZWoATov8fycmQ6CS1WAEmxAd?=
 =?us-ascii?Q?xVrhNlGKsgRHFHleRKmaJy0=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 536a50f1-bf3e-4c44-cd22-08da9838e60d
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 23:12:17.3163
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gv8CUpKSaArOTxt425qDPSYGYchbKgkwiWs2IROabUL+9i5s3ew6bH3WKNcfyaOdtNtCB+GlP+5fzT2oMvrBVojP46t6OP/rX+eRgmwqgGg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6202
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 16, 2022 at 10:40:10PM +0000, Vladimir Oltean wrote:
> On Fri, Sep 16, 2022 at 12:13:49PM -0700, Colin Foster wrote:
> > -	regmap_field_write(ocelot->regfields[SYS_RESET_CFG_MEM_ENA], 1);
> > -	regmap_field_write(ocelot->regfields[SYS_RESET_CFG_CORE_ENA], 1);
> > +	err = regmap_field_write(ocelot->regfields[SYS_RESET_CFG_MEM_ENA], 1);
> > +	if (err)
> > +		return err;
> >  
> > -	return 0;
> > +	err = regmap_field_write(ocelot->regfields[SYS_RESET_CFG_CORE_ENA], 1);
> > +
> > +	return err;
> >  }
> 
> A kernel janitor will come and patch this up to:
> 
> 	return regmap_field_write(ocelot->regfields[SYS_RESET_CFG_CORE_ENA], 1);
> 
> so it's better to do it yourself.

Good catch. That and removing the IS_ERR_VALUE macro from patch 1 and
I'll resubmit after the weekend.