Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4b0d603814c8740b125cc6130b67c79e37405d69.camel@redhat.com>
Subject: Re: [PATCH 0/9] Input: synaptics-rmi4 - Bootloader v7/v8 firmware
 update improvements
From:   Lyude Paul <lyude@redhat.com>
To:     Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     "Jason A. Donenfeld" <Jason@zx2c4.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Fri, 16 Sep 2022 18:39:18 -0400
In-Reply-To: <a959cfe90356b702727413e7c14b246875eb88b6.camel@ew.tq-group.com>
References: <20220608124808.51402-1-matthias.schiffer@ew.tq-group.com>
         <26790cfecb827245187233bc81f9fb89553bb4a7.camel@ew.tq-group.com>
         <c434ba87606d3d7696ae076684ceea67bfe662e3.camel@ew.tq-group.com>
         <a959cfe90356b702727413e7c14b246875eb88b6.camel@ew.tq-group.com>
Organization: Red Hat Inc.
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Would my review count at all here? I hadn't reviewed until now because I
wasn't sure it would, but I'm happy to take a look if you think that'd help.

On Thu, 2022-09-15 at 10:02 +0200, Matthias Schiffer wrote:
> On Mon, 2022-08-15 at 09:43 +0200, Matthias Schiffer wrote:
> > On Mon, 2022-06-27 at 10:31 +0200, Matthias Schiffer wrote:
> > > On Wed, 2022-06-08 at 14:47 +0200, Matthias Schiffer wrote:
> > > > This fixes the firmware update function with bootloader v8, allows to
> > > > recover from interrupted updates with v7/v8, and does some code cleanup.
> > > > 
> > > > I believe that the code that allows to recover from a broken partition
> > > > table is also necessary to make flashing a different partition table
> > > > work at all, but I wasn't able to verify that, as I don't have any firmware
> > > > images with different partition tables to test with. In any case, I'm
> > > > pretty sure that it is working correctly now, as recovery from a mostly
> > > > empty flash without partition table has been tested successfully.
> > > > 
> > > > I have only tested the new code with bootloader v8, and I don't have the
> > > > documentation / interfacing guide for v7, so it would be great if anyone
> > > > could check that I didn't break updates for v7.
> > > 
> > > Hi everyone,
> > > 
> > > any news regarding this patch series?
> > > 
> > > 
> > > Kind regards,
> > > Matthias
> > 
> > Ping - can we get this applied, or at least any kind of feedback?
> > 
> > 
> > Kind regards,
> > Matthias
> 
> 
> Ping - another month has passed.
> 
> Should I resend the series? Not much has happened in the RMI4 driver,
> so the patches still apply cleanly to latest linux-next.
> 
> Kind regards,
> Matthias
> 
> 
> 
> > 
> > 
> > 
> > > 
> > > 
> > > > Matthias Schiffer (9):
> > > >   Input: synaptics-rmi4 - fix firmware update operations with bootloader
> > > >     v8
> > > >   Input: synaptics-rmi4 - introduce rmi_f34v7_check_command_status()
> > > >     helper
> > > >   Input: synaptics-rmi4 - fix command completion check for bootloader
> > > >     v7/v8
> > > >   Input: synaptics-rmi4 - rewrite partition table unconditionally
> > > >   Input: synaptics-rmi4 - reset after writing partition table
> > > >   Input: synaptics-rmi4 - make rmi_f34v7_erase_all() use the "erase all"
> > > >     command
> > > >   Input: synaptics-rmi4 - remove unneeded struct register_offset
> > > >   Input: synaptics-rmi4 - simplify rmi_f34v7_start_reflash()
> > > >   Input: synaptics-rmi4 - drop useless gotos in rmi_f34v7_do_reflash()
> > > > 
> > > >  drivers/input/rmi4/rmi_f34.c   |  16 +-
> > > >  drivers/input/rmi4/rmi_f34.h   |  17 --
> > > >  drivers/input/rmi4/rmi_f34v7.c | 349 +++++++--------------------------
> > > >  3 files changed, 81 insertions(+), 301 deletions(-)
> > > > 
> 

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat