Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Sep 2022 16:16:33 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Bjorn Helgaas <helgaas@kernel.org>,
        Robert Richter <rrichter@amd.com>
CC:     Dan Williams <dan.j.williams@intel.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Alison Schofield <alison.schofield@intel.com>,
        "Vishal Verma" <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        "Ben Widawsky" <bwidawsk@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        <linux-cxl@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Len Brown <lenb@kernel.org>,
        Linux PCI <linux-pci@vger.kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 06/15] PCI/ACPI: Link host bridge to its ACPI fw node
Message-ID: <632503d165627_2a6ded294c6@dwillia2-xfh.jf.intel.com.notmuch>
References: <YxsTfVdOgc9sOOVm@rric.localdomain>
 <20220914221154.GA710889@bhelgaas>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220914221154.GA710889@bhelgaas>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KbNZPLCxOFf3FXdSj44My/9lvXWtBdBIEJnEtPdI+odT2zbM3gWo1NAiDEkD?=
 =?us-ascii?Q?+xq/L/tbl23cz6OS2/zRoQHfr7caESXtdxdoij+K2OnNgcA22J9WlYUS3VRV?=
 =?us-ascii?Q?2WGDd/oX7liQmwF9GVViedoEjB6k7svWsB38EKgPH53wvrH6h5M1KycUzNEW?=
 =?us-ascii?Q?CzR7QWt72IoD6WZMowZQbJdb4DytzpN50w4sQPM7pTyu/MXBuKDuEaIfQV8B?=
 =?us-ascii?Q?in0r/FZKLOEWcDb0hjofyrAJHhC7AaBRb2Qdw99ctAiwGqVmrwOshvH1vXR9?=
 =?us-ascii?Q?3T8FHdr1IO/878iA+2Fs7jelEt80ucER5/nV1dbh9djgr0LhA3NwDLhXATQD?=
 =?us-ascii?Q?SyeFtD4EdxnSq8PPzGWwTl6WlzVIhowt0lhT2STalGkYZuG0MWWTd0h9xnGX?=
 =?us-ascii?Q?FYvSg+4wAXXo0PWef8V92QoQC64DyVGhrA3MiWfI2nTDMsi7r7Lk16LcuWL4?=
 =?us-ascii?Q?Km9GbZkATvyKgTi3GdahzYjWFwW7WgfNYKRlrh3QltTx5ozIHsMTpwIYQTtq?=
 =?us-ascii?Q?1gmKlzEG3GE5+4VgWmRVl2e3tO0ZcP0X28BwEifURTfPmrZu7idUm7KsiUXu?=
 =?us-ascii?Q?OGoUOSIyh3rWnVnVGjXn+uz5wMtSvWVGBq11N55f0RiVjwUHwwMFh3YipIyV?=
 =?us-ascii?Q?jQ6v+NxP28pYl91i+9q/wh4OgVls623bS0uY0ar+GnNRKSlu9fJs8Jgj+OxR?=
 =?us-ascii?Q?E/La4JJKqPCmwzLxjo+6MKnCjqzYmUPC+3gYHpN0tOINBglhvz4zoY4KnvSm?=
 =?us-ascii?Q?ndK5R7GxNNI+Uj9V4l+frcu0Trlyavu53UQ41r2Y2kbgjN0KYOyviaud9HGt?=
 =?us-ascii?Q?oLm5c8/YU7eACkswVUUudkAMPyD7L1L+Q75AA35buy3F3OlU0HNDVV4DG7Eq?=
 =?us-ascii?Q?KJT3iBTjEQl4THuSkA4Go3qOdJhL7G4Ioawa9AcGzlHOqVusTjvTEMWgfA81?=
 =?us-ascii?Q?BYnwLv6uufcJelqwN9KkprzbyNJ0Th4794TdZ51ktWEmYcqvMKcE2KhI7CeP?=
 =?us-ascii?Q?DZVMKd6o39R3eBa6blyFRqIy1/1oNyz0E0QOgVU+qaHQ8rUSZven2y856Dgt?=
 =?us-ascii?Q?y/aJKxayZVw6bC6T2xgm1TrE7giaFfJNCw77WUqtQwDcszxe27QZtNeSfdp8?=
 =?us-ascii?Q?Yd4milLv/m3LHQnwxAgsVrxDCq2b6ZS9HR6fTjOFsRB7/eXKMRPzcGSPK+QG?=
 =?us-ascii?Q?nGuS3ON9lms8aU9nHM0Gd+wG4RJ9YE8v3lGr2MHXUNLcPrCD0LyftNSG8uLJ?=
 =?us-ascii?Q?IBT+81knKn9kA6qEqT9rmBVQhjYE0bMrlywPyyRkArpTEBMWUnsRXltaRWVP?=
 =?us-ascii?Q?lNW7DEp6qAwZ5SM8F4LyP+XjAm7e4Gth5lWQPtZJIsS5tR8KTgrQjRkZ9Jpf?=
 =?us-ascii?Q?uFaNNgV9ns3+zj6eqnSjVilPD1iwWzHMMFbKR8Zw6ZUecgBKPob9VOEJcZ8w?=
 =?us-ascii?Q?4QJ5iSgZ5+Z9S3bB/6s9UDxwghOWcNU00I0Zr46EVKvXJW4Xt47bYoPOye6b?=
 =?us-ascii?Q?CBW0aFpMWM7JmHVguT5C+20SApZz42vXT0ipogVSbLMONNvEX2LGOuR7qOoj?=
 =?us-ascii?Q?1MwBtUF8OGbTspasj0w/pY2wdXqLnDmMSYfGVI1jTKUKg1Eg24WrLodszSf5?=
 =?us-ascii?Q?2A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 871d2cd3-91ff-4915-773c-08da9839808e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2022 23:16:36.6068
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fJrXxZ7T+rO33LmpfC4dlfPUogXM5yGbcUztdWxIe2ziTclmUKFql9AAvd9diYYOkvZ+iudqAz5BgqKoBhtEk1AXN0uBuOQyJrZvIaS7FBM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6568
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Bjorn Helgaas wrote:
> On Fri, Sep 09, 2022 at 12:20:45PM +0200, Robert Richter wrote:
> > On 08.09.22 12:45:16, Dan Williams wrote:
> > > Rafael J. Wysocki wrote:
> > > > On Thu, Sep 8, 2022 at 8:05 AM Dan Williams <dan.j.williams@intel.com> wrote:
> > > > >
> > > > > Robert Richter wrote:
> > > > > > A lookup of a host bridge's corresponding acpi device (struct
> > > > > > acpi_device) is not possible, for example:
> > > > > >
> > > > > >       adev = ACPI_COMPANION(&host_bridge->dev);
> > > > > >
> > > > > > This could be useful to find a host bridge's fwnode handle and to
> > > > > > determine and call additional host bridge ACPI parameters and methods
> > > > > > such as HID/CID or _UID.
> 
> > ...
> > No, it is x86. And true, it is set. So this series is actually working
> > without this patch. It can be dropped.
> > 
> > Now, I just checked my logs. The reason I was adding this is that
> > during code development I modified the code to have bridge->dev.parent
> > set. Then, the fwnode is not linked. I later dropped that change but
> > kept this patch.
> 
> If this patch does the same thing as the ACPI_COMPANION_SET() in
> several pcibios_root_bridge_prepare() implementations, I would love to
> keep this patch, which does it in a generic place, and drop the
> corresponding code from those arch-specific functions.
> 
> But I don't understand the fwnode stuff well enough to know if this is
> feasible.

I took a brief look, but I could not convince myself that these lookups:

arch/ia64/pci/pci.c ((struct pci_controller *) bridge->bus->sysdata)->companion
arch/loongarch/pci/acpi.c to_acpi_device(((struct pci_config_window *) bridge->bus->sysdata)->parent)
arch/arm64/kernel/pci.c to_acpi_device(((struct pci_config_window *) bridge->bus->sysdata)->parent)
arch/x86/pci/acpi.c ((struct pci_sysdata *) bridge->bus->sysdata)->companion

...are identical to what acpi_pci_root_add() used to create the
acpi_pci_root.