Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Lee Jones <lee@kernel.org>
Subject: Re: [RFC v1 net-next 2/8] net: mscc: ocelot: expose regfield
 definition to be used by other drivers
Thread-Topic: [RFC v1 net-next 2/8] net: mscc: ocelot: expose regfield
 definition to be used by other drivers
Thread-Index: AQHYxhmAN1ERRaXlwk6n3S0yVpb9za3iW94AgABRUgA=
Date:   Fri, 16 Sep 2022 22:36:00 +0000
Message-ID: <20220916223600.aokvipptiwdheand@skbuf>
References: <20220911200244.549029-1-colin.foster@in-advantage.com>
 <20220911200244.549029-1-colin.foster@in-advantage.com>
 <20220911200244.549029-3-colin.foster@in-advantage.com>
 <20220911200244.549029-3-colin.foster@in-advantage.com>
 <20220912154715.lrt4ynyhsfvdbyno@skbuf> <YyS2GHqAxczc73f+@euler>
In-Reply-To: <YyS2GHqAxczc73f+@euler>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0dHoe9FOzweyCICAKBFYvDQgX2hqEbP7E3mgy+r2AtBn6k/1zHKZjNUEE5SZ?=
 =?us-ascii?Q?My9dSkAGiVNhweFRsnCW4YZbW45mDAT8jDdIxgZDaEyZ8hUGDfUNQSFzTyiN?=
 =?us-ascii?Q?o4ACoZT4FbvqjFCbeOOOY74IY8jYTURXTa9+KDBkRO9cKUPVOjLvjaXY5BqK?=
 =?us-ascii?Q?DwMg6sODW+IMMfl99E36l4vxe+1qgPBEC1lZ7xPVGlV+sf6uSe6g1Ca2wr3s?=
 =?us-ascii?Q?uuGZ79/BnBZSFR8qfYS3DleYra4H6wtKYgLV27bO92Xz1yCP2Vseusor1S+L?=
 =?us-ascii?Q?7VaesUiRpufrSu6dpHxR6VR5xzCZaTf32sjR1yr1YRGmT3/UuppmH9YA5Uhv?=
 =?us-ascii?Q?eTqVEvncYvTNhU8ZLM0e7aIlJcymlqAkj/w0A0rsQqHcj24Y3jyGdsUvLI88?=
 =?us-ascii?Q?aluiaVlVJUblhDbGCH2HF3Stcxu7SWesqXt7AgcDXoWQSuczGtgbxvVuEjdn?=
 =?us-ascii?Q?nJ2l5ar/bV4r8KL8/ofLDdtQPCz4do5BORzlro3xBULH7ETtImwlC9lJtsMC?=
 =?us-ascii?Q?0nyjYfjK2r8jZXxiV+GokpMPLbrpP0Q/wwGEU5gS509A6/zsm3L75K9SVGmQ?=
 =?us-ascii?Q?CebDBOgAziHxEFqE8d7YeqCbrgmuT1YjbifeC631WKitypzZlztYTPlPhe4r?=
 =?us-ascii?Q?wETblajG71w9OnKD78otARKaAPmeN3SJbKHHBu/wSb0pGeetqLeMcScj2gy7?=
 =?us-ascii?Q?qrSk1LAj15f9FU5krb3WQ3JX1Gn+lqOT08NV7JZbvdIHdiepYrPFQ+DWcQEI?=
 =?us-ascii?Q?vr8GugYkqyfQD9bdr9RCfTRDILhZuiqqE6oGH5mnZAkb+V3zh1eFkOBW0S1b?=
 =?us-ascii?Q?Bg//8fev07bvlWu3s0w3oCAPwR6tFV1FitiiudyS6I5ohllcRsjFQrmmWFgP?=
 =?us-ascii?Q?5fgtgEO25TtPN1UtACRwec9rv2bnOpmemKdMSHvMC/s5gxdkcfNr1245odwl?=
 =?us-ascii?Q?eFJ9RQzudgXsDQeYnMeEtWbf9ca33u7nf//2B8hMuLDpGMHBlD3XYSKnXwpD?=
 =?us-ascii?Q?GJPGk5/TtiuoNdFsyhALjFlNbkluao0qBu8A9eoiLydq8iEIVvyL5GTxBUP7?=
 =?us-ascii?Q?dkx1M8lVq1JPGmys1V/YYxudqAWiweUa3P5s8doIphphXWEsRhCWWDVSp8mc?=
 =?us-ascii?Q?gHj+iPl2z+IbcKU8BCbkNWnTfXtb5+yj1M/CFx4nnIUF5TMUjdQyRh+yE3G7?=
 =?us-ascii?Q?XmX0Zyn+r5OUbsdJ4YG7kBte+Tytm1ZSP4PU0UJz4U+Iid2d2hXJ0nYcQCC5?=
 =?us-ascii?Q?UxnsgYzd9rZfEVhT7D8NKUFiSnVTNEQ3esS4bJGuGzlSFlUvtAPafojw2z+z?=
 =?us-ascii?Q?25kxO8sPb4pIOnOm/llw4jr/K4wlPP6UjYapx3hV4EElRh5RLzrJL+leNCWk?=
 =?us-ascii?Q?GTIj9xMpvqavo0datR81lmt3GXQWCx5QR2z7BKU3V1qvSDVPNYGxnPu8c695?=
 =?us-ascii?Q?EQqRvBsR/2st7MsaAd1tUpyPaVcX167jYCMsxhjJEYZn+H+K3776cIi1JmVn?=
 =?us-ascii?Q?mv5LZa5h88ePgGHQW+J7yHMsshbTHmWTT40gF/N5lSa8V+GdinK+G1VKrrVe?=
 =?us-ascii?Q?H/AYVvBYgrsi5oiBGx6SNLHfsMtrd2MIHgV/dH3YQBKc1tVKRiZZKL4Qo9Hy?=
 =?us-ascii?Q?Hw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5F70ACAB9FB6C0408B05EA1F960AAD49@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e406bb4b-ee9e-4b59-f6da-08da9833d4e4
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2022 22:36:00.8563
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xfjRzzTrbZNwr8Mp8dGP2AJDASlk06XbU252NWaD0qC4Q0VyrY0Q3+11+qUAVrCPKsQzlgsUSaqlFFLwnYTH2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9340
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 16, 2022 at 10:44:56AM -0700, Colin Foster wrote:
> I'm assuming you'll agree with my a-ha moment regarding ocelot_reset()
> being in the ocelot_lib.
>=20
> There might be a few others as well. Should I add them as more "export
> function X" commits, or squash them (and these already-reviewed commits)
> in a larger "export a bunch of resources and symbols" type commit to
> keep the patch count low?

Try to keep patches doing one thing and one thing well (and leave this
patch alone).=