Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9b66564e-2582-03b2-56f1-8037f8aca886@linux.dev>
Date:   Fri, 16 Sep 2022 17:03:42 -0700
MIME-Version: 1.0
Subject: Re: [PATCH bpf-next v3 1/2] bpf, cgroup: Don't populate
 prog_attach_flags array when effective query
Content-Language: en-US
To:     Pu Lehui <pulehui@huaweicloud.com>,
        Stanislav Fomichev <sdf@google.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Quentin Monnet <quentin@isovalent.com>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>,
        Jiri Olsa <jolsa@kernel.org>, Pu Lehui <pulehui@huawei.com>,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220914161742.3180731-1-pulehui@huaweicloud.com>
 <20220914161742.3180731-2-pulehui@huaweicloud.com>
From:   Martin KaFai Lau <martin.lau@linux.dev>
In-Reply-To: <20220914161742.3180731-2-pulehui@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/14/22 9:17 AM, Pu Lehui wrote:
> From: Pu Lehui <pulehui@huawei.com>
> 
> Attach flags is only valid for attached progs of this layer cgroup,
> but not for effective progs. For querying with EFFECTIVE flags,
> exporting attach flags does not make sense. so we don't need to
> populate prog_attach_flags array when effective query.

prog_attach_flags has been added to 6.0 which is in rc5.  It is still 
doable (and cleaner) to reject prog_attach_flags when it is an 
effective_query.  This should be done regardless of 'type == 
BPF_LSM_CGROUP' or not.  Something like:

if (effective_query && prog_attach_flags)
     return -EINVAL;

Otherwise, the whole prog_attach_flags needs to be set to 0 during 
effective_query.  Please target the change to the bpf tree instead of 
bpf-next such that this uapi bit can be fixed before 6.0.

Also, the effective_query issue is not limited to the prog_attach_flags? 
For the older uattr->query.attach_flags, it should be set to 0 also when 
it is an effective_query, right?